openstack/keystone
Code Issues Proposed changes

Merge "Enable hardcoded_bind_all_interfaces Bandit test"

Browse Source
This commit is contained in:
Jenkins
2015-10-08 16:26:16 +00:00
committed by Gerrit Code Review
parent e0e147cf8a 7d07c0881f
commit 0e1d261ecf
3 changed files with 7 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files
bandit.yaml
+1 -2
View File
@@ -51,8 +51,7 @@ profiles:
# Keystone doesn't use rootwrap and never will.
# - execute_with_run_as_root_equals_true
# TODO:
# - hardcoded_bind_all_interfaces
- hardcoded_bind_all_interfaces
# Not working because wordlist/default-passwords file not bundled,
# see https://bugs.launchpad.net/bandit/+bug/1451575 :
keystone/common/config.py
+4 -2
View File
@@ -1081,7 +1081,8 @@ FILE_OPTIONS = {
'eventlet application. Defaults to number of CPUs '
'(minimum of 2).'),
cfg.StrOpt('public_bind_host',
default='0.0.0.0',
default='0.0.0.0', # nosec : Bind to all interfaces by
# default for backwards compatibility.
deprecated_opts=[cfg.DeprecatedOpt('bind_host',
group='DEFAULT'),
cfg.DeprecatedOpt('public_bind_host',
@@ -1096,7 +1097,8 @@ FILE_OPTIONS = {
help='The port number which the public service listens '
'on.'),
cfg.StrOpt('admin_bind_host',
default='0.0.0.0',
default='0.0.0.0', # nosec : Bind to all interfaces by
# default for backwards compatibility.
deprecated_opts=[cfg.DeprecatedOpt('bind_host',
group='DEFAULT'),
cfg.DeprecatedOpt('admin_bind_host',
keystone/common/environment/eventlet_server.py
+2 -1
View File
@@ -73,7 +73,8 @@ class Server(service.ServiceBase):
def __init__(self, application, host=None, port=None, keepalive=False,
keepidle=None):
self.application = application
self.host = host or '0.0.0.0'
self.host = host or '0.0.0.0' # nosec : Bind to all interfaces by
# default for backwards compatibility.
self.port = port or 0
# Pool for a green thread in which wsgi server will be running
self.pool = eventlet.GreenPool(POOL_SIZE)