From 216a4d5fc9e9d1f1956f26e7353cc9f09148aaf4 Mon Sep 17 00:00:00 2001 From: Lance Bragstad Date: Thu, 29 Nov 2018 18:20:07 +0000 Subject: [PATCH] Add registered limit protection tests This commit creates a set of sets that we can reuse across different default roles and scopes to ensure everyone has access to registered limit information. Subsequent patches will make sure we build on this by incorporating default roles for: - system member test coverage - system admin functionality - domain user test coverage - project users test coverage Change-Id: Ibb28ec8f85bad6df531cffc7ba2c5f879e96d297 Related-Bug: 1805372 Related-Bug: 1805880 --- .../protection/v3/test_registered_limits.py | 163 ++++++++++++++++++ 1 file changed, 163 insertions(+) create mode 100644 keystone/tests/unit/protection/v3/test_registered_limits.py diff --git a/keystone/tests/unit/protection/v3/test_registered_limits.py b/keystone/tests/unit/protection/v3/test_registered_limits.py new file mode 100644 index 0000000000..e1ac24b4e8 --- /dev/null +++ b/keystone/tests/unit/protection/v3/test_registered_limits.py @@ -0,0 +1,163 @@ +# Licensed under the Apache License, Version 2.0 (the "License"); you may +# not use this file except in compliance with the License. You may obtain +# a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, software +# distributed under the License is distributed on an "AS IS" BASIS, WITHOUT +# WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the +# License for the specific language governing permissions and limitations +# under the License. + +import uuid + +from six.moves import http_client + +from keystone.common import provider_api +import keystone.conf +from keystone.tests.common import auth as common_auth +from keystone.tests import unit +from keystone.tests.unit import base_classes +from keystone.tests.unit import ksfixtures + +CONF = keystone.conf.CONF +PROVIDERS = provider_api.ProviderAPIs + + +class _UserRegisteredLimitTests(object): + """Common default functionality for all users except system admins.""" + + def test_user_can_get_a_registered_limit(self): + service = PROVIDERS.catalog_api.create_service( + uuid.uuid4().hex, unit.new_service_ref() + ) + + registered_limit = unit.new_registered_limit_ref( + service_id=service['id'], id=uuid.uuid4().hex + ) + limits = PROVIDERS.unified_limit_api.create_registered_limits( + [registered_limit] + ) + limit_id = limits[0]['id'] + + with self.test_client() as c: + r = c.get( + '/v3/registered_limits/%s' % limit_id, headers=self.headers + ) + self.assertEqual(limit_id, r.json['registered_limit']['id']) + + def test_user_can_list_registered_limits(self): + service = PROVIDERS.catalog_api.create_service( + uuid.uuid4().hex, unit.new_service_ref() + ) + + registered_limit = unit.new_registered_limit_ref( + service_id=service['id'], id=uuid.uuid4().hex + ) + limits = PROVIDERS.unified_limit_api.create_registered_limits( + [registered_limit] + ) + limit_id = limits[0]['id'] + + with self.test_client() as c: + r = c.get( + '/v3/registered_limits', headers=self.headers + ) + self.assertTrue(len(r.json['registered_limits']) == 1) + self.assertEqual(limit_id, r.json['registered_limits'][0]['id']) + + def test_user_cannot_create_registered_limits(self): + service = PROVIDERS.catalog_api.create_service( + uuid.uuid4().hex, unit.new_service_ref() + ) + + create = { + 'registered_limits': [ + unit.new_registered_limit_ref( + service_id=service['id'] + ) + ] + } + + with self.test_client() as c: + c.post( + '/v3/registered_limits', json=create, headers=self.headers, + expected_status_code=http_client.FORBIDDEN + ) + + def test_user_cannot_update_registered_limits(self): + service = PROVIDERS.catalog_api.create_service( + uuid.uuid4().hex, unit.new_service_ref() + ) + + registered_limit = unit.new_registered_limit_ref( + service_id=service['id'], id=uuid.uuid4().hex + ) + limits = PROVIDERS.unified_limit_api.create_registered_limits( + [registered_limit] + ) + limit_id = limits[0]['id'] + + with self.test_client() as c: + update = { + 'registered_limit': {'default_limit': 5} + } + + c.patch( + '/v3/registered_limits/%s' % limit_id, json=update, + headers=self.headers, + expected_status_code=http_client.FORBIDDEN + ) + + def test_user_cannot_delete_registered_limits(self): + service = PROVIDERS.catalog_api.create_service( + uuid.uuid4().hex, unit.new_service_ref() + ) + + registered_limit = unit.new_registered_limit_ref( + service_id=service['id'], id=uuid.uuid4().hex + ) + limits = PROVIDERS.unified_limit_api.create_registered_limits( + [registered_limit] + ) + limit_id = limits[0]['id'] + + with self.test_client() as c: + c.delete( + '/v3/registered_limits/%s' % limit_id, headers=self.headers, + expected_status_code=http_client.FORBIDDEN + ) + + +class SystemReaderTests(base_classes.TestCaseWithBootstrap, + common_auth.AuthTestMixin, + _UserRegisteredLimitTests): + + def setUp(self): + super(SystemReaderTests, self).setUp() + self.loadapp() + self.useFixture(ksfixtures.Policy(self.config_fixture)) + self.config_fixture.config(group='oslo_policy', enforce_scope=True) + + system_reader = unit.new_user_ref( + domain_id=CONF.identity.default_domain_id + ) + self.user_id = PROVIDERS.identity_api.create_user( + system_reader + )['id'] + PROVIDERS.assignment_api.create_system_grant_for_user( + self.user_id, self.bootstrapper.reader_role_id + ) + + auth = self.build_authentication_request( + user_id=self.user_id, password=system_reader['password'], + system=True + ) + + # Grab a token using the persona we're testing and prepare headers + # for requests we'll be making in the tests. + with self.test_client() as c: + r = c.post('/v3/auth/tokens', json=auth) + self.token_id = r.headers['X-Subject-Token'] + self.headers = {'X-Auth-Token': self.token_id}