openstack
/
keystone
Code Issues Proposed changes

Change time faking for totp test 

This change moves the time mocking from using freezegun to
using oslo.utils TimeFixture for the unit test
test_with_passcode_in_previous_windows_extended, which was
occasionally failing with 401 errors due to
the totp creation time not properly be faked with
4 extended windows.

Closes-Bug: #1843464

Change-Id: I3aefd99907fbc2d03538c9814f7279b282715679
(cherry picked from commit 6525203c1a)
This commit is contained in:
Gage Hugo 2019-09-24 11:34:37 -05:00 committed by Colleen Murphy
parent 40cbb7bebd
commit 247227f3f3
1 changed files with 3 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
keystone/tests/unit/test_v3_auth.py
View File

@ -5306,9 +5306,9 @@ class TestAuthTOTP(test_v3.RestfulTestCase):
secret = creds[-1]['blob']
past = datetime.datetime.utcnow() - datetime.timedelta(minutes=2)
with freezegun.freeze_time(past):
auth_data = self._make_auth_data_by_id(
totp._generate_totp_passcodes(secret)[0])
self.useFixture(fixture.TimeFixture(past))
auth_data = self._make_auth_data_by_id(
totp._generate_totp_passcodes(secret)[0])
# Stop the clock otherwise there is a chance of auth failure due to
# getting a different TOTP between the call here and the call in the