From 3a7b97e5951280b336ca8d13596b92820a7c73a7 Mon Sep 17 00:00:00 2001 From: Samuel de Medeiros Queiroz Date: Thu, 3 Dec 2015 15:28:36 -0300 Subject: [PATCH] Remove invalid FIXME note There are a couple of notes that does not apply to our code anymore. One because the bug it relates has been fixed; and another because the suggestion does not apply. Related-Bug: #1347318 Change-Id: If1190c76deccf7dc501005082c5e85cf00b7b7e6 --- keystone/auth/plugins/password.py | 2 -- keystone/tests/unit/test_v3_auth.py | 3 --- 2 files changed, 5 deletions(-) diff --git a/keystone/auth/plugins/password.py b/keystone/auth/plugins/password.py index 16492a327d..2d1bef2d69 100644 --- a/keystone/auth/plugins/password.py +++ b/keystone/auth/plugins/password.py @@ -33,8 +33,6 @@ class Password(auth.AuthMethodHandler): """Try to authenticate against the identity backend.""" user_info = auth_plugins.UserAuthInfo.create(auth_payload, METHOD_NAME) - # FIXME(gyee): identity.authenticate() can use some refactoring since - # all we care is password matches try: self.identity_api.authenticate( context, diff --git a/keystone/tests/unit/test_v3_auth.py b/keystone/tests/unit/test_v3_auth.py index e22511e01c..e5017d3339 100644 --- a/keystone/tests/unit/test_v3_auth.py +++ b/keystone/tests/unit/test_v3_auth.py @@ -1399,9 +1399,6 @@ class TestTokenRevokeById(test_v3.RestfulTestCase): # the scoped token can be revoked, and the unscoped token remains # valid. - # FIXME(blk-u): This isn't working correctly. The scoped token should - # be revoked. See bug 1347318. - unscoped_token = self.get_v2_token() # Get a project-scoped token from the unscoped token