openstack
/
keystone
Code Issues Proposed changes

Verbose breakup of method into seperate methods 

This patch breaks up a method that does all possible test combinations
into seperate tests for each single case. [1]

[1]: https://review.openstack.org/#/c/414720/29

Change-Id: Idb3bdd17e57df436a966f9f946638b776485fc9d
This commit is contained in:
“Richard 2017-01-24 16:37:38 +00:00
parent 35deec22f8
commit 3f38162fcc
1 changed files with 27 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

35
keystone/tests/unit/test_v3_identity.py
View File

@ -13,7 +13,6 @@
# under the License.
import datetime
import itertools
import uuid
import fixtures
@ -1124,10 +1123,30 @@ class UserAPITests(test_v3.RestfulTestCase):
self.assertValidUserListResponse(r, ref=self.fed_user2,
resource_url=resource_url)
def test_list_user_with_all_possible_federated_queries(self):
# Create a permutation to test every possible combination of federated
# attributes in the list users query
attributes = ['idp_id', 'protocol_id', 'unique_id']
for attr in range(1, len(attributes) + 1):
for param in list(itertools.combinations(attributes, attr)):
self._test_list_users_with_federated_parameter(param)
def test_list_users_with_idp_id(self):
attribute = ['idp_id']
self._test_list_users_with_federated_parameter(attribute)
def test_list_users_with_protocol_id(self):
attribute = ['protocol_id']
self._test_list_users_with_federated_parameter(attribute)
def test_list_users_with_unique_id(self):
attribute = ['unique_id']
self._test_list_users_with_federated_parameter(attribute)
def test_list_users_with_idp_id_and_unique_id(self):
attribute = ['idp_id', 'unique_id']
self._test_list_users_with_federated_parameter(attribute)
def test_list_users_with_idp_id_and_protocol_id(self):
attribute = ['idp_id', 'protocol_id']
self._test_list_users_with_federated_parameter(attribute)
def test_list_users_with_protocol_id_and_unique_id(self):
attribute = ['protocol_id', 'unique_id']
self._test_list_users_with_federated_parameter(attribute)
def test_list_users_with_all_federated_attributes(self):
attribute = ['idp_id', 'protocol_id', 'unique_id']
self._test_list_users_with_federated_parameter(attribute)