openstack/keystone
Code Issues Proposed changes

400 on unrecognized content type (bug 1012282)

Browse Source 
Unrecognized content type:
  http://paste.openstack.org/raw/18537/

Malformed JSON:
  http://paste.openstack.org/raw/18536/

Change-Id: I76afbf9300bcb1c11bed74eddbe4972c451c5877
This commit is contained in:
Dolph Mathews 2012-06-14 13:47:06 -05:00
parent 66a0b63dab
commit 489c6b60d1
2 changed files with 19 additions and 10 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

18
keystone/middleware/core.py
View File

@ -98,21 +98,25 @@ class JsonBodyMiddleware(wsgi.Middleware):
""" """
def process_request(self, request): def process_request(self, request):
# Ignore unrecognized content types. Empty string indicates # Abort early if we don't have any work to do
# the client did not explicitly set the header
if not request.content_type in ('application/json', ''):
return
params_json = request.body params_json = request.body
if not params_json: if not params_json:
return return
# Reject unrecognized content types. Empty string indicates
# the client did not explicitly set the header
if not request.content_type in ('application/json', ''):
e = exception.ValidationError(attribute='application/json',
target='Content-Type header')
return wsgi.render_exception(e)
params_parsed = {} params_parsed = {}
try: try:
params_parsed = json.loads(params_json) params_parsed = json.loads(params_json)
except ValueError: except ValueError:
msg = 'Malformed json in request body' e = exception.ValidationError(attribute='valid JSON',
raise webob.exc.HTTPBadRequest(explanation=msg) target='request body')
return wsgi.render_exception(e)
finally: finally:
if not params_parsed: if not params_parsed:
params_parsed = {} params_parsed = {}

11
tests/test_middleware.py
View File

@ -90,9 +90,8 @@ class JsonBodyMiddlewareTest(test.TestCase):
req = make_request(body='{"arg1": "on', req = make_request(body='{"arg1": "on',
content_type='application/json', content_type='application/json',
method='POST') method='POST')
_middleware = middleware.JsonBodyMiddleware(None) resp = middleware.JsonBodyMiddleware(None).process_request(req)
self.assertRaises(webob.exc.HTTPBadRequest, self.assertEqual(resp.status_int, 400)
_middleware.process_request, req)
def test_no_content_type(self): def test_no_content_type(self):
req = make_request(body='{"arg1": "one", "arg2": ["a"]}', req = make_request(body='{"arg1": "one", "arg2": ["a"]}',
@ -105,6 +104,12 @@ class JsonBodyMiddlewareTest(test.TestCase):
req = make_request(body='{"arg1": "one", "arg2": ["a"]}', req = make_request(body='{"arg1": "one", "arg2": ["a"]}',
content_type='text/plain', content_type='text/plain',
method='POST') method='POST')
resp = middleware.JsonBodyMiddleware(None).process_request(req)
self.assertEqual(resp.status_int, 400)
def test_unrecognized_content_type_without_body(self):
req = make_request(content_type='text/plain',
method='GET')
middleware.JsonBodyMiddleware(None).process_request(req) middleware.JsonBodyMiddleware(None).process_request(req)
params = req.environ.get(middleware.PARAMS_ENV, {}) params = req.environ.get(middleware.PARAMS_ENV, {})
self.assertEqual(params, {}) self.assertEqual(params, {})