openstack
/
keystone
Code Issues Proposed changes

Fix misnamed variable in config 

The `caching` configuration option for the catalog section was
instead storing the configuration in a `aching` variable. I'm
assuming that this was suppose to be `caching` given the convention
of all the other sub-systems within keystone and how they implement
caching. This could have had performance impacts if operators thought
they were enabling caching behavior but actually weren't seeing any
performance increase because the implemention looks for `caching` as
the registered configuration option instead of `aching`. This seems
to have been introduced in:

  d9c6b50a3a

Performance impact here could be significant if the catalog is of
substantial size since it would be rebuilt every time a token is
validated.

Change-Id: I04e71ba12a86106bc2e50daa139666bd89a6854c
This commit is contained in:
Lance Bragstad 2017-05-07 22:14:13 -05:00 committed by Steve Martinelli
parent bc4d22d0c2
commit 5cceff5c69
1 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
keystone/conf/catalog.py
View File

@ -34,7 +34,7 @@ file on disk), and a `endpoint_filter.sql` option (which supports arbitrary
service catalogs per project).
"""))
aching = cfg.BoolOpt(
caching = cfg.BoolOpt(
'caching',
default=True,
help=utils.fmt("""
@ -64,7 +64,7 @@ GROUP_NAME = __name__.split('.')[-1]
ALL_OPTS = [
template_file,
driver,
aching,
caching,
cache_time,
list_limit,
]