Move irrelevant-files to project definition

This change moves any jobs' declaration of irrelevant-files to the
listing under the project definition. This is done for consistency
with other projects we inherit from infra.

This change also uses yaml anchors to remove the many duplications
of irrelevant-files that were defined.

Change-Id: I2bbd6527091eda81046a5c514112d7678e8401a6

.zuul.yaml

@@ -18,13 +18,6 @@
       - openstack-infra/devstack-gate
       - openstack/keystone
       - openstack/keystone-tempest-plugin
-    irrelevant-files:
-      - ^.*\.rst$
-      - ^api-ref/.*$
-      - ^doc/.*$
-      - ^etc/.*$
-      - ^keystone/tests/unit/.*$
-      - ^releasenotes/.*$
     vars:
       tox_envlist: all
       tempest_test_regex: 'keystone_tempest_plugin'
@@ -42,7 +35,6 @@
 - job:
     name: keystone-dsvm-functional-federation
     parent: keystone-dsvm-functional
-    voting: false
     vars:
       devstack_localrc:
         TEMPEST_PLUGINS: '/opt/stack/keystone-tempest-plugin'
@@ -55,7 +47,6 @@
 - job:
     name: keystone-dsvm-py35-functional-federation
     parent: keystone-dsvm-functional-federation
-    voting: false
     vars:
       devstack_localrc:
         TEMPEST_PLUGINS: '/opt/stack/keystone-tempest-plugin'
@@ -66,16 +57,8 @@
 - job:
     name: openstack-ansible-keystone-rolling-upgrade
     parent: openstack-ansible-cross-repo-functional
-    voting: false
     required-projects:
       - name: openstack/openstack-ansible-os_keystone
-    irrelevant-files:
-      - ^.*\.rst$
-      - ^api-ref/.*$
-      - ^doc/.*$
-      - ^etc/.*$
-      - ^keystone/tests/unit/.*$
-      - ^releasenotes/.*$
     vars:
       tox_env: upgrade
       osa_test_repo: openstack/openstack-ansible-os_keystone
@@ -88,13 +71,6 @@
       Run test for keystone project.
 
       Uses tox with the ``patch_cover`` environment.
-    irrelevant-files:
-      - ^.*\.rst$
-      - ^api-ref/.*$
-      - ^doc/.*$
-      - ^etc/.*$
-      - ^keystone/tests/unit/.*$
-      - ^releasenotes/.*$
     vars:
       tox_envlist: patch_cover
 
@@ -105,13 +81,6 @@
     run: playbooks/legacy/keystone-dsvm-grenade-multinode/run.yaml
     post-run: playbooks/legacy/keystone-dsvm-grenade-multinode/post.yaml
     timeout: 10800
-    irrelevant-files:
-      - ^.*\.rst$
-      - ^api-ref/.*$
-      - ^doc/.*$
-      - ^etc/.*$
-      - ^keystone/tests/unit/.*$
-      - ^releasenotes/.*$
     required-projects:
       - openstack-dev/grenade
       - openstack-infra/devstack-gate
@@ -133,22 +102,28 @@
       - release-notes-jobs-python3
     check:
       jobs:
-        - keystone-dsvm-functional
-        - keystone-dsvm-py3-functional
-        - keystone-dsvm-functional-federation
-        - keystone-dsvm-py35-functional-federation
+        - keystone-dsvm-functional:
+            irrelevant-files: &irrelevant-files
+              - ^.*\.rst$
+              - ^api-ref/.*$
+              - ^doc/.*$
+              - ^etc/.*$
+              - ^keystone/tests/unit/.*$
+              - ^releasenotes/.*$
+        - keystone-dsvm-py3-functional:
+            irrelevant-files: *irrelevant-files
+        - keystone-dsvm-functional-federation:
+            voting: false
+            irrelevant-files: *irrelevant-files
+        - keystone-dsvm-py35-functional-federation:
+            voting: false
+            irrelevant-files: *irrelevant-files
         - keystoneclient-devstack-functional:
             voting: false
-            irrelevant-files:
-              - ^.*\.rst$
-              - ^api-ref/.*$
-              - ^doc/.*$
-              - ^etc/.*$
-              - ^keystone/tests/unit/.*$
-              - ^releasenotes/.*$
+            irrelevant-files: *irrelevant-files
         - legacy-tempest-dsvm-ldap-domain-specific-driver:
             voting: false
-            irrelevant-files:
+            irrelevant-files: &tempest-irrelevant-files
               - ^(test-|)requirements.txt$
               - ^.*\.rst$
               - ^api-ref/.*$
@@ -158,94 +133,34 @@
               - ^releasenotes/.*$
               - ^setup.cfg$
         - tempest-full:
-            irrelevant-files:
-              - ^(test-|)requirements.txt$
-              - ^.*\.rst$
-              - ^api-ref/.*$
-              - ^doc/.*$
-              - ^etc/.*$
-              - ^keystone/tests/unit/.*$
-              - ^releasenotes/.*$
-              - ^setup.cfg$
+            irrelevant-files: *tempest-irrelevant-files
         - tempest-full-py3:
-            irrelevant-files:
-              - ^(test-|)requirements.txt$
-              - ^.*\.rst$
-              - ^api-ref/.*$
-              - ^doc/.*$
-              - ^etc/.*$
-              - ^keystone/tests/unit/.*$
-              - ^releasenotes/.*$
-              - ^setup.cfg$
+            irrelevant-files: *tempest-irrelevant-files
         - neutron-grenade:
-            irrelevant-files:
-              - ^(test-|)requirements.txt$
-              - ^.*\.rst$
-              - ^api-ref/.*$
-              - ^doc/.*$
-              - ^etc/.*$
-              - ^keystone/tests/unit/.*$
-              - ^releasenotes/.*$
-              - ^setup.cfg$
+            irrelevant-files: *tempest-irrelevant-files
     gate:
       jobs:
-        - keystone-dsvm-functional
-        - keystone-dsvm-py3-functional
+        - keystone-dsvm-functional:
+            irrelevant-files: *irrelevant-files
+        - keystone-dsvm-py3-functional:
+            irrelevant-files: *irrelevant-files
         - tempest-full:
-            irrelevant-files:
-              - ^(test-|)requirements.txt$
-              - ^.*\.rst$
-              - ^api-ref/.*$
-              - ^doc/.*$
-              - ^etc/.*$
-              - ^keystone/tests/unit/.*$
-              - ^releasenotes/.*$
-              - ^setup.cfg$
+            irrelevant-files: *tempest-irrelevant-files
         - tempest-full-py3:
-            irrelevant-files:
-              - ^(test-|)requirements.txt$
-              - ^.*\.rst$
-              - ^api-ref/.*$
-              - ^doc/.*$
-              - ^etc/.*$
-              - ^keystone/tests/unit/.*$
-              - ^releasenotes/.*$
-              - ^setup.cfg$
+            irrelevant-files: *tempest-irrelevant-files
         - neutron-grenade:
-            irrelevant-files:
-              - ^(test-|)requirements.txt$
-              - ^.*\.rst$
-              - ^api-ref/.*$
-              - ^doc/.*$
-              - ^etc/.*$
-              - ^keystone/tests/unit/.*$
-              - ^releasenotes/.*$
-              - ^setup.cfg$
+            irrelevant-files: *tempest-irrelevant-files
     experimental:
       jobs:
         - keystone-tox-patch_cover
-        - keystone-dsvm-grenade-multinode
-        - openstack-ansible-keystone-rolling-upgrade
+        - keystone-dsvm-grenade-multinode:
+            irrelevant-files: *irrelevant-files
+        - openstack-ansible-keystone-rolling-upgrade:
+            irrelevant-files: *irrelevant-files
         - tempest-pg-full:
-            irrelevant-files:
-              - ^(test-|)requirements.txt$
-              - ^.*\.rst$
-              - ^api-ref/.*$
-              - ^doc/.*$
-              - ^etc/.*$
-              - ^keystone/tests/unit/.*$
-              - ^releasenotes/.*$
-              - ^setup.cfg$
+            irrelevant-files: *tempest-irrelevant-files
         - tempest-full-py3-opensuse150:
-            irrelevant-files:
-              - ^(test-|)requirements.txt$
-              - ^.*\.rst$
-              - ^api-ref/.*$
-              - ^doc/.*$
-              - ^etc/.*$
-              - ^keystone/tests/unit/.*$
-              - ^releasenotes/.*$
-              - ^setup.cfg$
+            irrelevant-files: *tempest-irrelevant-files
     post:
       jobs:
         - publish-loci-keystone