From 6525203c1af9ecdf7c23af3f25e45f0db9f6fed2 Mon Sep 17 00:00:00 2001 From: Gage Hugo Date: Tue, 24 Sep 2019 11:34:37 -0500 Subject: [PATCH] Change time faking for totp test This change moves the time mocking from using freezegun to using oslo.utils TimeFixture for the unit test test_with_passcode_in_previous_windows_extended, which was occasionally failing with 401 errors due to the totp creation time not properly be faked with 4 extended windows. Closes-Bug: #1843464 Change-Id: I3aefd99907fbc2d03538c9814f7279b282715679 --- keystone/tests/unit/test_v3_auth.py | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/keystone/tests/unit/test_v3_auth.py b/keystone/tests/unit/test_v3_auth.py index e9debce63b..585f57766c 100644 --- a/keystone/tests/unit/test_v3_auth.py +++ b/keystone/tests/unit/test_v3_auth.py @@ -5304,9 +5304,9 @@ class TestAuthTOTP(test_v3.RestfulTestCase): secret = creds[-1]['blob'] past = datetime.datetime.utcnow() - datetime.timedelta(minutes=2) - with freezegun.freeze_time(past): - auth_data = self._make_auth_data_by_id( - totp._generate_totp_passcodes(secret)[0]) + self.useFixture(fixture.TimeFixture(past)) + auth_data = self._make_auth_data_by_id( + totp._generate_totp_passcodes(secret)[0]) # Stop the clock otherwise there is a chance of auth failure due to # getting a different TOTP between the call here and the call in the