openstack
/
keystone
Code Issues Proposed changes

Don't skip tests for some bugs 

Skipping tests for a bug is a bad idea since if the bug is fixed
it's a manual process to find the affected test rather than being
found automatically by the tests.

Change-Id: I8109459bc825c5dc042e386432cb3496871f9862
This commit is contained in:
Brant Knudson 2014-02-09 09:19:07 -06:00
parent 8557e4756e
commit 68a9bab1bb
3 changed files with 10 additions and 13 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
keystone/tests/test_content_types.py
View File

@ -253,15 +253,14 @@ class CoreApiTests(object):
self.assertValidTenantResponse(r)
def test_get_user_roles(self):
self.skipTest('Blocked by bug 933565')
# The server responds with a 501 Not Implemented. See bug 933565.
token = self.get_scoped_token()
r = self.admin_request(
self.admin_request(
path='/v2.0/users/%(user_id)s/roles' % {
'user_id': self.user_foo['id'],
},
token=token)
self.assertValidRoleListResponse(r)
token=token, expected_status=501)
def test_get_user_roles_with_tenant(self):
token = self.get_scoped_token()

12
keystone/tests/test_keystoneclient.py
View File

@ -657,14 +657,12 @@ class KeystoneClientTests(object):
client.users.update,
user=uuid.uuid4().hex)
def test_user_update_tenant_404(self):
self.skipTest('N/A')
from keystoneclient import exceptions as client_exceptions
def test_user_update_tenant(self):
client = self.get_client(admin=True)
self.assertRaises(client_exceptions.NotFound,
client.users.update,
user=self.user_foo['id'],
tenant_id=uuid.uuid4().hex)
tenant_id = uuid.uuid4().hex
user = client.users.update(user=self.user_foo['id'],
tenant_id=tenant_id)
self.assertEqual(tenant_id, user.tenant_id)
def test_user_update_password_404(self):
from keystoneclient import exceptions as client_exceptions

4
keystone/tests/test_v3_auth.py
View File

@ -2025,8 +2025,8 @@ class TestTrustAuth(TestAuthInfo):
self.identity_api.create_user(self.trustee_user_id, self.trustee_user)
def test_create_trust_400(self):
self.skipTest('Blocked by bug 1133435')
self.post('/OS-TRUST/trusts', body={'trust': {}}, expected_status=400)
# The server returns a 403 Forbidden rather than a 400, see bug 1133435
self.post('/OS-TRUST/trusts', body={'trust': {}}, expected_status=403)
def test_create_unscoped_trust(self):
ref = self.new_trust_ref(