openstack
/
keystone
Code Issues Proposed changes

clean up invalid variable reference 

keystone.auth.controllers.AuthInfo's get_method_data() referenced
a variable that was not defined.

Change-Id: I4171453d5e9843501052c9e395273976255342ad
This commit is contained in:
Brant Knudson 2013-04-08 19:53:15 -05:00
parent 89d3500441
commit 6f4096bc88
2 changed files with 13 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
keystone/auth/controllers.py
View File

@ -237,7 +237,7 @@ class AuthInfo(object):
"""
if method not in self.auth['identity']['methods']:
raise exception.ValidationError(attribute=method_name,
raise exception.ValidationError(attribute=method,
target='identity')
return self.auth['identity'][method]

12
tests/test_v3_auth.py
View File

@ -83,6 +83,18 @@ class TestAuthInfo(test_v3.RestfulTestCase):
None,
auth_data)
def test_get_method_data_invalid_method(self):
auth_data = self.build_authentication_request(
user_id='test',
password='test')['auth']
context = None
auth_info = auth.controllers.AuthInfo(context, auth_data)
method_name = uuid.uuid4().hex
self.assertRaises(exception.ValidationError,
auth_info.get_method_data,
method_name)
class TestTokenAPIs(test_v3.RestfulTestCase):
def setUp(self):