openstack/keystone
Code Issues Proposed changes

Merge "Fix v2 role create schema validation"

Browse Source
This commit is contained in:
Jenkins 2017-02-25 03:30:50 +00:00 committed by Gerrit Code Review
commit 724c9b7cd9
2 changed files with 9 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
keystone/assignment/schema.py
View File

@ -17,7 +17,7 @@ from keystone.common.validation import parameter_types
_role_properties_v2 = {
'name': parameter_types.name,
'id': parameter_types.id_string,
'description': parameter_types.id_string
'description': parameter_types.description
}
role_create_v2 = {

9
keystone/tests/unit/test_v2_validation.py
View File

@ -34,7 +34,7 @@ class RoleValidationTestCase(unit.BaseTestCase):
def setUp(self):
super(RoleValidationTestCase, self).setUp()
schema_role_create = assignment_schema.role_create
schema_role_create = assignment_schema.role_create_v2
self.create_validator = validators.SchemaValidator(schema_role_create)
def test_validate_role_create_succeeds(self):
@ -43,6 +43,13 @@ class RoleValidationTestCase(unit.BaseTestCase):
}
self.create_validator.validate(request)
def test_validate_role_create_succeeds_with_spaces_in_description(self):
request = {
'name': uuid.uuid4().hex,
'description': 'Description with spaces'
}
self.create_validator.validate(request)
def test_validate_role_create_succeeds_with_extra_params(self):
request = {
'name': uuid.uuid4().hex,