openstack/keystone
Code Issues Proposed changes

Avoid name repetition in equality comparisons

Browse Source 
Multiple equality comparisons on the same variable are combined with
OR. Instead you could use `in` (f.e.: `a in [1, 2, 3]`)

Change-Id: Icd7e009219e916458a3918064dc7d45991511f62
This commit is contained in:
Raildo Mascena 2016-02-17 11:06:34 -03:00 committed by Raildo Mascena
parent f738b28167
commit 771eeb36cb
1 changed files with 1 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
keystone/oauth1/backends/sql.py
View File

@ -194,8 +194,7 @@ class OAuth1(core.Oauth1DriverV8):
new_token = RequestToken.from_dict(token_dict) new_token = RequestToken.from_dict(token_dict)
for attr in RequestToken.attributes: for attr in RequestToken.attributes:
if (attr == 'authorizing_user_id' or attr == 'verifier' if attr in ['authorizing_user_id', 'verifier', 'role_ids']:
or attr == 'role_ids'):
setattr(token_ref, attr, getattr(new_token, attr)) setattr(token_ref, attr, getattr(new_token, attr))
return token_ref.to_dict() return token_ref.to_dict()