openstack
/
keystone
Code Issues Proposed changes

cache_on_issue default to true 

If caching is globally enabled and enabled for tokens then we should
default to have cache_on_issue default to True as well. This commit also
adds one clarifying sentence to the config file comments since this
value has no effect unless caching is globally enabled and enabled in
the [token] section.

Closes-Bug: #1641816

Change-Id: I2797964ef0bb5641d8c1a208e1b5dcf567c1437f
This commit is contained in:
Matt Fischer 2016-10-06 12:43:38 -06:00
parent 309b1adbfe
commit 7765130bd6
2 changed files with 9 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
keystone/conf/token.py
View File

@ -134,10 +134,11 @@ other role assignments.
cache_on_issue = cfg.BoolOpt(
'cache_on_issue',
default=False,
default=True,
help=utils.fmt("""
Enable storing issued token data to token validation cache so that first token
validation doesn't actually cause full validation cycle.
validation doesn't actually cause full validation cycle. This option has no
effect unless global caching and token caching are enabled.
"""))
allow_expired_window = cfg.IntOpt(

6
releasenotes/notes/cache_on_issue_default_on-8b39f3f73359c778.yaml Normal file
View File

@ -0,0 +1,6 @@
---
features:
- The ``[token] cache_on_issue`` option is now enabled
by default. This option has no effect unless global
caching and token caching are enabled. This matches
the other cache settings (such as token, catalog etc)