openstack
/
keystone
Code Issues Proposed changes

Tidy up for late-breaking review comments on keystone-manage 

Fix up the main requested changes from
https://review.openstack.org/#/c/349716/14

A separate patch will add testing to ensure the mutually exclusive
nature of the new db_sync commands.

Change-Id: I18391a8d01bcd8a4f9ecfea223f776cd60f51077
This commit is contained in:
Henry Nash 2016-08-17 00:08:08 +01:00
parent 0b4f6ebdcc
commit 850eace343
2 changed files with 2 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
keystone/cmd/cli.py
View File

@ -410,8 +410,7 @@ class DbSync(BaseApp):
group = parser.add_mutually_exclusive_group()
group.add_argument('--expand', default=False, action='store_true',
help=('Expand the database schema in preparation '
'for data migration and starting the first '
'keystone node upgraded to the new release.'))
'for data migration.'))
group.add_argument('--migrate', default=False,
action='store_true',
help=('Copy all data that needs to be migrated '

4
keystone/common/sql/migration_helpers.py
View File

@ -218,9 +218,7 @@ def contract_schema():
This is run manually by the keystone-manage command once the keystone
nodes have been upgraded to the latest release and will remove any old
tables/columns that are no longer required. In addition, if any data
could have been left inconsistent while running with a mix of releases,
then this should be fixed up here.
tables/columns that are no longer required.
"""
# TODO(henry-nash): Add implementation here.