From a0104c7cc237101a50732c8974840c408319b6ec Mon Sep 17 00:00:00 2001 From: Boris Bobrov Date: Thu, 24 Nov 2016 12:46:21 +0300 Subject: [PATCH] Add a comment about not using assertTrue Change-Id: I21be4f96a1a12ace1d579d50a2cd91e0fa899fb6 --- keystone/tests/unit/identity/test_core.py | 3 +++ 1 file changed, 3 insertions(+) diff --git a/keystone/tests/unit/identity/test_core.py b/keystone/tests/unit/identity/test_core.py index 47dfcee20c..261c1366ac 100644 --- a/keystone/tests/unit/identity/test_core.py +++ b/keystone/tests/unit/identity/test_core.py @@ -198,6 +198,9 @@ class TestShadowUsers(unit.TestCase): self.assertIsNotNone(user['name']) self.assertIsNone(user['password_expires_at']) self.assertIsNone(user['domain_id']) + # NOTE(breton): below, attribute `enabled` is explicitly tested to be + # equal True. assertTrue should not be used, because it converts + # the passed value to bool(). self.assertEqual(True, user['enabled']) def test_shadow_existing_federated_user(self):