From 121ee8ce73dfb6b924eab8f8345ef32921bd7ced Mon Sep 17 00:00:00 2001 From: Vishakha Agarwal Date: Mon, 23 Mar 2020 22:05:42 +0530 Subject: [PATCH] Stop configuring install_command in tox. Currently, we are overriding 'install_command' to use 'pip'. This is considered poor behavior and 'python -m pip' should be used instead: https://snarky.ca/why-you-should-use-python-m-pip/ It turns out that this is the the default value provided by tox: https://tox.readthedocs.io/en/latest/config.html#conf-install_command So we can remove the line and simply use the default value. Change-Id: I2bf8b8509788fdc2f23c9ddf4211b19de7b3fb87 --- tox.ini | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/tox.ini b/tox.ini index a4967fe1eb..2eb9d65a6d 100644 --- a/tox.ini +++ b/tox.ini @@ -1,11 +1,10 @@ [tox] -minversion = 2.5.0 +minversion = 3.2.0 skipsdist = True envlist = py37,pep8,api-ref,docs,genconfig,genpolicy,releasenotes,protection [testenv] usedevelop = True -install_command = pip install {opts} {packages} basepython = python3 setenv = VIRTUAL_ENV={envdir} deps = -c{env:UPPER_CONSTRAINTS_FILE:https://releases.openstack.org/constraints/upper/master}