openstack
/
keystone
Code Issues Proposed changes

Make __all__ immutable 

The point of __all__ is to make static analysis more reliable. Using a
mutable type allows that goal to be circumvented at runtime. Tuples are
immutable.

Change-Id: I88d7459b33471efca8f2599e379665010403341c
This commit is contained in:
Dolph Mathews 2015-09-30 21:54:50 +00:00
parent 6073ccb512
commit d2d4ba57f4
3 changed files with 4 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
keystone/common/environment/__init__.py
View File

@ -21,7 +21,7 @@ from oslo_log import log
LOG = log.getLogger(__name__)
__all__ = ['Server', 'httplib', 'subprocess']
__all__ = ('Server', 'httplib', 'subprocess')
_configured = False

4
keystone/common/kvs/core.py
View File

@ -32,8 +32,8 @@ from keystone.i18n import _LI
from keystone.i18n import _LW
__all__ = ['KeyValueStore', 'KeyValueStoreLock', 'LockTimeout',
'get_key_value_store']
__all__ = ('KeyValueStore', 'KeyValueStoreLock', 'LockTimeout',
'get_key_value_store')
BACKENDS_REGISTERED = False

2
keystone/token/persistence/__init__.py
View File

@ -13,4 +13,4 @@
from keystone.token.persistence.core import * # noqa
__all__ = ['Manager', 'Driver']
__all__ = ('Manager', 'Driver')