openstack/keystone
Code Issues Proposed changes

Remove create_container_group from tests

Browse Source 
The function had no effect on the execution of the tests. If it's not
doing anything there really isn't much of a reason to keep it.

Change-Id: Ie283a5a7ab9d6412f94db46724f8f6c0b3e1f5f4
This commit is contained in:
David Stanek 2017-03-28 21:18:01 +00:00 committed by Kristi Nikolla
parent c6b6429675
commit de38b50fcc
1 changed files with 0 additions and 20 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

20
keystone/tests/unit/test_backend_ldap.py
View File

@ -111,15 +111,6 @@ def _assert_backends(testcase, **kwargs):
% entrypoint_name)
def create_group_container(identity_api):
# Create the groups base entry (ou=Groups,cn=example,cn=com)
group_api = identity_api.driver.group
conn = group_api.get_connection()
dn = 'ou=Groups,cn=example,cn=com'
conn.add_s(dn, [('objectclass', ['organizationalUnit']),
('ou', ['Groups'])])
class IdentityTests(identity_tests.IdentityTests):
def test_delete_user_with_group_project_domain_links(self):
@ -1052,11 +1043,6 @@ class LDAPIdentity(BaseLDAPIdentity, unit.TestCase):
identity='ldap',
resource='sql')
def load_fixtures(self, fixtures):
# Override super impl since need to create group container.
create_group_container(self.identity_api)
super(LDAPIdentity, self).load_fixtures(fixtures)
def test_list_domains(self):
domains = self.resource_api.list_domains()
default_domain = unit.new_domain_ref(
@ -1797,7 +1783,6 @@ class LDAPIdentityEnabledEmulation(LDAPIdentity):
def load_fixtures(self, fixtures):
# Override super impl since need to create group container.
create_group_container(self.identity_api)
super(LDAPIdentity, self).load_fixtures(fixtures)
for obj in [self.tenant_bar, self.tenant_baz, self.user_foo,
self.user_two, self.user_badguy]:
@ -2049,11 +2034,6 @@ class LDAPPosixGroupsTest(LDAPTestSetup, unit.TestCase):
def assert_backends(self):
_assert_backends(self, identity='ldap')
def load_fixtures(self, fixtures):
# Override super impl since need to create group container.
create_group_container(self.identity_api)
super(LDAPPosixGroupsTest, self).load_fixtures(fixtures)
def config_overrides(self):
super(LDAPPosixGroupsTest, self).config_overrides()
self.config_fixture.config(group='identity', driver='ldap')