From 1c013444f91dd88451d5050fafbd1b9fc13ff4a4 Mon Sep 17 00:00:00 2001 From: Adam Young Date: Tue, 11 Dec 2018 21:22:51 -0500 Subject: [PATCH] Remove message about circular role inferences While Cycles could be a problem, this code was detercting them even when there were none. If a role gets added twice, it was reporting an error, but that is possible from the case where two distinct prior add the same implied role. Just move on quietly. closes-bug 1803780 Change-Id: I804e5084f74ff4afdd582ece02ff2c833c5f6eb1 (cherry picked from commit 78566e828659b201563e7d07823df30f7b00b0d4) --- keystone/assignment/core.py | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/keystone/assignment/core.py b/keystone/assignment/core.py index 5aaa956e31..0b4d515b19 100644 --- a/keystone/assignment/core.py +++ b/keystone/assignment/core.py @@ -682,9 +682,8 @@ class Manager(manager.Manager): _make_implied_ref_copy( next_ref, implied_role['implied_role_id'])) if implied_ref in checked_role_refs: - msg = ('Circular reference found ' - 'role inference rules - %(prior_role_id)s.') - LOG.error(msg, {'prior_role_id': next_ref['role_id']}) + # Avoid traversing a cycle + continue else: ref_results.append(implied_ref) role_refs_to_check.append(implied_ref)