openstack/keystone
Code Issues Proposed changes

Change the min value of pool_retry_max to 1

Browse Source 
Value of 0 causes the pool to fail before it attempts to connect
to ldap, raising MaxConnectionReachedError.

Change-Id: Ia8450dc45dad5ceb4661807f51de66b5d70a6207
This commit is contained in:
Grzegorz Grasza 2022-01-11 11:38:21 +01:00
parent 771c943ad2
commit f639c40534
2 changed files with 10 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
keystone/conf/ldap.py
View File

@ -411,11 +411,11 @@ use_pool` is also enabled.
pool_retry_max = cfg.IntOpt( pool_retry_max = cfg.IntOpt(
'pool_retry_max', 'pool_retry_max',
default=3, default=3,
min=0, min=1,
help=utils.fmt(""" help=utils.fmt("""
The maximum number of times to attempt reconnecting to the LDAP server before The maximum number of times to attempt connecting to the LDAP server before
aborting. A value of zero prevents retries. This option has no effect unless aborting. A value of one makes only one connection attempt.
`[ldap] use_pool` is also enabled. This option has no effect unless `[ldap] use_pool` is also enabled.
""")) """))
pool_retry_delay = cfg.FloatOpt( pool_retry_delay = cfg.FloatOpt(

6
releasenotes/notes/change_min_pool_retry_max-f5e7c8d315401426.yaml Normal file
View File

@ -0,0 +1,6 @@
---
fixes:
- |
Change the min value of pool_retry_max to 1. Setting this value to 0
caused the pool to fail before connecting to ldap, always raising
MaxConnectionReachedError.