0f3f08c3df
Force the keystone.auth.controllers.Auth.authenticate method to require the use of an AuthContext object instead of something duck-typed (dictionary). This is done to ensure the security and integrity of IDENTITY_KEYS are covered and values are not changed by a plugin due to the security built into AuthContext being circumvented since it was not used. This is not pythonic, this is being done for hardening purposes. Change-Id: I013846af59587d17b15ca4cf546e6372231f576e Closes-Bug: #1656076
189 lines
7.7 KiB
Python
189 lines
7.7 KiB
Python
# Copyright 2013 OpenStack Foundation
|
|
#
|
|
# Licensed under the Apache License, Version 2.0 (the "License"); you may
|
|
# not use this file except in compliance with the License. You may obtain
|
|
# a copy of the License at
|
|
#
|
|
# http://www.apache.org/licenses/LICENSE-2.0
|
|
#
|
|
# Unless required by applicable law or agreed to in writing, software
|
|
# distributed under the License is distributed on an "AS IS" BASIS, WITHOUT
|
|
# WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the
|
|
# License for the specific language governing permissions and limitations
|
|
# under the License.
|
|
|
|
import uuid
|
|
|
|
import mock
|
|
|
|
from keystone import auth
|
|
from keystone.auth.plugins import base
|
|
from keystone import exception
|
|
from keystone.tests import unit
|
|
from keystone.tests.unit.ksfixtures import auth_plugins
|
|
|
|
|
|
# for testing purposes only
|
|
METHOD_NAME = 'simple_challenge_response'
|
|
METHOD_OPTS = {
|
|
METHOD_NAME:
|
|
'keystone.tests.unit.test_auth_plugin.SimpleChallengeResponse',
|
|
}
|
|
EXPECTED_RESPONSE = uuid.uuid4().hex
|
|
DEMO_USER_ID = uuid.uuid4().hex
|
|
|
|
|
|
class SimpleChallengeResponse(base.AuthMethodHandler):
|
|
def authenticate(self, context, auth_payload, user_context):
|
|
if 'response' in auth_payload:
|
|
if auth_payload['response'] != EXPECTED_RESPONSE:
|
|
raise exception.Unauthorized('Wrong answer')
|
|
user_context['user_id'] = DEMO_USER_ID
|
|
else:
|
|
return {"challenge": "What's the name of your high school?"}
|
|
|
|
|
|
class TestAuthPlugin(unit.SQLDriverOverrides, unit.TestCase):
|
|
def setUp(self):
|
|
super(TestAuthPlugin, self).setUp()
|
|
self.api = auth.controllers.Auth()
|
|
|
|
def test_unsupported_auth_method(self):
|
|
method_name = uuid.uuid4().hex
|
|
auth_data = {'methods': [method_name]}
|
|
auth_data[method_name] = {'test': 'test'}
|
|
auth_data = {'identity': auth_data}
|
|
self.assertRaises(exception.AuthMethodNotSupported,
|
|
auth.controllers.AuthInfo.create,
|
|
auth_data)
|
|
|
|
def test_addition_auth_steps(self):
|
|
self.useFixture(
|
|
auth_plugins.ConfigAuthPlugins(self.config_fixture,
|
|
methods=[METHOD_NAME],
|
|
**METHOD_OPTS))
|
|
self.useFixture(auth_plugins.LoadAuthPlugins(METHOD_NAME))
|
|
|
|
auth_data = {'methods': [METHOD_NAME]}
|
|
auth_data[METHOD_NAME] = {
|
|
'test': 'test'}
|
|
auth_data = {'identity': auth_data}
|
|
auth_info = auth.controllers.AuthInfo.create(auth_data)
|
|
auth_context = auth.controllers.AuthContext(extras={}, method_names=[])
|
|
try:
|
|
self.api.authenticate(self.make_request(), auth_info, auth_context)
|
|
except exception.AdditionalAuthRequired as e:
|
|
self.assertIn('methods', e.authentication)
|
|
self.assertIn(METHOD_NAME, e.authentication['methods'])
|
|
self.assertIn(METHOD_NAME, e.authentication)
|
|
self.assertIn('challenge', e.authentication[METHOD_NAME])
|
|
|
|
# test correct response
|
|
auth_data = {'methods': [METHOD_NAME]}
|
|
auth_data[METHOD_NAME] = {
|
|
'response': EXPECTED_RESPONSE}
|
|
auth_data = {'identity': auth_data}
|
|
auth_info = auth.controllers.AuthInfo.create(auth_data)
|
|
auth_context = auth.controllers.AuthContext(extras={}, method_names=[])
|
|
self.api.authenticate(self.make_request(), auth_info, auth_context)
|
|
self.assertEqual(DEMO_USER_ID, auth_context['user_id'])
|
|
|
|
# test incorrect response
|
|
auth_data = {'methods': [METHOD_NAME]}
|
|
auth_data[METHOD_NAME] = {
|
|
'response': uuid.uuid4().hex}
|
|
auth_data = {'identity': auth_data}
|
|
auth_info = auth.controllers.AuthInfo.create(auth_data)
|
|
auth_context = auth.controllers.AuthContext(extras={}, method_names=[])
|
|
self.assertRaises(exception.Unauthorized,
|
|
self.api.authenticate,
|
|
self.make_request(),
|
|
auth_info,
|
|
auth_context)
|
|
|
|
def test_duplicate_method(self):
|
|
# Having the same method twice doesn't cause load_auth_methods to fail.
|
|
self.useFixture(
|
|
auth_plugins.ConfigAuthPlugins(self.config_fixture,
|
|
['external', 'external']))
|
|
auth.controllers.load_auth_methods()
|
|
self.assertIn('external', auth.controllers.AUTH_METHODS)
|
|
|
|
|
|
class TestAuthPluginDynamicOptions(TestAuthPlugin):
|
|
def config_overrides(self):
|
|
super(TestAuthPluginDynamicOptions, self).config_overrides()
|
|
# Clear the override for the [auth] ``methods`` option so it is
|
|
# possible to load the options from the config file.
|
|
self.config_fixture.conf.clear_override('methods', group='auth')
|
|
|
|
def config_files(self):
|
|
config_files = super(TestAuthPluginDynamicOptions, self).config_files()
|
|
config_files.append(unit.dirs.tests_conf('test_auth_plugin.conf'))
|
|
return config_files
|
|
|
|
|
|
class TestMapped(unit.TestCase):
|
|
def setUp(self):
|
|
super(TestMapped, self).setUp()
|
|
self.api = auth.controllers.Auth()
|
|
|
|
def config_files(self):
|
|
config_files = super(TestMapped, self).config_files()
|
|
config_files.append(unit.dirs.tests_conf('test_auth_plugin.conf'))
|
|
return config_files
|
|
|
|
def _test_mapped_invocation_with_method_name(self, method_name):
|
|
with mock.patch.object(auth.plugins.mapped.Mapped,
|
|
'authenticate',
|
|
return_value=None) as authenticate:
|
|
request = self.make_request()
|
|
auth_data = {
|
|
'identity': {
|
|
'methods': [method_name],
|
|
method_name: {'protocol': method_name},
|
|
}
|
|
}
|
|
auth_info = auth.controllers.AuthInfo.create(auth_data)
|
|
auth_context = auth.controllers.AuthContext(
|
|
extras={},
|
|
method_names=[],
|
|
user_id=uuid.uuid4().hex)
|
|
self.api.authenticate(request, auth_info, auth_context)
|
|
# make sure Mapped plugin got invoked with the correct payload
|
|
((context, auth_payload, auth_context),
|
|
kwargs) = authenticate.call_args
|
|
self.assertEqual(method_name, auth_payload['protocol'])
|
|
|
|
def test_mapped_with_remote_user(self):
|
|
method_name = 'saml2'
|
|
auth_data = {'methods': [method_name]}
|
|
# put the method name in the payload so its easier to correlate
|
|
# method name with payload
|
|
auth_data[method_name] = {'protocol': method_name}
|
|
auth_data = {'identity': auth_data}
|
|
|
|
auth_context = auth.controllers.AuthContext(
|
|
extras={},
|
|
method_names=[],
|
|
user_id=uuid.uuid4().hex)
|
|
|
|
self.useFixture(auth_plugins.LoadAuthPlugins(method_name))
|
|
|
|
with mock.patch.object(auth.plugins.mapped.Mapped,
|
|
'authenticate',
|
|
return_value=None) as authenticate:
|
|
auth_info = auth.controllers.AuthInfo.create(auth_data)
|
|
request = self.make_request(environ={'REMOTE_USER': 'foo@idp.com'})
|
|
self.api.authenticate(request, auth_info, auth_context)
|
|
# make sure Mapped plugin got invoked with the correct payload
|
|
((context, auth_payload, auth_context),
|
|
kwargs) = authenticate.call_args
|
|
self.assertEqual(method_name, auth_payload['protocol'])
|
|
|
|
def test_supporting_multiple_methods(self):
|
|
method_names = ('saml2', 'openid', 'x509', 'mapped')
|
|
self.useFixture(auth_plugins.LoadAuthPlugins(*method_names))
|
|
for method_name in method_names:
|
|
self._test_mapped_invocation_with_method_name(method_name)
|