Add tests for user-agent with odd sys.argv
There was no test that verified that when sys.argv is an empty list or when sys.argv[0] is an empty string that the default user-agent value is constructed as expected. Change-Id: Iacf1557b6dbf48bf6bfb59d7cfbfec14e4fa8e56 Related-Bug: 1611426
This commit is contained in:
parent
80ad3bc11f
commit
c9ae7067bd
|
@ -13,6 +13,7 @@
|
||||||
import itertools
|
import itertools
|
||||||
import json
|
import json
|
||||||
import logging
|
import logging
|
||||||
|
import sys
|
||||||
import uuid
|
import uuid
|
||||||
|
|
||||||
import mock
|
import mock
|
||||||
|
@ -133,6 +134,22 @@ class SessionTests(utils.TestCase):
|
||||||
self.assertTrue(resp.ok)
|
self.assertTrue(resp.ok)
|
||||||
self.assertRequestHeaderEqual('User-Agent', 'overrides-agent')
|
self.assertRequestHeaderEqual('User-Agent', 'overrides-agent')
|
||||||
|
|
||||||
|
# If sys.argv is an empty list, then doesn't fail.
|
||||||
|
with mock.patch.object(sys, 'argv', []):
|
||||||
|
session = client_session.Session()
|
||||||
|
resp = session.get(self.TEST_URL)
|
||||||
|
self.assertTrue(resp.ok)
|
||||||
|
self.assertRequestHeaderEqual(
|
||||||
|
'User-Agent',
|
||||||
|
client_session.DEFAULT_USER_AGENT)
|
||||||
|
|
||||||
|
# If sys.argv[0] is an empty string, then doesn't fail.
|
||||||
|
with mock.patch.object(sys, 'argv', ['']):
|
||||||
|
session = client_session.Session()
|
||||||
|
# NOTE(blk-u): This isn't working right, see bug 1611426
|
||||||
|
self.assertRaises(exceptions.UnknownConnectionError, session.get,
|
||||||
|
self.TEST_URL)
|
||||||
|
|
||||||
def test_http_session_opts(self):
|
def test_http_session_opts(self):
|
||||||
session = client_session.Session(cert='cert.pem', timeout=5,
|
session = client_session.Session(cert='cert.pem', timeout=5,
|
||||||
verify='certs')
|
verify='certs')
|
||||||
|
|
Loading…
Reference in New Issue