From 038b614d2efdd784f8b0ebc5433751c2765ab56c Mon Sep 17 00:00:00 2001 From: Thomas Bechtold Date: Fri, 8 Apr 2016 16:47:15 +0200 Subject: [PATCH] Fix doc build if git is absent When building packages if git is absent, then we should not set html_last_updated_fmt. It can still be set via the -D switch when building with sphinx-build. Change-Id: I3c55983a29150bb4f3742df5efa068f339ee1cd7 Closes-Bug: #1552251 --- doc/source/conf.py | 9 +++++++-- 1 file changed, 7 insertions(+), 2 deletions(-) diff --git a/doc/source/conf.py b/doc/source/conf.py index 26117aa0..9be29ee6 100644 --- a/doc/source/conf.py +++ b/doc/source/conf.py @@ -17,6 +17,7 @@ from __future__ import unicode_literals import os import subprocess import sys +import warnings import pbr.version @@ -150,8 +151,12 @@ modindex_common_prefix = ['keystoneauth1.'] # using the given strftime format. git_cmd = ["git", "log", "--pretty=format:'%ad, commit %h'", "--date=local", "-n1"] -html_last_updated_fmt = subprocess.Popen( - git_cmd, stdout=subprocess.PIPE).communicate()[0] +try: + html_last_updated_fmt = subprocess.Popen( + git_cmd, stdout=subprocess.PIPE).communicate()[0] +except: + warnings.warn('Cannot get last updated time from git repository. ' + 'Not setting "html_last_updated_fmt".') # If true, SmartyPants will be used to convert quotes and dashes to # typographically correct entities.