openstack/keystoneauth
Code Issues Proposed changes

Mark SAML loader properties as required

Browse Source 
All the username and password fields for saml2 plugins are required.
Without them the plugin won't work.

Change-Id: I868b2b2a9f44913cb117eca554539d9bd356d621
This commit is contained in:
Jamie Lennox 2017-11-29 14:40:27 +11:00
parent ba6650e9c7
commit f166819b13
1 changed files with 14 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

18
keystoneauth1/extras/_saml2/_loading.py
View File

@ -29,10 +29,14 @@ class Saml2Password(loading.BaseFederationLoader):
options.extend([
loading.Opt('identity-provider-url',
required=True,
help=('An Identity Provider URL, where the SAML2 '
'authentication request will be sent.')),
loading.Opt('username', help='Username'),
loading.Opt('password', secret=True, help='Password')
loading.Opt('username', help='Username', required=True),
loading.Opt('password',
secret=True,
help='Password',
required=True)
])
return options
@ -53,14 +57,20 @@ class ADFSPassword(loading.BaseFederationLoader):
options.extend([
loading.Opt('identity-provider-url',
required=True,
help=('An Identity Provider URL, where the SAML '
'authentication request will be sent.')),
loading.Opt('service-provider-endpoint',
required=True,
help="Service Provider's Endpoint"),
loading.Opt('service-provider-entity-id',
required=True,
help="Service Provider's SAML Entity ID"),
loading.Opt('username', help='Username'),
loading.Opt('password', secret=True, help='Password')
loading.Opt('username', help='Username', required=True),
loading.Opt('password',
secret=True,
required=True,
help='Password')
])
return options