From a31ed5ca4faace4afe30942a155e210a3334edd3 Mon Sep 17 00:00:00 2001 From: Brant Knudson Date: Sun, 11 Jan 2015 18:34:37 -0600 Subject: [PATCH] Correct failures for check H703 The H703 "Multiple positional placeholders" rule was failing and ignored. Now it's enforced. Change-Id: Id6d3bc1767e264d3f07c4e14758d67e10223f02f --- keystonemiddleware/auth_token.py | 4 ++-- tox.ini | 3 +-- 2 files changed, 3 insertions(+), 4 deletions(-) diff --git a/keystonemiddleware/auth_token.py b/keystonemiddleware/auth_token.py index 81e41a1c..d5427ebf 100644 --- a/keystonemiddleware/auth_token.py +++ b/keystonemiddleware/auth_token.py @@ -1220,8 +1220,8 @@ class AuthProtocol(object): current_mode = stat.S_IMODE(os.stat(self._signing_dirname).st_mode) if current_mode != stat.S_IRWXU: self._LOG.warning( - _LW('signing_dir mode is %s instead of %s'), - oct(current_mode), oct(stat.S_IRWXU)) + _LW('signing_dir mode is %(mode)s instead of %(need)s'), + {'mode': oct(current_mode), 'need': oct(stat.S_IRWXU)}) else: os.makedirs(self._signing_dirname, stat.S_IRWXU) diff --git a/tox.ini b/tox.ini index be6fd5d3..0d55116c 100644 --- a/tox.ini +++ b/tox.ini @@ -36,8 +36,7 @@ commands = oslo_debug_helper {posargs} # F821: undefined name # H304: no relative imports # H405: multi line docstring summary not separated with an empty line -# H703: Multiple positional placeholders -ignore = E122,F821,H304,H405,H703 +ignore = E122,F821,H304,H405 show-source = True exclude = .venv,.tox,dist,doc,*egg,build,*openstack/common*