Merge "Avoid launching "local" actions too many times"

ansible/roles/aodh/tasks/config.yml

@@ -63,6 +63,7 @@
 
 - name: Check if policies shall be overwritten
   local_action: stat path="{{ node_custom_config }}/aodh/policy.json"
+  run_once: True
   register: aodh_policy
 
 - name: Copying over existing policy.json

ansible/roles/barbican/tasks/config.yml

@@ -83,6 +83,7 @@
 
 - name: Check if policies shall be overwritten
   local_action: stat path="{{ node_custom_config }}/barbican/policy.json"
+  run_once: True
   register: barbican_policy
 
 - name: Copying over existing policy.json

ansible/roles/ceilometer/tasks/config.yml

@@ -109,6 +109,7 @@
 
 - name: Check if policies shall be overwritten
   local_action: stat path="{{ node_custom_config }}/ceilometer/policy.json"
+  run_once: True
   register: ceilometer_policy
 
 - name: Copying over existing policy.json

ansible/roles/ceph/tasks/start_rgw_keystone.yml

@@ -2,6 +2,7 @@
 - name: Check whether the swift service is enabled
   local_action: fail msg='Ceph-rgw-keystone is conflicted with swift, you should only enable one of them'
   when: enable_swift | bool
+  run_once: True
 
 - name: Creating the Swift service and endpoint
   kolla_toolbox:

ansible/roles/cinder/tasks/config.yml

@@ -69,6 +69,7 @@
 
 - name: Check if policies shall be overwritten
   local_action: stat path="{{ node_custom_config }}/cinder/policy.json"
+  run_once: True
   register: cinder_policy
 
 - name: Copying over existing policy.json

ansible/roles/cloudkitty/tasks/config.yml

@@ -46,6 +46,7 @@
 
 - name: Check if policies shall be overwritten
   local_action: stat path="{{ node_custom_config }}/cloudkitty/policy.json"
+  run_once: True
   register: cloudkitty_policy
 
 - name: Copying over existing policy.json

ansible/roles/congress/tasks/config.yml

@@ -42,6 +42,7 @@
 
 - name: Check if policies shall be overwritten
   local_action: stat path="{{ node_custom_config }}/congress/policy.json"
+  run_once: True
   register: congress_policy
 
 - name: Copying over existing policy.json

ansible/roles/designate/tasks/config.yml

@@ -118,6 +118,7 @@
 
 - name: Check if policies shall be overwritten
   local_action: stat path="{{ node_custom_config }}/designate/policy.json"
+  run_once: True
   register: designate_policy
 
 - name: Copying over existing policy.json

ansible/roles/freezer/tasks/config.yml

@@ -56,6 +56,7 @@
 
 - name: Check if policies shall be overwritten
   local_action: stat path="{{ node_config_directory }}/freezer/policy.json"
+  run_once: True
   register: freezer_policy
 
 - name: Copying over existing policy.json

ansible/roles/glance/tasks/config.yml

@@ -46,6 +46,7 @@
 
 - name: Check if policies shall be overwritten
   local_action: stat path="{{ node_custom_config }}/glance/policy.json"
+  run_once: True
   register: glance_policy
 
 - name: Copying over existing policy.json

ansible/roles/gnocchi/tasks/config.yml

@@ -63,6 +63,7 @@
 
 - name: Check if policies shall be overwritten
   local_action: stat path="{{ node_custom_config }}/gnocchi/policy.json"
+  run_once: True
   register: gnocchi_policy
 
 - name: Copying over existing policy.json

ansible/roles/heat/tasks/config.yml

@@ -55,6 +55,7 @@
 
 - name: Check if policies shall be overwritten
   local_action: stat path="{{ node_custom_config }}/heat/policy.json"
+  run_once: True
   register: heat_policy
 
 - name: Copying over existing policy.json

ansible/roles/horizon/tasks/config.yml

@@ -58,6 +58,7 @@
 
 - name: Check if policies shall be overwritten
   local_action: stat path="{{ node_custom_config }}/horizon/{{ item.name }}_policy.json"
+  run_once: True
   register: custom_policy
   when: item.enabled | bool
   with_items:

ansible/roles/ironic/tasks/config.yml

@@ -83,6 +83,7 @@
 
 - name: Check if policies shall be overwritten
   local_action: stat path="{{ node_custom_config }}/ironic/policy.json"
+  run_once: True
   register: ironic_policy
 
 - name: Copying over existing policy.json

ansible/roles/ironic/tasks/precheck.yml

@@ -30,6 +30,7 @@
 
 - name: Checking ironic-agent files exist for Ironic
   local_action: stat path="{{ node_custom_config }}/ironic/{{ item }}"
+  run_once: True
   register: result
   failed_when: not result.stat.exists
   when:

ansible/roles/keystone/tasks/config.yml

@@ -1,10 +1,12 @@
 ---
 - name: Check if policies shall be overwritten
   local_action: stat path="{{ node_custom_config }}/keystone/policy.json"
+  run_once: True
   register: keystone_policy
 
 - name: Check if Keystone Domain specific settings enabled
   local_action: stat path="{{ node_custom_config }}/keystone/domains"
+  run_once: True
   register: keystone_domain_directory
 
 - name: Ensuring config directories exist

ansible/roles/kuryr/tasks/config.yml

@@ -59,6 +59,7 @@
 
 - name: Check if policies shall be overwritten
   local_action: stat path="{{ node_custom_config }}/kuryr/policy.json"
+  run_once: True
   register: kuryr_policy
 
 - name: Copying over existing policy.json

ansible/roles/magnum/tasks/config.yml

@@ -46,6 +46,7 @@
 
 - name: Check if policies shall be overwritten
   local_action: stat path="{{ node_custom_config }}/magnum/policy.json"
+  run_once: True
   register: magnum_policy
 
 - name: Copying over existing policy.json

ansible/roles/manila/tasks/config.yml

@@ -73,6 +73,7 @@
 
 - name: Check if policies shall be overwritten
   local_action: stat path="{{ node_custom_config }}/manila/policy.json"
+  run_once: True
   register: manila_policy
 
 - name: Copying over existing policy.json

ansible/roles/mistral/tasks/config.yml

@@ -42,6 +42,7 @@
 
 - name: Check if policies shall be overwritten
   local_action: stat path="{{ node_custom_config }}/mistral/policy.json"
+  run_once: True
   register: mistral_policy
 
 - name: Copying over existing policy.json

ansible/roles/murano/tasks/config.yml

@@ -35,6 +35,7 @@
 
 - name: Check if policies shall be overwritten
   local_action: stat path="{{ node_custom_config }}/murano/policy.json"
+  run_once: True
   register: murano_policy
 
 - name: Copying over existing policy.json

ansible/roles/neutron/tasks/config.yml

@@ -265,6 +265,7 @@
 
 - name: Check if policies shall be overwritten
   local_action: stat path="{{ node_custom_config }}/neutron/policy.json"
+  run_once: True
   register: neutron_policy
 
 - name: Copying over nsx.ini

ansible/roles/neutron/tasks/precheck.yml

@@ -19,6 +19,7 @@
 - name: Checking number of network agents
   local_action: fail msg="Number of network agents are less than two when enabling agent ha"
   changed_when: false
+  run_once: True
   when:
     - enable_neutron_agent_ha | bool
     - groups['neutron-dhcp-agent'] | length < 2

ansible/roles/nova/tasks/config.yml

@@ -115,6 +115,7 @@
 
 - name: Check if policies shall be overwritten
   local_action: stat path="{{ node_custom_config }}/nova/policy.json"
+  run_once: True
   register: nova_policy
 
 - name: Copying over existing policy.json

ansible/roles/nova/tasks/external-ceph.yml

@@ -10,12 +10,14 @@
 
 - name: Check nova keyring file
   local_action: stat path="{{ node_custom_config }}/nova/ceph.client.nova.keyring"
+  run_once: True
   register: nova_cephx_keyring_file
   failed_when: not nova_cephx_keyring_file.stat.exists
   when: external_ceph_cephx_enabled | bool
 
 - name: Check cinder keyring file
   local_action: stat path="{{ node_custom_config }}/nova/ceph.client.cinder.keyring"
+  run_once: True
   register: cinder_cephx_keyring_file
   failed_when: not cinder_cephx_keyring_file.stat.exists
   when:
@@ -61,11 +63,13 @@
 
 - name: Extract nova key from file
   local_action: shell cat "{{ nova_cephx_keyring_file.stat.path }}" | grep -E 'key\s*=' | awk '{ print $3 }'
+  run_once: True
   register: nova_cephx_raw_key
   when: external_ceph_cephx_enabled | bool
 
 - name: Extract cinder key from file
   local_action: shell cat "{{ cinder_cephx_keyring_file.stat.path }}" | grep -E 'key\s*=' | awk '{ print $3 }'
+  run_once: True
   register: cinder_cephx_raw_key
   when:
     - cinder_backend_ceph | bool

ansible/roles/octavia/tasks/precheck.yml

@@ -30,6 +30,7 @@
 
 - name: Checking certificate files exist for octavia
   local_action: stat path="{{ node_custom_config }}/octavia/{{ item }}"
+  run_once: True
   register: result
   failed_when: not result.stat.exists
   when: inventory_hostname in groups['octavia-worker']

ansible/roles/panko/tasks/config.yml

@@ -59,6 +59,7 @@
 
 - name: Check if policies shall be overwritten
   local_action: stat path="{{ node_custom_config }}/panko/policy.json"
+  run_once: True
   register: panko_policy
 
 - name: Copying over existing policy.json

ansible/roles/prechecks/tasks/service_checks.yml

@@ -8,6 +8,7 @@
 
 - name: Checking empty passwords in passwords.yml. Run kolla-genpwd if this task fails
   local_action: command grep '^[^#].*:\s*$' "{{ CONFIG_DIR | default('/etc/kolla') }}/passwords.yml"
+  run_once: True
   register: result
   changed_when: false
   failed_when: result.stdout | regex_replace('(.*ssh_key.*)', '') | search(":")

ansible/roles/rally/tasks/config.yml

@@ -39,6 +39,7 @@
 
 - name: Check if policies shall be overwritten
   local_action: stat path="{{ node_custom_config }}/rally/policy.json"
+  run_once: True
   register: rally_policy
 
 - name: Copying over existing policy.json

ansible/roles/sahara/tasks/config.yml

@@ -46,6 +46,7 @@
 
 - name: Check if policies shall be overwritten
   local_action: stat path="{{ node_custom_config }}/sahara/policy.json"
+  run_once: True
   register: sahara_policy
 
 - name: Copying over existing policy.json

ansible/roles/searchlight/tasks/config.yml

@@ -41,6 +41,7 @@
 
 - name: Check if policies shall be overwritten
   local_action: stat path="{{ node_custom_config }}/searchlight/policy.json"
+  run_once: True
   register: searchlight_policy
 
 - name: Copying over existing policy.json

ansible/roles/senlin/tasks/config.yml

@@ -46,6 +46,7 @@
 
 - name: Check if policies shall be overwritten
   local_action: stat path="{{ node_custom_config }}/senlin/policy.json"
+  run_once: True
   register: senlin_policy
 
 - name: Copying over existing policy.json

ansible/roles/swift/tasks/config.yml

@@ -155,6 +155,7 @@
 
 - name: Check if policies shall be overwritten
   local_action: stat path="{{ node_custom_config }}/swift/policy.json"
+  run_once: True
   register: swift_policy
 
 - name: Copying over existing policy.json

ansible/roles/tacker/tasks/config.yml

@@ -44,6 +44,7 @@
 
 - name: Check if policies shall be overwritten
   local_action: stat path="{{ node_custom_config }}/tacker/policy.json"
+  run_once: True
   register: tacker_policy
 
 - name: Copying over existing policy.json

ansible/roles/watcher/tasks/config.yml

@@ -48,6 +48,7 @@
 
 - name: Check if policies shall be overwritten
   local_action: stat path="{{ node_custom_config }}/watcher/policy.json"
+  run_once: True
   register: watcher_policy
 
 - name: Copying over existing policy.json

ansible/roles/zun/tasks/config.yml

@@ -57,6 +57,7 @@
 
 - name: Check if policies shall be overwritten
   local_action: stat path="{{ node_custom_config }}/zun/policy.json"
+  run_once: True
   register: zun_policy
 
 - name: Copying over existing policy.json