From 10c1669364ca5c22b8aacc223ff4b6d8d13e3aaf Mon Sep 17 00:00:00 2001 From: Mark Goddard Date: Mon, 13 Jan 2020 10:39:23 +0000 Subject: [PATCH] Ansible lint: set -o pipefail when shell pipes used Change-Id: I3d0047d24b6daf35f30bd3429428e83b448e6414 Co-Authored-By: Marcin Juszkiewicz --- ansible/roles/barbican/tasks/check.yml | 1 + ansible/roles/qdrouterd/tasks/add_sasl_user.yml | 5 ++++- 2 files changed, 5 insertions(+), 1 deletion(-) diff --git a/ansible/roles/barbican/tasks/check.yml b/ansible/roles/barbican/tasks/check.yml index 43665afde1..66692756c7 100644 --- a/ansible/roles/barbican/tasks/check.yml +++ b/ansible/roles/barbican/tasks/check.yml @@ -2,6 +2,7 @@ - name: Barbican sanity - storing a secret become: true shell: > + set -o pipefail && \ docker exec -t barbican_api openstack \ --os-auth-url={{ openstack_auth.auth_url }} \ --os-password={{ openstack_auth.password }} \ diff --git a/ansible/roles/qdrouterd/tasks/add_sasl_user.yml b/ansible/roles/qdrouterd/tasks/add_sasl_user.yml index 7babd54594..da938c29a7 100644 --- a/ansible/roles/qdrouterd/tasks/add_sasl_user.yml +++ b/ansible/roles/qdrouterd/tasks/add_sasl_user.yml @@ -9,7 +9,10 @@ - kolla_action != "config" - name: Create qdrouterd sasl user - shell: echo {{ qdrouterd_password }} | docker exec -u root -i qdrouterd saslpasswd2 -c -p -f /var/lib/qdrouterd/qdrouterd.sasldb -u AMQP {{ qdrouterd_user }} + shell: > + set -o pipefail && \ + echo {{ qdrouterd_password }} | \ + docker exec -u root -i qdrouterd saslpasswd2 -c -p -f /var/lib/qdrouterd/qdrouterd.sasldb -u AMQP {{ qdrouterd_user }} run_once: true changed_when: true when: