From 85879afc0b793ea34b7e4edf0fc3cfcacd2ed1b7 Mon Sep 17 00:00:00 2001 From: Michal Arbet Date: Thu, 12 Aug 2021 13:06:06 +0200 Subject: [PATCH] Trivial fix nova's healthchecks Kolla-ansible upgrade task is calling different handlers as deploy task and these handlers are missing healthcheck key. This patch is fixing this. Closes-Bug: #1939679 Change-Id: Id83d20bfd89c27ccf70a3a79938f428cdb5d40fc --- ansible/roles/nova-cell/tasks/reload.yml | 1 + ansible/roles/nova/tasks/reload_api.yml | 1 + ansible/roles/nova/tasks/reload_super_conductor.yml | 1 + releasenotes/notes/bug-1939679-a31bc2093a4c0000.yaml | 5 +++++ 4 files changed, 8 insertions(+) create mode 100644 releasenotes/notes/bug-1939679-a31bc2093a4c0000.yaml diff --git a/ansible/roles/nova-cell/tasks/reload.yml b/ansible/roles/nova-cell/tasks/reload.yml index 45ede976d7..d55630a086 100644 --- a/ansible/roles/nova-cell/tasks/reload.yml +++ b/ansible/roles/nova-cell/tasks/reload.yml @@ -33,6 +33,7 @@ privileged: "{{ service.privileged | default(False) }}" volumes: "{{ service.volumes|reject('equalto', '')|list }}" dimensions: "{{ service.dimensions }}" + healthcheck: "{{ service.healthcheck | default(omit) }}" when: - kolla_action == 'upgrade' - inventory_hostname in groups[service.group] diff --git a/ansible/roles/nova/tasks/reload_api.yml b/ansible/roles/nova/tasks/reload_api.yml index 52c7446176..6006852e6a 100644 --- a/ansible/roles/nova/tasks/reload_api.yml +++ b/ansible/roles/nova/tasks/reload_api.yml @@ -14,6 +14,7 @@ privileged: "{{ service.privileged | default(False) }}" volumes: "{{ service.volumes|reject('equalto', '')|list }}" dimensions: "{{ service.dimensions }}" + healthcheck: "{{ service.healthcheck | default(omit) }}" when: - kolla_action == 'upgrade' - inventory_hostname in groups[service.group] diff --git a/ansible/roles/nova/tasks/reload_super_conductor.yml b/ansible/roles/nova/tasks/reload_super_conductor.yml index 687b2b0135..d745a464d1 100644 --- a/ansible/roles/nova/tasks/reload_super_conductor.yml +++ b/ansible/roles/nova/tasks/reload_super_conductor.yml @@ -14,6 +14,7 @@ privileged: "{{ service.privileged | default(False) }}" volumes: "{{ service.volumes|reject('equalto', '')|list }}" dimensions: "{{ service.dimensions }}" + healthcheck: "{{ service.healthcheck | default(omit) }}" when: - kolla_action == 'upgrade' - inventory_hostname in groups[service.group] diff --git a/releasenotes/notes/bug-1939679-a31bc2093a4c0000.yaml b/releasenotes/notes/bug-1939679-a31bc2093a4c0000.yaml new file mode 100644 index 0000000000..f5d4fdf7a4 --- /dev/null +++ b/releasenotes/notes/bug-1939679-a31bc2093a4c0000.yaml @@ -0,0 +1,5 @@ +--- +fixes: + - | + Fixes nova's healthchecks when upgrading from previous version. + `LP#1939679 `__