From 93a4dcc1b97b1d7bbd3b91cc9c4bd4617ec6f9ba Mon Sep 17 00:00:00 2001 From: Mark Goddard Date: Mon, 9 Mar 2020 11:27:25 +0000 Subject: [PATCH] Fix HAProxy monitor VIP precheck If haproxy is running somewhere in the cluster and listening on the VIP, but not running locally, then the following precheck may fail: TASK [haproxy : Checking free port for HAProxy monitor (vip interface)] msg: Timeout when waiting for 192.0.2.10:61313 to stop. This change fixes the issue by skipping the check if HAProxy is running on any host. Change-Id: I831eb2f700ef3fcf65b7e08382c3b4fcc4ce8d8d Closes-Bug: #1866617 --- ansible/roles/haproxy/tasks/precheck.yml | 2 +- .../fix-haproxy-monitor-precheck-487b85f4e93313b1.yaml | 6 ++++++ 2 files changed, 7 insertions(+), 1 deletion(-) create mode 100644 releasenotes/notes/fix-haproxy-monitor-precheck-487b85f4e93313b1.yaml diff --git a/ansible/roles/haproxy/tasks/precheck.yml b/ansible/roles/haproxy/tasks/precheck.yml index 69cbf03bb0..13dccc31d5 100644 --- a/ansible/roles/haproxy/tasks/precheck.yml +++ b/ansible/roles/haproxy/tasks/precheck.yml @@ -199,7 +199,7 @@ state: stopped when: - enable_haproxy | bool - - container_facts['haproxy'] is not defined + - "host_running_haproxy == 'None'" - inventory_hostname in groups['haproxy'] - api_interface_address != kolla_internal_vip_address diff --git a/releasenotes/notes/fix-haproxy-monitor-precheck-487b85f4e93313b1.yaml b/releasenotes/notes/fix-haproxy-monitor-precheck-487b85f4e93313b1.yaml new file mode 100644 index 0000000000..933afee4b1 --- /dev/null +++ b/releasenotes/notes/fix-haproxy-monitor-precheck-487b85f4e93313b1.yaml @@ -0,0 +1,6 @@ +--- +fixes: + - | + Fixes an issue with the HAProxy monitor VIP precheck when some instances of + HAProxy are running and others are not. See `bug 1866617 + `__.