cinder: start using active-active for rbd

This patch starts using RBD active-active which is Cinder team recommended approach for grouping volume hosts that share the same backend conigurations to work in HA Active-Active mode.

Change-Id: I02817963c691784c126c79e330981e0cc771bc88
Closes-Bug: #1904062

ansible/roles/cinder/tasks/precheck.yml

@@ -50,3 +50,12 @@
     - enable_cinder | bool
     - enable_cinder_backend_lvm | bool
     - inventory_hostname in groups['cinder-volume']
+
+- name: Checking for coordination backend if Ceph backend is enabled
+  run_once: True
+  fail:
+    msg: "Please enable redis or etcd when using Cinder Ceph backend"
+  when:
+    - not skip_cinder_backend_check | bool
+    - cinder_backend_ceph | bool
+    - cinder_coordination_backend == ''

ansible/roles/cinder/templates/cinder.conf.j2

@@ -20,6 +20,10 @@ glance_api_servers = {{ glance_internal_endpoint }}
 glance_num_retries = {{ groups['glance-api'] | length }}
 glance_ca_certificates_file = {{ openstack_cacert }}
 
+{% if cinder_backend_ceph | bool %}
+cluster = ceph
+{% endif %}
+
 {% if cinder_enabled_backends %}
 enabled_backends = {{ cinder_enabled_backends|map(attribute='name')|join(',') }}
 {% endif %}

releasenotes/notes/bug-1904062-ace44b3ceeb676d4.yaml

@@ -0,0 +1,16 @@
+---
+features:
+  - |
+    Cinder is deployed with Active-Active enabled by default if you are using
+    Ceph as a backend storage.
+upgrade:
+  - |
+    If you use Ceph backend in Cinder - It is possible that you may need to
+    use ``cinder-manage`` to migrate volumes to a specific host.
+    You will have to remove the old ``rbd:volumes`` services which will be
+    stale.
+fixes:
+  - |
+    Fixed a bug `LP#1904062 <https://launchpad.net/bugs/1904062>`__
+    where Cinder volume services sharing a common backend would
+    cause duplicate messages that cause problems in the environment.

tests/templates/globals-default.j2

@@ -121,6 +121,7 @@ enable_rabbitmq: "no"
 {% if scenario == "cephadm" %}
 # kolla-ansible vars
 enable_cinder: "yes"
+enable_redis: "yes"
 # External Ceph
 glance_backend_ceph: "yes"
 cinder_backend_ceph: "yes"