openstack
/
kolla-kubernetes
Code Issues Proposed changes

Update patch set 34 

Patch Set 34: Code-Review-1

(2 comments)

Patch-set: 34
Reviewer: Gerrit User 19384 <19384@4a232e18-c5a9-48ee-94c0-e04e7cca6543>
Label: Code-Review=-1
This commit is contained in:
Gerrit User 19384 2017-10-16 20:24:02 +00:00 committed by Gerrit Code Review
parent 4e8e377f2a
commit 0c18822192
1 changed files with 38 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

38
bdbd3c72f9876b72967395949103dd5082c97b62 Normal file
View File

@ -0,0 +1,38 @@
{
"comments": [
{
"key": {
"uuid": "5f4e5783_dfe0ec28",
"filename": "orchestration/ansible/roles/deploy/tasks/cinder-control.yml",
"patchSetId": 34
},
"lineNbr": 1,
"author": {
"id": 19384
},
"writtenOn": "2017-10-16T20:24:02Z",
"side": 1,
"message": "Could you define microservices location variable and use it instead of specifying ../../helm/microservice. God forbid one day the location will get changed ;)",
"revId": "bdbd3c72f9876b72967395949103dd5082c97b62",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "5f4e5783_7fb3380b",
"filename": "orchestration/ansible/roles/deploy/tasks/nova-compute.yml",
"patchSetId": 34
},
"lineNbr": 1,
"author": {
"id": 19384
},
"writtenOn": "2017-10-16T20:24:02Z",
"side": 1,
"message": "Relaying on POD being in running state does not guarantee that the openstack process wrapped inside of the pod is also running and ready for service. This approach can introduce instabilities and multiple racing conditions.",
"revId": "bdbd3c72f9876b72967395949103dd5082c97b62",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
}
]
}