Update patch set 6
Patch Set 6: (9 comments) Patch-set: 6
This commit is contained in:
Gerrit User 13702
Gerrit Code Review
parent
de8e5e51a8
commit
7d4bb9acb1
|
|
@ -47,6 +47,30 @@
|
|||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
|
||||
"unresolved": false
|
||||
},
|
||||
{
|
||||
"key": {
|
||||
"uuid": "df87a7cf_ce950234",
|
||||
"filename": "doc/source/deployment-guide.rst",
|
||||
"patchSetId": 6
|
||||
},
|
||||
"lineNbr": 49,
|
||||
"author": {
|
||||
"id": 13702
|
||||
},
|
||||
"writtenOn": "2017-12-18T15:56:03Z",
|
||||
"side": 1,
|
||||
"message": "OK, so we should update 1.13.",
|
||||
"parentUuid": "df87a7cf_501515e4",
|
||||
"range": {
|
||||
"startLine": 49,
|
||||
"startChar": 4,
|
||||
"endLine": 49,
|
||||
"endChar": 20
|
||||
},
|
||||
"revId": "99800362486ebc081b75bef4a8ed11b2f2be3e46",
|
||||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
|
||||
"unresolved": false
|
||||
},
|
||||
{
|
||||
"key": {
|
||||
"uuid": "df87a7cf_70d05920",
|
||||
|
|
@ -70,6 +94,30 @@
|
|||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
|
||||
"unresolved": false
|
||||
},
|
||||
{
|
||||
"key": {
|
||||
"uuid": "df87a7cf_ce80a2fa",
|
||||
"filename": "doc/source/deployment-guide.rst",
|
||||
"patchSetId": 6
|
||||
},
|
||||
"lineNbr": 64,
|
||||
"author": {
|
||||
"id": 13702
|
||||
},
|
||||
"writtenOn": "2017-12-18T15:56:03Z",
|
||||
"side": 1,
|
||||
"message": "I see. OK, it\u0027s better to split this change.",
|
||||
"parentUuid": "df87a7cf_70d05920",
|
||||
"range": {
|
||||
"startLine": 64,
|
||||
"startChar": 5,
|
||||
"endLine": 64,
|
||||
"endChar": 6
|
||||
},
|
||||
"revId": "99800362486ebc081b75bef4a8ed11b2f2be3e46",
|
||||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
|
||||
"unresolved": false
|
||||
},
|
||||
{
|
||||
"key": {
|
||||
"uuid": "df87a7cf_30c6516a",
|
||||
|
|
@ -93,6 +141,30 @@
|
|||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
|
||||
"unresolved": false
|
||||
},
|
||||
{
|
||||
"key": {
|
||||
"uuid": "df87a7cf_6eeab6d8",
|
||||
"filename": "doc/source/deployment-guide.rst",
|
||||
"patchSetId": 6
|
||||
},
|
||||
"lineNbr": 81,
|
||||
"author": {
|
||||
"id": 13702
|
||||
},
|
||||
"writtenOn": "2017-12-18T15:56:03Z",
|
||||
"side": 1,
|
||||
"message": "Yeah. I\u0027ve tested and 1.8.5 and 1.9.0 worked :)",
|
||||
"parentUuid": "df87a7cf_30c6516a",
|
||||
"range": {
|
||||
"startLine": 81,
|
||||
"startChar": 3,
|
||||
"endLine": 81,
|
||||
"endChar": 8
|
||||
},
|
||||
"revId": "99800362486ebc081b75bef4a8ed11b2f2be3e46",
|
||||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
|
||||
"unresolved": false
|
||||
},
|
||||
{
|
||||
"key": {
|
||||
"uuid": "df87a7cf_b08021f9",
|
||||
|
|
@ -116,6 +188,30 @@
|
|||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
|
||||
"unresolved": false
|
||||
},
|
||||
{
|
||||
"key": {
|
||||
"uuid": "df87a7cf_2e2eee91",
|
||||
"filename": "doc/source/deployment-guide.rst",
|
||||
"patchSetId": 6
|
||||
},
|
||||
"lineNbr": 186,
|
||||
"author": {
|
||||
"id": 13702
|
||||
},
|
||||
"writtenOn": "2017-12-18T15:56:03Z",
|
||||
"side": 1,
|
||||
"message": "Thanks for your review. OK, will fix it.",
|
||||
"parentUuid": "df87a7cf_b08021f9",
|
||||
"range": {
|
||||
"startLine": 186,
|
||||
"startChar": 0,
|
||||
"endLine": 186,
|
||||
"endChar": 20
|
||||
},
|
||||
"revId": "99800362486ebc081b75bef4a8ed11b2f2be3e46",
|
||||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
|
||||
"unresolved": false
|
||||
},
|
||||
{
|
||||
"key": {
|
||||
"uuid": "df87a7cf_70a3799f",
|
||||
|
|
@ -139,6 +235,30 @@
|
|||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
|
||||
"unresolved": false
|
||||
},
|
||||
{
|
||||
"key": {
|
||||
"uuid": "df87a7cf_ae399ed7",
|
||||
"filename": "doc/source/deployment-guide.rst",
|
||||
"patchSetId": 6
|
||||
},
|
||||
"lineNbr": 373,
|
||||
"author": {
|
||||
"id": 13702
|
||||
},
|
||||
"writtenOn": "2017-12-18T15:56:03Z",
|
||||
"side": 1,
|
||||
"message": "Ah, I referred here: http://docs.ansible.com/ansible/latest/intro_installation.html#latest-releases-via-apt-ubuntu\nHowever, I think it\u0027s not mandatory.",
|
||||
"parentUuid": "df87a7cf_70a3799f",
|
||||
"range": {
|
||||
"startLine": 373,
|
||||
"startChar": 43,
|
||||
"endLine": 373,
|
||||
"endChar": 69
|
||||
},
|
||||
"revId": "99800362486ebc081b75bef4a8ed11b2f2be3e46",
|
||||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
|
||||
"unresolved": false
|
||||
},
|
||||
{
|
||||
"key": {
|
||||
"uuid": "df87a7cf_90ce3d58",
|
||||
|
|
@ -156,6 +276,24 @@
|
|||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
|
||||
"unresolved": false
|
||||
},
|
||||
{
|
||||
"key": {
|
||||
"uuid": "df87a7cf_4e6012d0",
|
||||
"filename": "doc/source/deployment-guide.rst",
|
||||
"patchSetId": 6
|
||||
},
|
||||
"lineNbr": 436,
|
||||
"author": {
|
||||
"id": 13702
|
||||
},
|
||||
"writtenOn": "2017-12-18T15:56:03Z",
|
||||
"side": 1,
|
||||
"message": "OK, will fix them. \n\n\u003e can you clarify what you mean here?\n\nThis is my poor English.. I wanted to figure out \"it\u0027s enough to specify IP address which is equal to \u0027network_interface\u0027\" I\u0027ll remove this word.",
|
||||
"parentUuid": "df87a7cf_90ce3d58",
|
||||
"revId": "99800362486ebc081b75bef4a8ed11b2f2be3e46",
|
||||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
|
||||
"unresolved": false
|
||||
},
|
||||
{
|
||||
"key": {
|
||||
"uuid": "df87a7cf_703ff924",
|
||||
|
|
@ -179,6 +317,30 @@
|
|||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
|
||||
"unresolved": false
|
||||
},
|
||||
{
|
||||
"key": {
|
||||
"uuid": "df87a7cf_2e8a6e69",
|
||||
"filename": "doc/source/deployment-guide.rst",
|
||||
"patchSetId": 6
|
||||
},
|
||||
"lineNbr": 528,
|
||||
"author": {
|
||||
"id": 13702
|
||||
},
|
||||
"writtenOn": "2017-12-18T15:56:03Z",
|
||||
"side": 1,
|
||||
"message": "Indeed, I could count totally 195. Ah, I just understood why we were counting the number of \u0027tar.gz\u0027 at last!! OK, will update.",
|
||||
"parentUuid": "df87a7cf_703ff924",
|
||||
"range": {
|
||||
"startLine": 528,
|
||||
"startChar": 72,
|
||||
"endLine": 528,
|
||||
"endChar": 75
|
||||
},
|
||||
"revId": "99800362486ebc081b75bef4a8ed11b2f2be3e46",
|
||||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
|
||||
"unresolved": false
|
||||
},
|
||||
{
|
||||
"key": {
|
||||
"uuid": "df87a7cf_9025dd0b",
|
||||
|
|
@ -202,6 +364,30 @@
|
|||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
|
||||
"unresolved": false
|
||||
},
|
||||
{
|
||||
"key": {
|
||||
"uuid": "df87a7cf_4e51f2d8",
|
||||
"filename": "doc/source/deployment-guide.rst",
|
||||
"patchSetId": 6
|
||||
},
|
||||
"lineNbr": 595,
|
||||
"author": {
|
||||
"id": 13702
|
||||
},
|
||||
"writtenOn": "2017-12-18T15:56:03Z",
|
||||
"side": 1,
|
||||
"message": "Rich, I thought it was definition of cloud.yaml. Currently, \u0027base_distro\u0027 was only worked with \u0027centos\u0027. Please check my result:\nhttp://paste.openstack.org/show/629147/",
|
||||
"parentUuid": "df87a7cf_9025dd0b",
|
||||
"range": {
|
||||
"startLine": 593,
|
||||
"startChar": 0,
|
||||
"endLine": 595,
|
||||
"endChar": 54
|
||||
},
|
||||
"revId": "99800362486ebc081b75bef4a8ed11b2f2be3e46",
|
||||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
|
||||
"unresolved": false
|
||||
},
|
||||
{
|
||||
"key": {
|
||||
"uuid": "df87a7cf_706db930",
|
||||
|
|
@ -224,6 +410,30 @@
|
|||
"revId": "99800362486ebc081b75bef4a8ed11b2f2be3e46",
|
||||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
|
||||
"unresolved": false
|
||||
},
|
||||
{
|
||||
"key": {
|
||||
"uuid": "df87a7cf_8ef93ac9",
|
||||
"filename": "doc/source/deployment-guide.rst",
|
||||
"patchSetId": 6
|
||||
},
|
||||
"lineNbr": 698,
|
||||
"author": {
|
||||
"id": 13702
|
||||
},
|
||||
"writtenOn": "2017-12-18T15:56:03Z",
|
||||
"side": 1,
|
||||
"message": "Maybe he added with root user (\"#\") privilege.",
|
||||
"parentUuid": "df87a7cf_706db930",
|
||||
"range": {
|
||||
"startLine": 687,
|
||||
"startChar": 0,
|
||||
"endLine": 698,
|
||||
"endChar": 40
|
||||
},
|
||||
"revId": "99800362486ebc081b75bef4a8ed11b2f2be3e46",
|
||||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
|
||||
"unresolved": false
|
||||
}
|
||||
]
|
||||
}
|
||||
Loading…
Reference in New Issue