openstack/kolla-kubernetes
Code Issues Proposed changes

Update patch set 8

Browse Source 
Patch Set 8:

(1 comment)

Patch-set: 8
This commit is contained in:
Gerrit User 23928 2016-11-29 01:12:54 +00:00 committed by Gerrit Code Review
parent ebe8bcf976
commit a7d39e0481
1 changed files with 21 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

21
883046b1cfed40595628116cb1cec4867c210c9e Normal file
View File

@ -0,0 +1,21 @@
{
"comments": [
{
"key": {
"uuid": "5a74a57a_583da68d",
"filename": "helm/kolla-kubernetes/templates/_helpers.tpl",
"patchSetId": 8
},
"lineNbr": 24,
"author": {
"id": 23928
},
"writtenOn": "2016-11-29T01:12:54Z",
"side": 1,
"message": "It would be great (from my perspective) if we made use of the downward api here (at least for namespace): https://raw.githubusercontent.com/kubernetes/kubernetes.github.io/master/docs/user-guide/downward-api/dapi-pod.yaml",
"revId": "883046b1cfed40595628116cb1cec4867c210c9e",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
}
]
}