openstack
/
kolla-kubernetes
Code Issues Proposed changes

Update patch set 3 

Patch Set 3: Code-Review-1

(27 comments)

Patch-set: 3
Reviewer: Gerrit User 2834 <2834@4a232e18-c5a9-48ee-94c0-e04e7cca6543>
Label: Code-Review=-1
This commit is contained in:
Gerrit User 2834 2017-01-02 08:00:45 +00:00 committed by Gerrit Code Review
parent bf57ea1884
commit b28a4e6586
1 changed files with 615 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

615
655d785dfb2190c10596db4d696c648df535e74b
View File

@ -23,6 +23,29 @@
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "ba5201f7_cc6280d8",
"filename": "doc/source/conventions.rst",
"patchSetId": 3
},
"lineNbr": 11,
"author": {
"id": 2834
},
"writtenOn": "2017-01-02T08:00:45Z",
"side": 1,
"message": "parts/components",
"range": {
"startLine": 11,
"startChar": 8,
"endLine": 11,
"endChar": 13
},
"revId": "655d785dfb2190c10596db4d696c648df535e74b",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "fa6399be_01205e47",
@ -40,6 +63,52 @@
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "ba5201f7_ac653ce2",
"filename": "doc/source/conventions.rst",
"patchSetId": 3
},
"lineNbr": 17,
"author": {
"id": 2834
},
"writtenOn": "2017-01-02T08:00:45Z",
"side": 1,
"message": "pronoun - \"The kolla-kubernetes deliverable must follow\"",
"range": {
"startLine": 17,
"startChar": 0,
"endLine": 17,
"endChar": 2
},
"revId": "655d785dfb2190c10596db4d696c648df535e74b",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "ba5201f7_4ca5b002",
"filename": "doc/source/conventions.rst",
"patchSetId": 3
},
"lineNbr": 20,
"author": {
"id": 2834
},
"writtenOn": "2017-01-02T08:00:45Z",
"side": 1,
"message": "terrible generalization and sends wrong message. Try softening it up with something like\n\"OpenStack has many configuration options which increase debug complexity. If the ... or the links/integration ... are not smooth/consistent, debug complexity is further increased.\"",
"range": {
"startLine": 20,
"startChar": 0,
"endLine": 20,
"endChar": 68
},
"revId": "655d785dfb2190c10596db4d696c648df535e74b",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "3a71b18c_322c3cab",
@ -86,6 +155,75 @@
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "ba5201f7_6c7354b2",
"filename": "doc/source/conventions.rst",
"patchSetId": 3
},
"lineNbr": 29,
"author": {
"id": 2834
},
"writtenOn": "2017-01-02T08:00:45Z",
"side": 1,
"message": "this whole paragraph needs rework. It makes a whole bunch of assumptions which may be invalid and turn off the reader. I\u0027d go with something simple with your key message which as I understand it is:\n1. Optimize learning time of Operators\n\nWhy not just say that instead?\n\"Operators often are presented with varying conventions in different deployment tools. This documentation optimizes learning time of Operators by providing a common set of conventions when using the kolla-kubernetes deliverable\" or something similar.",
"range": {
"startLine": 24,
"startChar": 0,
"endLine": 29,
"endChar": 67
},
"revId": "655d785dfb2190c10596db4d696c648df535e74b",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "ba5201f7_acac5cee",
"filename": "doc/source/conventions.rst",
"patchSetId": 3
},
"lineNbr": 32,
"author": {
"id": 2834
},
"writtenOn": "2017-01-02T08:00:45Z",
"side": 1,
"message": "my momma told me never to end a sentence with a preposition.",
"range": {
"startLine": 32,
"startChar": 61,
"endLine": 32,
"endChar": 64
},
"revId": "655d785dfb2190c10596db4d696c648df535e74b",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "ba5201f7_8caf98e2",
"filename": "doc/source/conventions.rst",
"patchSetId": 3
},
"lineNbr": 32,
"author": {
"id": 2834
},
"writtenOn": "2017-01-02T08:00:45Z",
"side": 1,
"message": "developers don\u0027t scan through, they read :)",
"range": {
"startLine": 32,
"startChar": 3,
"endLine": 32,
"endChar": 7
},
"revId": "655d785dfb2190c10596db4d696c648df535e74b",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "3a71b18c_cd39adda",
@ -109,6 +247,75 @@
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "ba5201f7_ccb9a030",
"filename": "doc/source/conventions.rst",
"patchSetId": 3
},
"lineNbr": 43,
"author": {
"id": 2834
},
"writtenOn": "2017-01-02T08:00:45Z",
"side": 1,
"message": "pronoun police",
"range": {
"startLine": 43,
"startChar": 0,
"endLine": 43,
"endChar": 2
},
"revId": "655d785dfb2190c10596db4d696c648df535e74b",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "ba5201f7_0c82c852",
"filename": "doc/source/conventions.rst",
"patchSetId": 3
},
"lineNbr": 50,
"author": {
"id": 2834
},
"writtenOn": "2017-01-02T08:00:45Z",
"side": 1,
"message": "pronoun police",
"range": {
"startLine": 50,
"startChar": 0,
"endLine": 50,
"endChar": 2
},
"revId": "655d785dfb2190c10596db4d696c648df535e74b",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "ba5201f7_4c7cd072",
"filename": "doc/source/conventions.rst",
"patchSetId": 3
},
"lineNbr": 57,
"author": {
"id": 2834
},
"writtenOn": "2017-01-02T08:00:45Z",
"side": 1,
"message": "something, like what? How about something/object?",
"range": {
"startLine": 57,
"startChar": 12,
"endLine": 57,
"endChar": 21
},
"revId": "655d785dfb2190c10596db4d696c648df535e74b",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "fa6399be_01969e92",
@ -132,6 +339,230 @@
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "ba5201f7_8c96b892",
"filename": "doc/source/conventions.rst",
"patchSetId": 3
},
"lineNbr": 63,
"author": {
"id": 2834
},
"writtenOn": "2017-01-02T08:00:45Z",
"side": 1,
"message": "need a CR here to be consistent with RST syntax.",
"revId": "655d785dfb2190c10596db4d696c648df535e74b",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "ba5201f7_ec8d847c",
"filename": "doc/source/conventions.rst",
"patchSetId": 3
},
"lineNbr": 76,
"author": {
"id": 2834
},
"writtenOn": "2017-01-02T08:00:45Z",
"side": 1,
"message": "pronoun police - try \"the Operator\"",
"range": {
"startLine": 76,
"startChar": 54,
"endLine": 76,
"endChar": 57
},
"revId": "655d785dfb2190c10596db4d696c648df535e74b",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "ba5201f7_0ce9e81a",
"filename": "doc/source/conventions.rst",
"patchSetId": 3
},
"lineNbr": 77,
"author": {
"id": 2834
},
"writtenOn": "2017-01-02T08:00:45Z",
"side": 1,
"message": "avoidance of",
"range": {
"startLine": 77,
"startChar": 66,
"endLine": 77,
"endChar": 74
},
"revId": "655d785dfb2190c10596db4d696c648df535e74b",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "ba5201f7_acda9c76",
"filename": "doc/source/conventions.rst",
"patchSetId": 3
},
"lineNbr": 78,
"author": {
"id": 2834
},
"writtenOn": "2017-01-02T08:00:45Z",
"side": 1,
"message": "simplify the",
"range": {
"startLine": 78,
"startChar": 41,
"endLine": 78,
"endChar": 56
},
"revId": "655d785dfb2190c10596db4d696c648df535e74b",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "ba5201f7_8cddd872",
"filename": "doc/source/conventions.rst",
"patchSetId": 3
},
"lineNbr": 79,
"author": {
"id": 2834
},
"writtenOn": "2017-01-02T08:00:45Z",
"side": 1,
"message": "retrieve",
"range": {
"startLine": 79,
"startChar": 40,
"endLine": 79,
"endChar": 43
},
"revId": "655d785dfb2190c10596db4d696c648df535e74b",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "ba5201f7_4cf3f00a",
"filename": "doc/source/conventions.rst",
"patchSetId": 3
},
"lineNbr": 79,
"author": {
"id": 2834
},
"writtenOn": "2017-01-02T08:00:45Z",
"side": 1,
"message": "groan pronouns",
"range": {
"startLine": 79,
"startChar": 50,
"endLine": 79,
"endChar": 52
},
"revId": "655d785dfb2190c10596db4d696c648df535e74b",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "ba5201f7_2c630cb3",
"filename": "doc/source/conventions.rst",
"patchSetId": 3
},
"lineNbr": 82,
"author": {
"id": 2834
},
"writtenOn": "2017-01-02T08:00:45Z",
"side": 1,
"message": "foo-api::",
"range": {
"startLine": 82,
"startChar": 43,
"endLine": 82,
"endChar": 50
},
"revId": "655d785dfb2190c10596db4d696c648df535e74b",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "ba5201f7_0c5e48e9",
"filename": "doc/source/conventions.rst",
"patchSetId": 3
},
"lineNbr": 82,
"author": {
"id": 2834
},
"writtenOn": "2017-01-02T08:00:45Z",
"side": 1,
"message": "this blob of text isn\u0027t necessary and adds no value",
"range": {
"startLine": 82,
"startChar": 50,
"endLine": 82,
"endChar": 67
},
"revId": "655d785dfb2190c10596db4d696c648df535e74b",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "ba5201f7_ec52e4dc",
"filename": "doc/source/conventions.rst",
"patchSetId": 3
},
"lineNbr": 86,
"author": {
"id": 2834
},
"writtenOn": "2017-01-02T08:00:45Z",
"side": 1,
"message": "Pronoun - zug. \"Operator\u0027s must execute this operation::\"",
"range": {
"startLine": 86,
"startChar": 0,
"endLine": 86,
"endChar": 2
},
"revId": "655d785dfb2190c10596db4d696c648df535e74b",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "ba5201f7_cc5520c7",
"filename": "doc/source/conventions.rst",
"patchSetId": 3
},
"lineNbr": 86,
"author": {
"id": 2834
},
"writtenOn": "2017-01-02T08:00:45Z",
"side": 1,
"message": "::",
"range": {
"startLine": 86,
"startChar": 17,
"endLine": 86,
"endChar": 18
},
"revId": "655d785dfb2190c10596db4d696c648df535e74b",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "3a71b18c_f454bbca",
@ -172,6 +603,98 @@
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "ba5201f7_0cd00853",
"filename": "doc/source/conventions.rst",
"patchSetId": 3
},
"lineNbr": 97,
"author": {
"id": 2834
},
"writtenOn": "2017-01-02T08:00:45Z",
"side": 1,
"message": "Sentences should begin with So :)",
"range": {
"startLine": 97,
"startChar": 0,
"endLine": 97,
"endChar": 2
},
"revId": "655d785dfb2190c10596db4d696c648df535e74b",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "ba5201f7_4cca10a3",
"filename": "doc/source/conventions.rst",
"patchSetId": 3
},
"lineNbr": 97,
"author": {
"id": 2834
},
"writtenOn": "2017-01-02T08:00:45Z",
"side": 1,
"message": "instead of hedging with a weak should not, how about must not (if you desire to hedge).",
"range": {
"startLine": 97,
"startChar": 18,
"endLine": 97,
"endChar": 28
},
"revId": "655d785dfb2190c10596db4d696c648df535e74b",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "ba5201f7_8cc4f892",
"filename": "doc/source/conventions.rst",
"patchSetId": 3
},
"lineNbr": 100,
"author": {
"id": 2834
},
"writtenOn": "2017-01-02T08:00:45Z",
"side": 1,
"message": "New paragraph needs a new noun - have no idea what noun your referencing.",
"range": {
"startLine": 100,
"startChar": 3,
"endLine": 100,
"endChar": 5
},
"revId": "655d785dfb2190c10596db4d696c648df535e74b",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "ba5201f7_6ccfd4b0",
"filename": "doc/source/conventions.rst",
"patchSetId": 3
},
"lineNbr": 100,
"author": {
"id": 2834
},
"writtenOn": "2017-01-02T08:00:45Z",
"side": 1,
"message": "which noun does this it refer to?",
"range": {
"startLine": 100,
"startChar": 16,
"endLine": 100,
"endChar": 18
},
"revId": "655d785dfb2190c10596db4d696c648df535e74b",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "3a71b18c_d4709f74",
@ -194,6 +717,98 @@
"revId": "655d785dfb2190c10596db4d696c648df535e74b",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "ba5201f7_ccbe00ff",
"filename": "doc/source/conventions.rst",
"patchSetId": 3
},
"lineNbr": 109,
"author": {
"id": 2834
},
"writtenOn": "2017-01-02T08:00:45Z",
"side": 1,
"message": "\"simplify Operator activities when switching between referencing objects\"",
"range": {
"startLine": 109,
"startChar": 3,
"endLine": 109,
"endChar": 68
},
"revId": "655d785dfb2190c10596db4d696c648df535e74b",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "ba5201f7_ac48dc2e",
"filename": "doc/source/conventions.rst",
"patchSetId": 3
},
"lineNbr": 111,
"author": {
"id": 2834
},
"writtenOn": "2017-01-02T08:00:45Z",
"side": 1,
"message": "change : to :: so this block renders correctly",
"range": {
"startLine": 111,
"startChar": 54,
"endLine": 111,
"endChar": 55
},
"revId": "655d785dfb2190c10596db4d696c648df535e74b",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "ba5201f7_8c4b182b",
"filename": "doc/source/conventions.rst",
"patchSetId": 3
},
"lineNbr": 115,
"author": {
"id": 2834
},
"writtenOn": "2017-01-02T08:00:45Z",
"side": 1,
"message": "change : to :: so it renders in block format",
"range": {
"startLine": 115,
"startChar": 12,
"endLine": 115,
"endChar": 13
},
"revId": "655d785dfb2190c10596db4d696c648df535e74b",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "ba5201f7_4c41300b",
"filename": "doc/source/conventions.rst",
"patchSetId": 3
},
"lineNbr": 115,
"author": {
"id": 2834
},
"writtenOn": "2017-01-02T08:00:45Z",
"side": 1,
"message": "Pronoun without a scoped noun.",
"range": {
"startLine": 115,
"startChar": 0,
"endLine": 115,
"endChar": 2
},
"revId": "655d785dfb2190c10596db4d696c648df535e74b",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
}
]
}