From bb3795921b92b3221f8a1b23ef48efce64f2fd9f Mon Sep 17 00:00:00 2001
From: Gerrit User 13702 <13702@4a232e18-c5a9-48ee-94c0-e04e7cca6543>
Date: Sun, 17 Dec 2017 01:45:25 +0000
Subject: [PATCH] Update patch set 3

Patch Set 3: Code-Review-1

(2 comments)

Good news!  I tested with following kubernetes packages and worked correctly!!

* kubectl: v1.9.0-00
* kubeadm: v1.9.0-00
* kubelet: v1.9.0-00
* kubernetes-cni: v0.6.0-00
* rbac.yaml and canal.yaml: used '1.7'

In my test perspective, k8s v1.8.5 and v1.9.0 works correctly with kolla-kubernetes(master) today.

Patch-set: 3
Label: Code-Review=-1
---
 29e4b00e784213336add5397689433c8886ae7f6 | 41 ++++++++++++++++++++++++
 1 file changed, 41 insertions(+)

diff --git a/29e4b00e784213336add5397689433c8886ae7f6 b/29e4b00e784213336add5397689433c8886ae7f6
index b582c411e..2d61c1ca0 100644
--- a/29e4b00e784213336add5397689433c8886ae7f6
+++ b/29e4b00e784213336add5397689433c8886ae7f6
@@ -23,6 +23,23 @@
       "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
       "unresolved": false
     },
+    {
+      "key": {
+        "uuid": "df87a7cf_de34f84c",
+        "filename": "doc/source/deployment-guide.rst",
+        "patchSetId": 3
+      },
+      "lineNbr": 585,
+      "author": {
+        "id": 13702
+      },
+      "writtenOn": "2017-12-17T01:45:25Z",
+      "side": 1,
+      "message": "It was wrong \u0027indent\u0027.  It should be as follows:\n\ncat \u003c\u003cEOF \u003e cloud.yaml\nglobal:\n  kolla:\n    all:\n      docker_registry: docker.io\n      image_tag: \"4.0.0\"\n      kube_logger: false\n      external_vip: \"192.168.7.105\"\n      base_distro: \"centos\"\n      install_type: \"source\"\n      tunnel_interface: \"docker0\"\n    keystone:\n      all:\n        admin_port_external: \"true\"\n        dns_name: \"192.168.7.105\"\n        port: 5000\n      public:\n        all:\n          port_external: \"true\"\n    rabbitmq:\n      all:\n        cookie: 67\n    glance:\n      api:\n        all:\n          port_external: \"true\"\n    cinder:\n      api:\n        all:\n          port_external: \"true\"\n    volume_lvm:\n      all:\n        element_name: cinder-volume\n      daemonset:\n        lvm_backends:\n        - \u0027192.168.7.105\u0027: \u0027cinder-volumes\u0027\n    ironic:\n      conductor:\n        daemonset:\n          selector_key: \"kolla_conductor\"\n    nova:\n      placement_api:\n        all:\n          port_external: true\n      novncproxy:\n        all:\n          port: 6080\n          port_external: true\n    openvswitch:\n      all:\n        add_port: true\n        ext_bridge_name: br-ex\n        ext_interface_name: enp1s0f1\n        setup_bridge: true\n    horizon:\n      all:\n        port_external: true\nEOF",
+      "revId": "29e4b00e784213336add5397689433c8886ae7f6",
+      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
+      "unresolved": false
+    },
     {
       "key": {
         "uuid": "df87a7cf_9eb3d54d",
@@ -45,6 +62,30 @@
       "revId": "29e4b00e784213336add5397689433c8886ae7f6",
       "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
       "unresolved": false
+    },
+    {
+      "key": {
+        "uuid": "df87a7cf_9e3e7027",
+        "filename": "doc/source/deployment-guide.rst",
+        "patchSetId": 3
+      },
+      "lineNbr": 656,
+      "author": {
+        "id": 13702
+      },
+      "writtenOn": "2017-12-17T01:45:25Z",
+      "side": 1,
+      "message": "Sorry for confusing.  Because I used wrong cloud.yaml.  Currently, I used correct cloud.yaml(Plz check my comment above) and worked with k8s v1.9.0 :)",
+      "parentUuid": "df87a7cf_9eb3d54d",
+      "range": {
+        "startLine": 656,
+        "startChar": 0,
+        "endLine": 656,
+        "endChar": 117
+      },
+      "revId": "29e4b00e784213336add5397689433c8886ae7f6",
+      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
+      "unresolved": false
     }
   ]
 }
\ No newline at end of file