Update patch set 8

Patch Set 8:

(5 comments)

Patch-set: 8
Reviewer: Gerrit User 7769 <7769@4a232e18-c5a9-48ee-94c0-e04e7cca6543>
Label: Verified=0

883046b1cfed40595628116cb1cec4867c210c9e

@@ -1,5 +1,56 @@
 {
   "comments": [
+    {
+      "key": {
+        "uuid": "5a74a57a_8f8fc9cb",
+        "filename": "helm/kolla-kubernetes/charts/openvswitch/charts/openvswitch-ovsdb/values.yaml",
+        "patchSetId": 8
+      },
+      "lineNbr": 1,
+      "author": {
+        "id": 7769
+      },
+      "writtenOn": "2016-11-29T17:44:29Z",
+      "side": 1,
+      "message": "The global variables defined here need to be considered carefully. In my mind obviously the only global variables defined here should be those needed by other charts.  I would define those as service ports only as the operator of this individual chart should be able to define those, and combining those ports with a separate cross-chart globally defined FQDN (we recommend through _common.tpl) you can build an endpoint to any service, from any chart.\n\nHaving worked on the cookbook-openstack-* stuff for so long, being able to easily craft endpoints for any service in a light weight manner (e.g. not having to talk to keystone) is important.",
+      "revId": "883046b1cfed40595628116cb1cec4867c210c9e",
+      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
+      "unresolved": false
+    },
+    {
+      "key": {
+        "uuid": "5a74a57a_0f865913",
+        "filename": "helm/kolla-kubernetes/charts/openvswitch/charts/openvswitch-ovsdb/values.yaml",
+        "patchSetId": 8
+      },
+      "lineNbr": 6,
+      "author": {
+        "id": 7769
+      },
+      "writtenOn": "2016-11-29T17:44:29Z",
+      "side": 1,
+      "message": "This will set the tone for all other values. Since there are no current plans to override these as globals, we have found that providing some namespace organization is beneficial, e.g.\n\nlabels:\n  selector_key: ..\n\nI\u0027m fairly confident that globals will support depth at some point anyways as a huge flat namespace is simply unwieldy.",
+      "revId": "883046b1cfed40595628116cb1cec4867c210c9e",
+      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
+      "unresolved": false
+    },
+    {
+      "key": {
+        "uuid": "5a74a57a_0f71f9e0",
+        "filename": "helm/kolla-kubernetes/charts/openvswitch/charts/openvswitch-vswitchd/templates/openvswitch-vswitchd-daemonset.yaml",
+        "patchSetId": 8
+      },
+      "lineNbr": 2,
+      "author": {
+        "id": 7769
+      },
+      "writtenOn": "2016-11-29T17:44:29Z",
+      "side": 1,
+      "message": "I don\u0027t have an alternative at my finger tips but this is a bit unreadable.",
+      "revId": "883046b1cfed40595628116cb1cec4867c210c9e",
+      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
+      "unresolved": false
+    },
     {
       "key": {
         "uuid": "5a74a57a_583da68d",
@@ -16,6 +67,41 @@
       "revId": "883046b1cfed40595628116cb1cec4867c210c9e",
       "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
       "unresolved": false
+    },
+    {
+      "key": {
+        "uuid": "5a74a57a_2f24f5c4",
+        "filename": "helm/kolla-kubernetes/templates/_helpers.tpl",
+        "patchSetId": 8
+      },
+      "lineNbr": 24,
+      "author": {
+        "id": 7769
+      },
+      "writtenOn": "2016-11-29T17:44:29Z",
+      "side": 1,
+      "message": "It seems that in addition to common_volumes, etc there are likely also common_envs.",
+      "parentUuid": "5a74a57a_583da68d",
+      "revId": "883046b1cfed40595628116cb1cec4867c210c9e",
+      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
+      "unresolved": false
+    },
+    {
+      "key": {
+        "uuid": "5a74a57a_0aa9e7df",
+        "filename": "helm/kolla-kubernetes/values.yaml",
+        "patchSetId": 8
+      },
+      "lineNbr": 1,
+      "author": {
+        "id": 7769
+      },
+      "writtenOn": "2016-11-29T17:44:29Z",
+      "side": 1,
+      "message": "As discussed in #kolla-kubernetes unless the idea is to require passing this in as --values\u003d... to subcharts, the existence of this parent chart and these global items requires installing subcharts through the parent chart.  One big giant openstack helm deploy.  I personally would like to maintain the ability to install individual subcharts (and lifecycle manage them).  The parent chart is a developers convenience in my mind.",
+      "revId": "883046b1cfed40595628116cb1cec4867c210c9e",
+      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
+      "unresolved": false
     }
   ]
 }