From de54f19bbfe4c7117f604362e7aeaa572ff7344c Mon Sep 17 00:00:00 2001
From: Gerrit User 22368 <22368@4a232e18-c5a9-48ee-94c0-e04e7cca6543>
Date: Thu, 11 May 2017 23:36:49 +0000
Subject: [PATCH] Update patch set 1

Patch Set 1:

(42 comments)

Thanks for the comments, incorporated many changes in the next revision (incoming).

Patch-set: 1
Label: Verified=0
---
 7e4f2b51756616df6ed892869bcdc1532f0eb802 | 936 +++++++++++++++++++++++
 1 file changed, 936 insertions(+)

diff --git a/7e4f2b51756616df6ed892869bcdc1532f0eb802 b/7e4f2b51756616df6ed892869bcdc1532f0eb802
index 20d283ee8..9daa24690 100644
--- a/7e4f2b51756616df6ed892869bcdc1532f0eb802
+++ b/7e4f2b51756616df6ed892869bcdc1532f0eb802
@@ -17,6 +17,24 @@
       "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
       "unresolved": false
     },
+    {
+      "key": {
+        "uuid": "3f044301_54c6899c",
+        "filename": "/COMMIT_MSG",
+        "patchSetId": 1
+      },
+      "lineNbr": 10,
+      "author": {
+        "id": 22368
+      },
+      "writtenOn": "2017-05-11T23:36:49Z",
+      "side": 1,
+      "message": "Done",
+      "parentUuid": "5ff73747_b2eb1376",
+      "revId": "7e4f2b51756616df6ed892869bcdc1532f0eb802",
+      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
+      "unresolved": false
+    },
     {
       "key": {
         "uuid": "5ff73747_6b923259",
@@ -51,6 +69,24 @@
       "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
       "unresolved": false
     },
+    {
+      "key": {
+        "uuid": "3f044301_14c0017b",
+        "filename": "tools/userguide_playbook/roles/k8s-all/tasks/main.yml",
+        "patchSetId": 1
+      },
+      "lineNbr": 17,
+      "author": {
+        "id": 22368
+      },
+      "writtenOn": "2017-05-11T23:36:49Z",
+      "side": 1,
+      "message": "there is so little I dont see need for separate file but I have added centos and when..family condition",
+      "parentUuid": "5ff73747_cbb4a6f4",
+      "revId": "7e4f2b51756616df6ed892869bcdc1532f0eb802",
+      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
+      "unresolved": false
+    },
     {
       "key": {
         "uuid": "5ff73747_77e206d7",
@@ -74,6 +110,30 @@
       "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
       "unresolved": false
     },
+    {
+      "key": {
+        "uuid": "3f044301_7444e51b",
+        "filename": "tools/userguide_playbook/roles/k8s-all/tasks/main.yml",
+        "patchSetId": 1
+      },
+      "lineNbr": 58,
+      "author": {
+        "id": 22368
+      },
+      "writtenOn": "2017-05-11T23:36:49Z",
+      "side": 1,
+      "message": "Left this in since its needed on ubuntu. Is there any consequence to running it on centos also? Seems to be working...",
+      "parentUuid": "5ff73747_77e206d7",
+      "range": {
+        "startLine": 58,
+        "startChar": 0,
+        "endLine": 58,
+        "endChar": 41
+      },
+      "revId": "7e4f2b51756616df6ed892869bcdc1532f0eb802",
+      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
+      "unresolved": false
+    },
     {
       "key": {
         "uuid": "5ff73747_72010b38",
@@ -97,6 +157,30 @@
       "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
       "unresolved": false
     },
+    {
+      "key": {
+        "uuid": "3f044301_34465d23",
+        "filename": "tools/userguide_playbook/roles/k8s-all/tasks/main.yml",
+        "patchSetId": 1
+      },
+      "lineNbr": 69,
+      "author": {
+        "id": 22368
+      },
+      "writtenOn": "2017-05-11T23:36:49Z",
+      "side": 1,
+      "message": "Done",
+      "parentUuid": "5ff73747_72010b38",
+      "range": {
+        "startLine": 69,
+        "startChar": 14,
+        "endLine": 69,
+        "endChar": 23
+      },
+      "revId": "7e4f2b51756616df6ed892869bcdc1532f0eb802",
+      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
+      "unresolved": false
+    },
     {
       "key": {
         "uuid": "5ff73747_eba642c1",
@@ -114,6 +198,24 @@
       "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
       "unresolved": false
     },
+    {
+      "key": {
+        "uuid": "3f044301_945ad1f0",
+        "filename": "tools/userguide_playbook/roles/k8s-all/tasks/main.yml",
+        "patchSetId": 1
+      },
+      "lineNbr": 73,
+      "author": {
+        "id": 22368
+      },
+      "writtenOn": "2017-05-11T23:36:49Z",
+      "side": 1,
+      "message": "Switched to non privileged user at playbook level",
+      "parentUuid": "5ff73747_eba642c1",
+      "revId": "7e4f2b51756616df6ed892869bcdc1532f0eb802",
+      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
+      "unresolved": false
+    },
     {
       "key": {
         "uuid": "5ff73747_52fccf3c",
@@ -137,6 +239,30 @@
       "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
       "unresolved": false
     },
+    {
+      "key": {
+        "uuid": "3f044301_346f7d93",
+        "filename": "tools/userguide_playbook/roles/k8s-join/tasks/main.yml",
+        "patchSetId": 1
+      },
+      "lineNbr": 6,
+      "author": {
+        "id": 22368
+      },
+      "writtenOn": "2017-05-11T23:36:49Z",
+      "side": 1,
+      "message": "Removed",
+      "parentUuid": "5ff73747_52fccf3c",
+      "range": {
+        "startLine": 6,
+        "startChar": 0,
+        "endLine": 6,
+        "endChar": 76
+      },
+      "revId": "7e4f2b51756616df6ed892869bcdc1532f0eb802",
+      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
+      "unresolved": false
+    },
     {
       "key": {
         "uuid": "5ff73747_32f7035c",
@@ -184,6 +310,30 @@
       "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
       "unresolved": false
     },
+    {
+      "key": {
+        "uuid": "3f044301_b4082dd9",
+        "filename": "tools/userguide_playbook/roles/k8s-master/tasks/main.yml",
+        "patchSetId": 1
+      },
+      "lineNbr": 5,
+      "author": {
+        "id": 22368
+      },
+      "writtenOn": "2017-05-11T23:36:49Z",
+      "side": 1,
+      "message": "All the things have now been converted to vars",
+      "parentUuid": "5ff73747_abe83ab2",
+      "range": {
+        "startLine": 5,
+        "startChar": 43,
+        "endLine": 5,
+        "endChar": 51
+      },
+      "revId": "7e4f2b51756616df6ed892869bcdc1532f0eb802",
+      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
+      "unresolved": false
+    },
     {
       "key": {
         "uuid": "5ff73747_cbe5c6dd",
@@ -201,6 +351,24 @@
       "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
       "unresolved": false
     },
+    {
+      "key": {
+        "uuid": "3f044301_940f71e0",
+        "filename": "tools/userguide_playbook/roles/k8s-master/tasks/main.yml",
+        "patchSetId": 1
+      },
+      "lineNbr": 12,
+      "author": {
+        "id": 22368
+      },
+      "writtenOn": "2017-05-11T23:36:49Z",
+      "side": 1,
+      "message": "Done",
+      "parentUuid": "5ff73747_cbe5c6dd",
+      "revId": "7e4f2b51756616df6ed892869bcdc1532f0eb802",
+      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
+      "unresolved": false
+    },
     {
       "key": {
         "uuid": "5ff73747_12988719",
@@ -224,6 +392,30 @@
       "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
       "unresolved": false
     },
+    {
+      "key": {
+        "uuid": "3f044301_7412a50b",
+        "filename": "tools/userguide_playbook/roles/k8s-master/tasks/main.yml",
+        "patchSetId": 1
+      },
+      "lineNbr": 27,
+      "author": {
+        "id": 22368
+      },
+      "writtenOn": "2017-05-11T23:36:49Z",
+      "side": 1,
+      "message": "Done",
+      "parentUuid": "5ff73747_12988719",
+      "range": {
+        "startLine": 25,
+        "startChar": 0,
+        "endLine": 27,
+        "endChar": 51
+      },
+      "revId": "7e4f2b51756616df6ed892869bcdc1532f0eb802",
+      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
+      "unresolved": false
+    },
     {
       "key": {
         "uuid": "5ff73747_b2a0b343",
@@ -264,6 +456,30 @@
       "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
       "unresolved": false
     },
+    {
+      "key": {
+        "uuid": "3f044301_34f41dcf",
+        "filename": "tools/userguide_playbook/roles/k8s-sdn/tasks/main.yml",
+        "patchSetId": 1
+      },
+      "lineNbr": 13,
+      "author": {
+        "id": 22368
+      },
+      "writtenOn": "2017-05-11T23:36:49Z",
+      "side": 1,
+      "message": "Done",
+      "parentUuid": "5ff73747_f29abb11",
+      "range": {
+        "startLine": 13,
+        "startChar": 14,
+        "endLine": 13,
+        "endChar": 22
+      },
+      "revId": "7e4f2b51756616df6ed892869bcdc1532f0eb802",
+      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
+      "unresolved": false
+    },
     {
       "key": {
         "uuid": "5ff73747_d29d7f0a",
@@ -287,6 +503,30 @@
       "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
       "unresolved": false
     },
+    {
+      "key": {
+        "uuid": "3f044301_f4fd95b1",
+        "filename": "tools/userguide_playbook/roles/k8s-sdn/tasks/main.yml",
+        "patchSetId": 1
+      },
+      "lineNbr": 19,
+      "author": {
+        "id": 22368
+      },
+      "writtenOn": "2017-05-11T23:36:49Z",
+      "side": 1,
+      "message": "Done",
+      "parentUuid": "5ff73747_d29d7f0a",
+      "range": {
+        "startLine": 19,
+        "startChar": 15,
+        "endLine": 19,
+        "endChar": 24
+      },
+      "revId": "7e4f2b51756616df6ed892869bcdc1532f0eb802",
+      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
+      "unresolved": false
+    },
     {
       "key": {
         "uuid": "5ff73747_6bceb25a",
@@ -304,6 +544,24 @@
       "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
       "unresolved": false
     },
+    {
+      "key": {
+        "uuid": "3f044301_b4314da5",
+        "filename": "tools/userguide_playbook/roles/k8s-sdn/tasks/main.yml",
+        "patchSetId": 1
+      },
+      "lineNbr": 23,
+      "author": {
+        "id": 22368
+      },
+      "writtenOn": "2017-05-11T23:36:49Z",
+      "side": 1,
+      "message": "Done",
+      "parentUuid": "5ff73747_6bceb25a",
+      "revId": "7e4f2b51756616df6ed892869bcdc1532f0eb802",
+      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
+      "unresolved": false
+    },
     {
       "key": {
         "uuid": "5ff73747_52916ff0",
@@ -327,6 +585,30 @@
       "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
       "unresolved": false
     },
+    {
+      "key": {
+        "uuid": "3f044301_94289134",
+        "filename": "tools/userguide_playbook/roles/k8s-sdn/tasks/main.yml",
+        "patchSetId": 1
+      },
+      "lineNbr": 30,
+      "author": {
+        "id": 22368
+      },
+      "writtenOn": "2017-05-11T23:36:49Z",
+      "side": 1,
+      "message": "Done",
+      "parentUuid": "5ff73747_52916ff0",
+      "range": {
+        "startLine": 27,
+        "startChar": 0,
+        "endLine": 30,
+        "endChar": 28
+      },
+      "revId": "7e4f2b51756616df6ed892869bcdc1532f0eb802",
+      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
+      "unresolved": false
+    },
     {
       "key": {
         "uuid": "5ff73747_2b1b0aca",
@@ -344,6 +626,24 @@
       "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
       "unresolved": false
     },
+    {
+      "key": {
+        "uuid": "3f044301_d4d3b937",
+        "filename": "tools/userguide_playbook/roles/kolla-controller/tasks/main.yml",
+        "patchSetId": 1
+      },
+      "lineNbr": 2,
+      "author": {
+        "id": 22368
+      },
+      "writtenOn": "2017-05-11T23:36:49Z",
+      "side": 1,
+      "message": "I am up for some restructuring but since this is following deployment guide I dont want to make it harder to follow. Im going to push next rev and we can discuss further organization.",
+      "parentUuid": "5ff73747_2b1b0aca",
+      "revId": "7e4f2b51756616df6ed892869bcdc1532f0eb802",
+      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
+      "unresolved": false
+    },
     {
       "key": {
         "uuid": "5ff73747_b2367350",
@@ -477,6 +777,30 @@
       "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
       "unresolved": false
     },
+    {
+      "key": {
+        "uuid": "3f044301_34e2dd02",
+        "filename": "tools/userguide_playbook/roles/kolla-controller/tasks/main.yml",
+        "patchSetId": 1
+      },
+      "lineNbr": 87,
+      "author": {
+        "id": 22368
+      },
+      "writtenOn": "2017-05-11T23:36:49Z",
+      "side": 1,
+      "message": "ubuntu sudo user. now playbooks use un-privileged user",
+      "parentUuid": "5ff73747_f2199bd6",
+      "range": {
+        "startLine": 87,
+        "startChar": 11,
+        "endLine": 87,
+        "endChar": 17
+      },
+      "revId": "7e4f2b51756616df6ed892869bcdc1532f0eb802",
+      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
+      "unresolved": false
+    },
     {
       "key": {
         "uuid": "5ff73747_d20c5f95",
@@ -500,6 +824,30 @@
       "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
       "unresolved": false
     },
+    {
+      "key": {
+        "uuid": "3f044301_542569c1",
+        "filename": "tools/userguide_playbook/roles/kolla-controller/tasks/main.yml",
+        "patchSetId": 1
+      },
+      "lineNbr": 97,
+      "author": {
+        "id": 22368
+      },
+      "writtenOn": "2017-05-11T23:36:49Z",
+      "side": 1,
+      "message": "Done",
+      "parentUuid": "5ff73747_d20c5f95",
+      "range": {
+        "startLine": 93,
+        "startChar": 0,
+        "endLine": 97,
+        "endChar": 6
+      },
+      "revId": "7e4f2b51756616df6ed892869bcdc1532f0eb802",
+      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
+      "unresolved": false
+    },
     {
       "key": {
         "uuid": "5ff73747_b20f9386",
@@ -523,6 +871,30 @@
       "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
       "unresolved": false
     },
+    {
+      "key": {
+        "uuid": "3f044301_34209db0",
+        "filename": "tools/userguide_playbook/roles/kolla-controller/tasks/main.yml",
+        "patchSetId": 1
+      },
+      "lineNbr": 98,
+      "author": {
+        "id": 22368
+      },
+      "writtenOn": "2017-05-11T23:36:49Z",
+      "side": 1,
+      "message": "Done",
+      "parentUuid": "5ff73747_b20f9386",
+      "range": {
+        "startLine": 98,
+        "startChar": 15,
+        "endLine": 98,
+        "endChar": 16
+      },
+      "revId": "7e4f2b51756616df6ed892869bcdc1532f0eb802",
+      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
+      "unresolved": false
+    },
     {
       "key": {
         "uuid": "5ff73747_72258b08",
@@ -592,6 +964,30 @@
       "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
       "unresolved": false
     },
+    {
+      "key": {
+        "uuid": "3f044301_2f360ae8",
+        "filename": "tools/userguide_playbook/roles/kolla-controller/tasks/main.yml",
+        "patchSetId": 1
+      },
+      "lineNbr": 116,
+      "author": {
+        "id": 22368
+      },
+      "writtenOn": "2017-05-11T23:36:49Z",
+      "side": 1,
+      "message": "Thanks!",
+      "parentUuid": "5ff73747_321b83ca",
+      "range": {
+        "startLine": 116,
+        "startChar": 11,
+        "endLine": 116,
+        "endChar": 23
+      },
+      "revId": "7e4f2b51756616df6ed892869bcdc1532f0eb802",
+      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
+      "unresolved": false
+    },
     {
       "key": {
         "uuid": "5ff73747_127c07ea",
@@ -615,6 +1011,30 @@
       "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
       "unresolved": false
     },
+    {
+      "key": {
+        "uuid": "3f044301_14f121ce",
+        "filename": "tools/userguide_playbook/roles/kolla-controller/tasks/main.yml",
+        "patchSetId": 1
+      },
+      "lineNbr": 128,
+      "author": {
+        "id": 22368
+      },
+      "writtenOn": "2017-05-11T23:36:49Z",
+      "side": 1,
+      "message": "I think just breaking the two label ops out into their own roles would be good. then can use from playbook level to specify. Or could just use vars.",
+      "parentUuid": "5ff73747_127c07ea",
+      "range": {
+        "startLine": 125,
+        "startChar": 0,
+        "endLine": 128,
+        "endChar": 55
+      },
+      "revId": "7e4f2b51756616df6ed892869bcdc1532f0eb802",
+      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
+      "unresolved": false
+    },
     {
       "key": {
         "uuid": "5ff73747_f27e3be2",
@@ -638,6 +1058,30 @@
       "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
       "unresolved": false
     },
+    {
+      "key": {
+        "uuid": "3f044301_cf50c60d",
+        "filename": "tools/userguide_playbook/roles/kolla-controller/tasks/main.yml",
+        "patchSetId": 1
+      },
+      "lineNbr": 135,
+      "author": {
+        "id": 22368
+      },
+      "writtenOn": "2017-05-11T23:36:49Z",
+      "side": 1,
+      "message": "switched to ansible_hostname (inventory_hostname broke in some cases anyway)",
+      "parentUuid": "5ff73747_f27e3be2",
+      "range": {
+        "startLine": 130,
+        "startChar": 0,
+        "endLine": 135,
+        "endChar": 21
+      },
+      "revId": "7e4f2b51756616df6ed892869bcdc1532f0eb802",
+      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
+      "unresolved": false
+    },
     {
       "key": {
         "uuid": "5ff73747_b28433d4",
@@ -661,6 +1105,30 @@
       "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
       "unresolved": false
     },
+    {
+      "key": {
+        "uuid": "3f044301_8f5abe27",
+        "filename": "tools/userguide_playbook/roles/kolla-controller/tasks/main.yml",
+        "patchSetId": 1
+      },
+      "lineNbr": 194,
+      "author": {
+        "id": 22368
+      },
+      "writtenOn": "2017-05-11T23:36:49Z",
+      "side": 1,
+      "message": "Done",
+      "parentUuid": "5ff73747_b28433d4",
+      "range": {
+        "startLine": 194,
+        "startChar": 0,
+        "endLine": 194,
+        "endChar": 29
+      },
+      "revId": "7e4f2b51756616df6ed892869bcdc1532f0eb802",
+      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
+      "unresolved": false
+    },
     {
       "key": {
         "uuid": "5ff73747_d281ffc4",
@@ -747,6 +1215,30 @@
       "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
       "unresolved": false
     },
+    {
+      "key": {
+        "uuid": "3f044301_94b651fa",
+        "filename": "tools/userguide_playbook/roles/kolla-controller/tasks/main.yml",
+        "patchSetId": 1
+      },
+      "lineNbr": 220,
+      "author": {
+        "id": 22368
+      },
+      "writtenOn": "2017-05-11T23:36:49Z",
+      "side": 1,
+      "message": "Had some really weird ansible privilege behaviors (probably my lack of understanding) but have it sorted out in latest revision.",
+      "parentUuid": "5ff73747_5275eff8",
+      "range": {
+        "startLine": 220,
+        "startChar": 0,
+        "endLine": 220,
+        "endChar": 14
+      },
+      "revId": "7e4f2b51756616df6ed892869bcdc1532f0eb802",
+      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
+      "unresolved": false
+    },
     {
       "key": {
         "uuid": "5ff73747_32702308",
@@ -787,6 +1279,24 @@
       "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
       "unresolved": false
     },
+    {
+      "key": {
+        "uuid": "3f044301_6d295e88",
+        "filename": "tools/userguide_playbook/roles/kolla-controller/tasks/main.yml",
+        "patchSetId": 1
+      },
+      "lineNbr": 250,
+      "author": {
+        "id": 22368
+      },
+      "writtenOn": "2017-05-11T23:36:49Z",
+      "side": 1,
+      "message": "I broke out into a task but we can review and further refactor into playbook after I post next rev.",
+      "parentUuid": "5ff73747_12652746",
+      "revId": "7e4f2b51756616df6ed892869bcdc1532f0eb802",
+      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
+      "unresolved": false
+    },
     {
       "key": {
         "uuid": "5ff73747_f2675b4c",
@@ -810,6 +1320,30 @@
       "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
       "unresolved": false
     },
+    {
+      "key": {
+        "uuid": "3f044301_74b985e7",
+        "filename": "tools/userguide_playbook/roles/kolla-controller/tasks/main.yml",
+        "patchSetId": 1
+      },
+      "lineNbr": 257,
+      "author": {
+        "id": 22368
+      },
+      "writtenOn": "2017-05-11T23:36:49Z",
+      "side": 1,
+      "message": "Done",
+      "parentUuid": "5ff73747_f2675b4c",
+      "range": {
+        "startLine": 255,
+        "startChar": 0,
+        "endLine": 257,
+        "endChar": 38
+      },
+      "revId": "7e4f2b51756616df6ed892869bcdc1532f0eb802",
+      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
+      "unresolved": false
+    },
     {
       "key": {
         "uuid": "5ff73747_d25a1f81",
@@ -827,6 +1361,24 @@
       "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
       "unresolved": false
     },
+    {
+      "key": {
+        "uuid": "3f044301_34cbfd72",
+        "filename": "tools/userguide_playbook/roles/kolla-controller/tasks/main.yml",
+        "patchSetId": 1
+      },
+      "lineNbr": 268,
+      "author": {
+        "id": 22368
+      },
+      "writtenOn": "2017-05-11T23:36:49Z",
+      "side": 1,
+      "message": "i will have to get more information to correct the external vip which I will turn into var.",
+      "parentUuid": "5ff73747_d25a1f81",
+      "revId": "7e4f2b51756616df6ed892869bcdc1532f0eb802",
+      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
+      "unresolved": false
+    },
     {
       "key": {
         "uuid": "5ff73747_b25d537a",
@@ -850,6 +1402,30 @@
       "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
       "unresolved": false
     },
+    {
+      "key": {
+        "uuid": "3f044301_f4c47561",
+        "filename": "tools/userguide_playbook/roles/kolla-controller/tasks/main.yml",
+        "patchSetId": 1
+      },
+      "lineNbr": 329,
+      "author": {
+        "id": 22368
+      },
+      "writtenOn": "2017-05-11T23:36:49Z",
+      "side": 1,
+      "message": "This is covered in group_vars. We can discuss better ways to re-use.",
+      "parentUuid": "5ff73747_b25d537a",
+      "range": {
+        "startLine": 329,
+        "startChar": 0,
+        "endLine": 329,
+        "endChar": 54
+      },
+      "revId": "7e4f2b51756616df6ed892869bcdc1532f0eb802",
+      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
+      "unresolved": false
+    },
     {
       "key": {
         "uuid": "5ff73747_92581788",
@@ -873,6 +1449,30 @@
       "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
       "unresolved": false
     },
+    {
+      "key": {
+        "uuid": "3f044301_d4a179ab",
+        "filename": "tools/userguide_playbook/roles/kolla-controller/tasks/main.yml",
+        "patchSetId": 1
+      },
+      "lineNbr": 331,
+      "author": {
+        "id": 22368
+      },
+      "writtenOn": "2017-05-11T23:36:49Z",
+      "side": 1,
+      "message": "Done",
+      "parentUuid": "5ff73747_92581788",
+      "range": {
+        "startLine": 331,
+        "startChar": 0,
+        "endLine": 331,
+        "endChar": 80
+      },
+      "revId": "7e4f2b51756616df6ed892869bcdc1532f0eb802",
+      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
+      "unresolved": false
+    },
     {
       "key": {
         "uuid": "5ff73747_72534b6c",
@@ -896,6 +1496,30 @@
       "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
       "unresolved": false
     },
+    {
+      "key": {
+        "uuid": "3f044301_b4a4adba",
+        "filename": "tools/userguide_playbook/roles/kolla-controller/tasks/main.yml",
+        "patchSetId": 1
+      },
+      "lineNbr": 338,
+      "author": {
+        "id": 22368
+      },
+      "writtenOn": "2017-05-11T23:36:49Z",
+      "side": 1,
+      "message": "Done",
+      "parentUuid": "5ff73747_72534b6c",
+      "range": {
+        "startLine": 338,
+        "startChar": 0,
+        "endLine": 338,
+        "endChar": 62
+      },
+      "revId": "7e4f2b51756616df6ed892869bcdc1532f0eb802",
+      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
+      "unresolved": false
+    },
     {
       "key": {
         "uuid": "5ff73747_524e0fc1",
@@ -988,6 +1612,30 @@
       "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
       "unresolved": false
     },
+    {
+      "key": {
+        "uuid": "3f044301_9484110e",
+        "filename": "tools/userguide_playbook/roles/kolla-controller/tasks/main.yml",
+        "patchSetId": 1
+      },
+      "lineNbr": 379,
+      "author": {
+        "id": 22368
+      },
+      "writtenOn": "2017-05-11T23:36:49Z",
+      "side": 1,
+      "message": "this is a mixture of service and microservice that cant be combined for use with `with_items`",
+      "parentUuid": "5ff73747_f2ccfb35",
+      "range": {
+        "startLine": 364,
+        "startChar": 0,
+        "endLine": 379,
+        "endChar": 13
+      },
+      "revId": "7e4f2b51756616df6ed892869bcdc1532f0eb802",
+      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
+      "unresolved": false
+    },
     {
       "key": {
         "uuid": "5ff73747_d2cfbf26",
@@ -1011,6 +1659,30 @@
       "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
       "unresolved": false
     },
+    {
+      "key": {
+        "uuid": "3f044301_4faa76d2",
+        "filename": "tools/userguide_playbook/roles/kolla-controller/tasks/main.yml",
+        "patchSetId": 1
+      },
+      "lineNbr": 403,
+      "author": {
+        "id": 22368
+      },
+      "writtenOn": "2017-05-11T23:36:49Z",
+      "side": 1,
+      "message": "i took out this block and everything broke. Lets review after next version.",
+      "parentUuid": "5ff73747_d2cfbf26",
+      "range": {
+        "startLine": 392,
+        "startChar": 0,
+        "endLine": 403,
+        "endChar": 56
+      },
+      "revId": "7e4f2b51756616df6ed892869bcdc1532f0eb802",
+      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
+      "unresolved": false
+    },
     {
       "key": {
         "uuid": "5ff73747_b2d2f3cf",
@@ -1034,6 +1706,30 @@
       "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
       "unresolved": false
     },
+    {
+      "key": {
+        "uuid": "3f044301_0d0bfa23",
+        "filename": "tools/userguide_playbook/roles/kolla-controller/tasks/main.yml",
+        "patchSetId": 1
+      },
+      "lineNbr": 412,
+      "author": {
+        "id": 22368
+      },
+      "writtenOn": "2017-05-11T23:36:49Z",
+      "side": 1,
+      "message": "Done",
+      "parentUuid": "5ff73747_b2d2f3cf",
+      "range": {
+        "startLine": 406,
+        "startChar": 0,
+        "endLine": 412,
+        "endChar": 201
+      },
+      "revId": "7e4f2b51756616df6ed892869bcdc1532f0eb802",
+      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
+      "unresolved": false
+    },
     {
       "key": {
         "uuid": "5ff73747_92ddb7e1",
@@ -1051,6 +1747,24 @@
       "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
       "unresolved": false
     },
+    {
+      "key": {
+        "uuid": "3f044301_547e8919",
+        "filename": "tools/userguide_playbook/roles/kolla-controller/tasks/main.yml",
+        "patchSetId": 1
+      },
+      "lineNbr": 415,
+      "author": {
+        "id": 22368
+      },
+      "writtenOn": "2017-05-11T23:36:49Z",
+      "side": 1,
+      "message": "All pods eventually spin up to running if left alone. Do we need to explicitly wait?",
+      "parentUuid": "5ff73747_92ddb7e1",
+      "revId": "7e4f2b51756616df6ed892869bcdc1532f0eb802",
+      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
+      "unresolved": false
+    },
     {
       "key": {
         "uuid": "5ff73747_72d8ebed",
@@ -1097,6 +1811,30 @@
       "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
       "unresolved": false
     },
+    {
+      "key": {
+        "uuid": "3f044301_8f73deb1",
+        "filename": "tools/userguide_playbook/roles/kolla-controller/tasks/main.yml",
+        "patchSetId": 1
+      },
+      "lineNbr": 426,
+      "author": {
+        "id": 22368
+      },
+      "writtenOn": "2017-05-11T23:36:49Z",
+      "side": 1,
+      "message": "Done",
+      "parentUuid": "5ff73747_52e3afa4",
+      "range": {
+        "startLine": 425,
+        "startChar": 0,
+        "endLine": 426,
+        "endChar": 163
+      },
+      "revId": "7e4f2b51756616df6ed892869bcdc1532f0eb802",
+      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
+      "unresolved": false
+    },
     {
       "key": {
         "uuid": "5ff73747_32dee3d9",
@@ -1120,6 +1858,30 @@
       "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
       "unresolved": false
     },
+    {
+      "key": {
+        "uuid": "3f044301_54a3299f",
+        "filename": "tools/userguide_playbook/roles/kolla-controller/tasks/main.yml",
+        "patchSetId": 1
+      },
+      "lineNbr": 434,
+      "author": {
+        "id": 22368
+      },
+      "writtenOn": "2017-05-11T23:36:49Z",
+      "side": 1,
+      "message": "Can we add to guide? It would be great if this was mostly downstream of guide.",
+      "parentUuid": "5ff73747_32dee3d9",
+      "range": {
+        "startLine": 434,
+        "startChar": 0,
+        "endLine": 434,
+        "endChar": 59
+      },
+      "revId": "7e4f2b51756616df6ed892869bcdc1532f0eb802",
+      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
+      "unresolved": false
+    },
     {
       "key": {
         "uuid": "5ff73747_12f3e775",
@@ -1143,6 +1905,30 @@
       "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
       "unresolved": false
     },
+    {
+      "key": {
+        "uuid": "3f044301_14ada187",
+        "filename": "tools/userguide_playbook/roles/kolla-controller/tasks/main.yml",
+        "patchSetId": 1
+      },
+      "lineNbr": 435,
+      "author": {
+        "id": 22368
+      },
+      "writtenOn": "2017-05-11T23:36:49Z",
+      "side": 1,
+      "message": "Done",
+      "parentUuid": "5ff73747_12f3e775",
+      "range": {
+        "startLine": 435,
+        "startChar": 0,
+        "endLine": 435,
+        "endChar": 26
+      },
+      "revId": "7e4f2b51756616df6ed892869bcdc1532f0eb802",
+      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
+      "unresolved": false
+    },
     {
       "key": {
         "uuid": "5ff73747_d2e8df7c",
@@ -1166,6 +1952,30 @@
       "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
       "unresolved": false
     },
+    {
+      "key": {
+        "uuid": "3f044301_f4a7d5a6",
+        "filename": "tools/userguide_playbook/roles/kolla-controller/tasks/main.yml",
+        "patchSetId": 1
+      },
+      "lineNbr": 440,
+      "author": {
+        "id": 22368
+      },
+      "writtenOn": "2017-05-11T23:36:49Z",
+      "side": 1,
+      "message": "Agree. Will get to it.",
+      "parentUuid": "5ff73747_d2e8df7c",
+      "range": {
+        "startLine": 437,
+        "startChar": 0,
+        "endLine": 440,
+        "endChar": 39
+      },
+      "revId": "7e4f2b51756616df6ed892869bcdc1532f0eb802",
+      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
+      "unresolved": false
+    },
     {
       "key": {
         "uuid": "5ff73747_f2f51b58",
@@ -1189,6 +1999,30 @@
       "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
       "unresolved": false
     },
+    {
+      "key": {
+        "uuid": "3f044301_d4b859c9",
+        "filename": "tools/userguide_playbook/roles/kolla-controller/tasks/main.yml",
+        "patchSetId": 1
+      },
+      "lineNbr": 446,
+      "author": {
+        "id": 22368
+      },
+      "writtenOn": "2017-05-11T23:36:49Z",
+      "side": 1,
+      "message": "Maybe we should put into some tests role or something?",
+      "parentUuid": "5ff73747_f2f51b58",
+      "range": {
+        "startLine": 442,
+        "startChar": 0,
+        "endLine": 446,
+        "endChar": 112
+      },
+      "revId": "7e4f2b51756616df6ed892869bcdc1532f0eb802",
+      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
+      "unresolved": false
+    },
     {
       "key": {
         "uuid": "5ff73747_328ca3d5",
@@ -1206,6 +2040,24 @@
       "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
       "unresolved": false
     },
+    {
+      "key": {
+        "uuid": "3f044301_f4d595e6",
+        "filename": "tools/userguide_playbook/roles/kolla-controller/templates/cloud.yaml",
+        "patchSetId": 1
+      },
+      "lineNbr": 4,
+      "author": {
+        "id": 22368
+      },
+      "writtenOn": "2017-05-11T23:36:49Z",
+      "side": 1,
+      "message": "Im not sure that it should. Its not touched by jinja but used by ansible and helm.",
+      "parentUuid": "5ff73747_328ca3d5",
+      "revId": "7e4f2b51756616df6ed892869bcdc1532f0eb802",
+      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
+      "unresolved": false
+    },
     {
       "key": {
         "uuid": "5ff73747_8b6fbe29",
@@ -1223,6 +2075,24 @@
       "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
       "unresolved": false
     },
+    {
+      "key": {
+        "uuid": "3f044301_34c77d48",
+        "filename": "tools/userguide_playbook/roles/kolla-controller/templates/cloud.yaml",
+        "patchSetId": 1
+      },
+      "lineNbr": 6,
+      "author": {
+        "id": 22368
+      },
+      "writtenOn": "2017-05-11T23:36:49Z",
+      "side": 1,
+      "message": "Done",
+      "parentUuid": "5ff73747_8b6fbe29",
+      "revId": "7e4f2b51756616df6ed892869bcdc1532f0eb802",
+      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
+      "unresolved": false
+    },
     {
       "key": {
         "uuid": "5ff73747_4b7536f9",
@@ -1240,6 +2110,24 @@
       "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
       "unresolved": false
     },
+    {
+      "key": {
+        "uuid": "3f044301_54cc4969",
+        "filename": "tools/userguide_playbook/roles/kolla-controller/templates/cloud.yaml",
+        "patchSetId": 1
+      },
+      "lineNbr": 14,
+      "author": {
+        "id": 22368
+      },
+      "writtenOn": "2017-05-11T23:36:49Z",
+      "side": 1,
+      "message": "Done",
+      "parentUuid": "5ff73747_4b7536f9",
+      "revId": "7e4f2b51756616df6ed892869bcdc1532f0eb802",
+      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
+      "unresolved": false
+    },
     {
       "key": {
         "uuid": "5ff73747_2b70aa07",
@@ -1297,6 +2185,30 @@
       "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
       "unresolved": false
     },
+    {
+      "key": {
+        "uuid": "3f044301_b42eedf7",
+        "filename": "tools/userguide_playbook/roles/kolla-controller/templates/globals_config.j2",
+        "patchSetId": 1
+      },
+      "lineNbr": 1,
+      "author": {
+        "id": 22368
+      },
+      "writtenOn": "2017-05-11T23:36:49Z",
+      "side": 1,
+      "message": "Done",
+      "parentUuid": "5ff73747_12c1a7e5",
+      "range": {
+        "startLine": 1,
+        "startChar": 15,
+        "endLine": 1,
+        "endChar": 21
+      },
+      "revId": "7e4f2b51756616df6ed892869bcdc1532f0eb802",
+      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
+      "unresolved": false
+    },
     {
       "key": {
         "uuid": "5ff73747_f773b6e5",
@@ -1342,6 +2254,30 @@
       "revId": "7e4f2b51756616df6ed892869bcdc1532f0eb802",
       "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
       "unresolved": false
+    },
+    {
+      "key": {
+        "uuid": "3f044301_b4ca6d17",
+        "filename": "tools/userguide_playbook/sample-inventory",
+        "patchSetId": 1
+      },
+      "lineNbr": 10,
+      "author": {
+        "id": 22368
+      },
+      "writtenOn": "2017-05-11T23:36:49Z",
+      "side": 1,
+      "message": "I have terraform generating this file which might by accpeptable. Vagrant will also generate an inventory file (but all of kk8s is too much for my MBP).",
+      "parentUuid": "5ff73747_72afcb29",
+      "range": {
+        "startLine": 8,
+        "startChar": 0,
+        "endLine": 10,
+        "endChar": 41
+      },
+      "revId": "7e4f2b51756616df6ed892869bcdc1532f0eb802",
+      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
+      "unresolved": false
     }
   ]
 }
\ No newline at end of file