Update patch set 7
Patch Set 7: Code-Review-1 (9 comments) Today, I've tested PS7's document with AIO environment. It worked correctly with kubectl is v1.9.2 :-) I just checked to deploy VM instance. There is small nits. Patch-set: 7 Label: Code-Review=-1
This commit is contained in:
Gerrit User 13702
Gerrit Code Review
parent
16140c5258
commit
e7bc11c2aa
|
|
@ -0,0 +1,193 @@
|
|||
{
|
||||
"comments": [
|
||||
{
|
||||
"key": {
|
||||
"uuid": "7f96bb07_ab2015b2",
|
||||
"filename": "doc/source/deployment-guide.rst",
|
||||
"patchSetId": 7
|
||||
},
|
||||
"lineNbr": 54,
|
||||
"author": {
|
||||
"id": 13702
|
||||
},
|
||||
"writtenOn": "2018-01-21T13:34:47Z",
|
||||
"side": 1,
|
||||
"message": "How about updating the latest version? Following version is installed in Ubuntu16.04:\n\n- docker.io/xenial-updates,now 1.13.1-0ubuntu1~16.04.2\n- kubeadm/kubernetes-xenial,now 1.9.2-00\n- kubectl/kubernetes-xenial,now 1.9.2-00\n- kubelet/kubernetes-xenial,now 1.9.2-00\n- kubernetes-cni/kubernetes-xenial,now 0.6.0-00\n- helm version\n Client: \u0026version.Version{SemVer:\"v2.7.2\", GitCommit:\"8478fb4fc723885b155c924d1c8c410b7a9444e6\", GitTreeState:\"clean\"}\nServer: \u0026version.Version{SemVer:\"v2.7.2\",\nGitCommit:\"8478fb4fc723885b155c924d1c8c410b7a9444e6\", GitTreeState:\"clean\"}",
|
||||
"range": {
|
||||
"startLine": 49,
|
||||
"startChar": 0,
|
||||
"endLine": 54,
|
||||
"endChar": 27
|
||||
},
|
||||
"revId": "fbe4ae326b59eb9c3b21429cff02ca1d55eeeeb6",
|
||||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
|
||||
"unresolved": false
|
||||
},
|
||||
{
|
||||
"key": {
|
||||
"uuid": "7f96bb07_b60e3c30",
|
||||
"filename": "doc/source/deployment-guide.rst",
|
||||
"patchSetId": 7
|
||||
},
|
||||
"lineNbr": 212,
|
||||
"author": {
|
||||
"id": 13702
|
||||
},
|
||||
"writtenOn": "2018-01-21T13:34:47Z",
|
||||
"side": 1,
|
||||
"message": "I definitely encountered following error message( written in comment @229) in Ubuntu 16.04. I think it\u0027s better to add --ignore-preflight-errors\u003dall option to avoid an error.",
|
||||
"range": {
|
||||
"startLine": 212,
|
||||
"startChar": 4,
|
||||
"endLine": 212,
|
||||
"endChar": 79
|
||||
},
|
||||
"revId": "fbe4ae326b59eb9c3b21429cff02ca1d55eeeeb6",
|
||||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
|
||||
"unresolved": false
|
||||
},
|
||||
{
|
||||
"key": {
|
||||
"uuid": "7f96bb07_4b063123",
|
||||
"filename": "doc/source/deployment-guide.rst",
|
||||
"patchSetId": 7
|
||||
},
|
||||
"lineNbr": 229,
|
||||
"author": {
|
||||
"id": 13702
|
||||
},
|
||||
"writtenOn": "2018-01-21T13:34:47Z",
|
||||
"side": 1,
|
||||
"message": "This is old. Following messages are the latest:\n\n[init] Using Kubernetes version: v1.9.2\n[init] Using Authorization modes: [Node RBAC]\n[preflight] Running pre-flight checks.\n [WARNING FileExisting-crictl]: crictl not found in system path\n[preflight] Some fatal errors occurred:\n [ERROR Swap]: running with swap on is not supported. Please disable swap\n[preflight] If you know what you are doing, you can make a check non-fatal with `--ignore-preflight-errors\u003d...`",
|
||||
"range": {
|
||||
"startLine": 227,
|
||||
"startChar": 0,
|
||||
"endLine": 229,
|
||||
"endChar": 8
|
||||
},
|
||||
"revId": "fbe4ae326b59eb9c3b21429cff02ca1d55eeeeb6",
|
||||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
|
||||
"unresolved": false
|
||||
},
|
||||
{
|
||||
"key": {
|
||||
"uuid": "7f96bb07_f625a4ac",
|
||||
"filename": "doc/source/deployment-guide.rst",
|
||||
"patchSetId": 7
|
||||
},
|
||||
"lineNbr": 242,
|
||||
"author": {
|
||||
"id": 13702
|
||||
},
|
||||
"writtenOn": "2018-01-21T13:34:47Z",
|
||||
"side": 1,
|
||||
"message": "A style is broken due to less indent. In addition, `--` is built a single hyphen(\u0027-\u0027)",
|
||||
"range": {
|
||||
"startLine": 241,
|
||||
"startChar": 0,
|
||||
"endLine": 242,
|
||||
"endChar": 65
|
||||
},
|
||||
"revId": "fbe4ae326b59eb9c3b21429cff02ca1d55eeeeb6",
|
||||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
|
||||
"unresolved": false
|
||||
},
|
||||
{
|
||||
"key": {
|
||||
"uuid": "7f96bb07_eb17fd50",
|
||||
"filename": "doc/source/deployment-guide.rst",
|
||||
"patchSetId": 7
|
||||
},
|
||||
"lineNbr": 309,
|
||||
"author": {
|
||||
"id": 13702
|
||||
},
|
||||
"writtenOn": "2018-01-21T13:34:47Z",
|
||||
"side": 1,
|
||||
"message": "It should be as follows:\n\n kubectl run -i -t $(uuidgen) --image\u003dbusybox --restart\u003dNever\n If you don\u0027t see a command prompt, try pressing enter.\n / # nslookup kubernetes\n Server: 10.3.3.10\n Address 1: 10.3.3.10 kube-dns.kube-system.svc.cluster.local\n\n Name: kubernetes\n Address 1: 10.3.3.1 kubernetes.default.svc.cluster.local\n / #",
|
||||
"range": {
|
||||
"startLine": 301,
|
||||
"startChar": 0,
|
||||
"endLine": 309,
|
||||
"endChar": 60
|
||||
},
|
||||
"revId": "fbe4ae326b59eb9c3b21429cff02ca1d55eeeeb6",
|
||||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
|
||||
"unresolved": false
|
||||
},
|
||||
{
|
||||
"key": {
|
||||
"uuid": "7f96bb07_3651cc0f",
|
||||
"filename": "doc/source/deployment-guide.rst",
|
||||
"patchSetId": 7
|
||||
},
|
||||
"lineNbr": 374,
|
||||
"author": {
|
||||
"id": 13702
|
||||
},
|
||||
"writtenOn": "2018-01-21T13:34:47Z",
|
||||
"side": 1,
|
||||
"message": "There is a interaction to check gpg key. If a user copy\u0026paste this code-block, it will be failed. Therefore, it\u0027s better to split as follows:\n\nPre-configuration for ansible installation:\n\n.. code-block:: bash\n\n sudo apt update; sudo apt install -y software-properties-common\n sudo apt-add-repository ppa:ansible/ansible\n\nInstall ansible:\n\n.. code-block:: bash\n\n sudo apt install -y ansible python-pip python-dev",
|
||||
"range": {
|
||||
"startLine": 374,
|
||||
"startChar": 4,
|
||||
"endLine": 374,
|
||||
"endChar": 47
|
||||
},
|
||||
"revId": "fbe4ae326b59eb9c3b21429cff02ca1d55eeeeb6",
|
||||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
|
||||
"unresolved": false
|
||||
},
|
||||
{
|
||||
"key": {
|
||||
"uuid": "7f96bb07_d66e68c8",
|
||||
"filename": "doc/source/deployment-guide.rst",
|
||||
"patchSetId": 7
|
||||
},
|
||||
"lineNbr": 528,
|
||||
"author": {
|
||||
"id": 13702
|
||||
},
|
||||
"writtenOn": "2018-01-21T13:34:47Z",
|
||||
"side": 1,
|
||||
"message": "Today, it is increased 200. If the number of images less than 200, what should we do? I think there is no meaning to count the number of helm images without explaining bad case.\n\n$ ls | grep \".tgz\" | wc -l\n200",
|
||||
"revId": "fbe4ae326b59eb9c3b21429cff02ca1d55eeeeb6",
|
||||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
|
||||
"unresolved": false
|
||||
},
|
||||
{
|
||||
"key": {
|
||||
"uuid": "7f96bb07_9668e0ba",
|
||||
"filename": "doc/source/deployment-guide.rst",
|
||||
"patchSetId": 7
|
||||
},
|
||||
"lineNbr": 595,
|
||||
"author": {
|
||||
"id": 13702
|
||||
},
|
||||
"writtenOn": "2018-01-21T13:34:47Z",
|
||||
"side": 1,
|
||||
"message": "base_distro: ``ubuntu`` does not currently work. Use ``centos``.",
|
||||
"revId": "fbe4ae326b59eb9c3b21429cff02ca1d55eeeeb6",
|
||||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
|
||||
"unresolved": false
|
||||
},
|
||||
{
|
||||
"key": {
|
||||
"uuid": "7f96bb07_369f8cb5",
|
||||
"filename": "doc/source/deployment-guide.rst",
|
||||
"patchSetId": 7
|
||||
},
|
||||
"lineNbr": 738,
|
||||
"author": {
|
||||
"id": 13702
|
||||
},
|
||||
"writtenOn": "2018-01-21T13:34:47Z",
|
||||
"side": 1,
|
||||
"message": "I think it should be removed from #736-738 because this CLI doesn\u0027t work correctly now( or not supported yet). Please refer https://bugs.launchpad.net/python-openstackclient/+bug/1701079\n\nI also filed a bug into this launchpad.",
|
||||
"revId": "fbe4ae326b59eb9c3b21429cff02ca1d55eeeeb6",
|
||||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
|
||||
"unresolved": false
|
||||
}
|
||||
]
|
||||
}
|
||||
Loading…
Reference in New Issue