openstack
/
kolla-kubernetes
Code Issues Proposed changes

Update patch set 1 

Patch Set 1:

(1 comment)

Patch-set: 1
This commit is contained in:
Gerrit User 24043 2017-03-27 13:12:06 +00:00 committed by Gerrit Code Review
parent 52d5a8831a
commit f0dbd53c18
1 changed files with 18 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

18
e169e8d94d32f897cb97d621f6fc30da774395e7
View File

@ -34,6 +34,24 @@
"revId": "e169e8d94d32f897cb97d621f6fc30da774395e7",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "ffe62b97_16a585b5",
"filename": "tests/bin/ironic_deploy_tests.sh",
"patchSetId": 1
},
"lineNbr": 123,
"author": {
"id": 24043
},
"writtenOn": "2017-03-27T13:12:06Z",
"side": 1,
"message": "Yup I see your point, the alias is convenient. But you\u0027re setting a precedence that alias\u0027s in scripts are allowed; maybe they are used in OS, being new I don\u0027t know. But I do know bad coding practices tend to propagate. From the bash manual page: \"For almost every purpose, aliases are superseded by shell functions.\" I won\u0027t hold the review up if you don\u0027t agree.",
"parentUuid": "ffe62b97_e91274b1",
"revId": "e169e8d94d32f897cb97d621f6fc30da774395e7",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
}
]
}