kolla-kubernetes/ece69208e1a50bbd4ef157253f6...

503 lines
18 KiB
Plaintext

{
"comments": [
{
"key": {
"uuid": "df87a7cf_5c6830b9",
"filename": "doc/source/deployment-guide.rst",
"patchSetId": 2
},
"lineNbr": 158,
"author": {
"id": 13702
},
"writtenOn": "2017-12-14T03:46:53Z",
"side": 1,
"message": "After running this command, docker has been installed v1.13. Current constraint was as follows:\n\n docker \u003d\u003d 1.12.6\n\nIs it OK to use v1.13? If not, it\u0027s better to refer following guide to install docker v1.12\n\n https://docs.docker.com/cs-engine/1.12/",
"revId": "ece69208e1a50bbd4ef157253f68dc8289baf544",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "df87a7cf_142cb345",
"filename": "doc/source/deployment-guide.rst",
"patchSetId": 2
},
"lineNbr": 159,
"author": {
"id": 13702
},
"writtenOn": "2017-12-14T15:18:34Z",
"side": 1,
"message": "Here is a command to install docker v1.12 for Ubuntu 16.04\n\nsudo apt-get update\nsudo apt-get install --no-install-recommends apt-transport-https curl software-properties-common\nsudo apt-get install -y --no-install-recommends linux-image-extra-$(uname -r) linux-image-extra-virtual\ncurl -fsSL \u0027https://sks-keyservers.net/pks/lookup?op\u003dget\u0026search\u003d0xee6d536cf7dc86e2d7d56f59a178ac6c6238f52e\u0027 | sudo apt-key add -\nsudo add-apt-repository \"deb https://packages.docker.com/1.12/apt/repo/ \\\n ubuntu-$(lsb_release -cs) main\"\n\nsudo apt-get update\nsudo apt-get -y install docker-engine\n\nAfter that, we can use following version:\n\n$ docker --version\nDocker version 1.12.6-cs13, build 0ee24d4\n\nI referred https://docs.docker.com/cs-engine/1.12/",
"revId": "ece69208e1a50bbd4ef157253f68dc8289baf544",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "df87a7cf_9c7c7873",
"filename": "doc/source/deployment-guide.rst",
"patchSetId": 2
},
"lineNbr": 182,
"author": {
"id": 13702
},
"writtenOn": "2017-12-14T03:46:53Z",
"side": 1,
"message": "For Ubuntu 16.04, it was also necessary to start kubelet.\n\n sudo sed -i \u0027/^\\[Service\\]$/a Environment\u003d\"KUBELET_EXTRA_ARGS\u003d--fail-swap-on\u003dfalse\"\u0027 /etc/systemd/system/kubelet.service.d/10-kubeadm.conf\n\nIt\u0027s better to split as follows:\n\nAdd an option for running kubelet::\n\n sudo sed -i \u0027/^\\[Service\\]$/a Environment\u003d\"KUBELET_EXTRA_ARGS\u003d--fail-swap-on\u003dfalse\"\u0027 /etc/systemd/system/kubelet.service.d/10-kubeadm.conf\n\nPlease refer my patch: https://review.openstack.org/#/c/527416/",
"revId": "ece69208e1a50bbd4ef157253f68dc8289baf544",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "df87a7cf_3c8d2c7b",
"filename": "doc/source/deployment-guide.rst",
"patchSetId": 2
},
"lineNbr": 206,
"author": {
"id": 13702
},
"writtenOn": "2017-12-14T03:46:53Z",
"side": 1,
"message": "For Ubuntu, --skip-preflight-checks was necessary to run kubeadm correctly.\n\nPlease refer my patch: https://review.openstack.org/#/c/527416/",
"range": {
"startLine": 206,
"startChar": 3,
"endLine": 206,
"endChar": 79
},
"revId": "ece69208e1a50bbd4ef157253f68dc8289baf544",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "df87a7cf_7e609f33",
"filename": "doc/source/deployment-guide.rst",
"patchSetId": 2
},
"lineNbr": 254,
"author": {
"id": 2834
},
"writtenOn": "2017-12-02T16:11:11Z",
"side": 1,
"message": "master of kubernetes is 1.8 - this guide will end up installing kubernetes 1.8.z. Can you confirm this version of canal works with the latest kubernetes?",
"revId": "ece69208e1a50bbd4ef157253f68dc8289baf544",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "df87a7cf_167d7c6d",
"filename": "doc/source/deployment-guide.rst",
"patchSetId": 2
},
"lineNbr": 254,
"author": {
"id": 13702
},
"writtenOn": "2017-12-15T14:49:16Z",
"side": 1,
"message": "I tested following version of kubernetes. And it worked correctly.\n\n* kubectl:\n\nClient Version: version.Info{Major:\"1\", Minor:\"8\", GitVersion:\"v1.8.5\", GitCommit:\"cce11c6a185279d037023e02ac5249e14daa22bf\", GitTreeState:\"clean\", BuildDate:\"2017-12-07T16:16:03Z\", GoVersion:\"go1.8.3\", Compiler:\"gc\", Platform:\"linux/amd64\"}\nServer Version: version.Info{Major:\"1\", Minor:\"8\", GitVersion:\"v1.8.5\", GitCommit:\"cce11c6a185279d037023e02ac5249e14daa22bf\", GitTreeState:\"clean\", BuildDate:\"2017-12-07T16:05:18Z\", GoVersion:\"go1.8.3\", Compiler:\"gc\", Platform:\"linux/amd64\"}\n\n* kubeadm:\n\nkubeadm version: \u0026version.Info{Major:\"1\", Minor:\"8\", GitVersion:\"v1.8.5\", GitCommit:\"cce11c6a185279d037023e02ac5249e14daa22bf\", GitTreeState:\"clean\", BuildDate:\"2017-12-07T16:05:18Z\", GoVersion:\"go1.8.3\", Compiler:\"gc\", Platform:\"linux/amd64\"}\n\n* kubelet:\n\nKubernetes v1.8.5",
"parentUuid": "df87a7cf_7e609f33",
"revId": "ece69208e1a50bbd4ef157253f68dc8289baf544",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "df87a7cf_becb871c",
"filename": "doc/source/deployment-guide.rst",
"patchSetId": 2
},
"lineNbr": 256,
"author": {
"id": 2834
},
"writtenOn": "2017-12-02T16:11:11Z",
"side": 1,
"message": "ditto.",
"revId": "ece69208e1a50bbd4ef157253f68dc8289baf544",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "df87a7cf_7cd8947e",
"filename": "doc/source/deployment-guide.rst",
"patchSetId": 2
},
"lineNbr": 256,
"author": {
"id": 13702
},
"writtenOn": "2017-12-14T03:46:53Z",
"side": 1,
"message": "+1. For Ubuntu 16.04, it didn\u0027t work \"1.6\". \"1.7\" worked correctly.",
"parentUuid": "df87a7cf_becb871c",
"revId": "ece69208e1a50bbd4ef157253f68dc8289baf544",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "df87a7cf_76eba811",
"filename": "doc/source/deployment-guide.rst",
"patchSetId": 2
},
"lineNbr": 256,
"author": {
"id": 13702
},
"writtenOn": "2017-12-15T14:49:16Z",
"side": 1,
"message": "k8s version was the same above.",
"parentUuid": "df87a7cf_7cd8947e",
"revId": "ece69208e1a50bbd4ef157253f68dc8289baf544",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "df87a7cf_5e5b5b86",
"filename": "doc/source/deployment-guide.rst",
"patchSetId": 2
},
"lineNbr": 318,
"author": {
"id": 2834
},
"writtenOn": "2017-12-02T16:11:11Z",
"side": 1,
"message": "this looks good",
"revId": "ece69208e1a50bbd4ef157253f68dc8289baf544",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "df87a7cf_d43c0bc1",
"filename": "doc/source/deployment-guide.rst",
"patchSetId": 2
},
"lineNbr": 318,
"author": {
"id": 13702
},
"writtenOn": "2017-12-14T15:15:41Z",
"side": 1,
"message": "+1 It worked correctly!",
"parentUuid": "df87a7cf_5e5b5b86",
"revId": "ece69208e1a50bbd4ef157253f68dc8289baf544",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "df87a7cf_166345de",
"filename": "doc/source/deployment-guide.rst",
"patchSetId": 2
},
"lineNbr": 318,
"author": {
"id": 19616
},
"writtenOn": "2017-12-15T07:56:49Z",
"side": 1,
"message": "+1",
"parentUuid": "df87a7cf_d43c0bc1",
"revId": "ece69208e1a50bbd4ef157253f68dc8289baf544",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "df87a7cf_292deca7",
"filename": "doc/source/deployment-guide.rst",
"patchSetId": 2
},
"lineNbr": 334,
"author": {
"id": 13702
},
"writtenOn": "2017-12-14T03:46:53Z",
"side": 1,
"message": "--validate\u003dfalse is necessary to pass this command.\n\nPlease refer my patch: https://review.openstack.org/#/c/526919/2",
"revId": "ece69208e1a50bbd4ef157253f68dc8289baf544",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "df87a7cf_945f630d",
"filename": "doc/source/deployment-guide.rst",
"patchSetId": 2
},
"lineNbr": 334,
"author": {
"id": 13702
},
"writtenOn": "2017-12-14T15:15:41Z",
"side": 1,
"message": "This option is not necessary by fixing #317 from Steven. Please ignore my comment.",
"parentUuid": "df87a7cf_292deca7",
"revId": "ece69208e1a50bbd4ef157253f68dc8289baf544",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "df87a7cf_690c5442",
"filename": "doc/source/deployment-guide.rst",
"patchSetId": 2
},
"lineNbr": 353,
"author": {
"id": 13702
},
"writtenOn": "2017-12-14T03:46:53Z",
"side": 1,
"message": "For Ubuntu, it is necessary following commands:\n\nUbuntu\n------\n\n.. code-block:: bash\n\n sudo apt update; sudo apt install software-properties-common\n sudo apt-add-repository ppa:ansible/ansible\n sudo apt install ansible python-pip python-dev\n\nPlease refer my patch: https://review.openstack.org/#/c/526921",
"revId": "ece69208e1a50bbd4ef157253f68dc8289baf544",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "df87a7cf_fc2b447f",
"filename": "doc/source/deployment-guide.rst",
"patchSetId": 2
},
"lineNbr": 373,
"author": {
"id": 13702
},
"writtenOn": "2017-12-14T03:46:53Z",
"side": 1,
"message": "This command cannot satisfy requirements because requirement constraint only evaluated for kolla-ansible with websocket_client.\n\nFor more detail, please refer this launchpad: https://bugs.launchpad.net/kolla-kubernetes/+bug/1737764\n\nTherefore, it should be following command:\n\n sudo pip install -U ./kolla-ansible/\n sudo pip install -U ./kolla-kubernetes/\n\nor\n\n sudo pip install -U kolla-kubernetes/ kolla-ansible/\n\n\nPlease refer my patch: https://review.openstack.org/#/c/527401/",
"range": {
"startLine": 373,
"startChar": 4,
"endLine": 373,
"endChar": 56
},
"revId": "ece69208e1a50bbd4ef157253f68dc8289baf544",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "df87a7cf_be662751",
"filename": "doc/source/deployment-guide.rst",
"patchSetId": 2
},
"lineNbr": 377,
"author": {
"id": 2834
},
"writtenOn": "2017-12-02T16:11:11Z",
"side": 1,
"message": "I wouldn\u0027t expect the kolla configs to go to /usr/local/share unless something has changed with centos (?). Mind expanding further on why this is needed?",
"revId": "ece69208e1a50bbd4ef157253f68dc8289baf544",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "df87a7cf_798d99d1",
"filename": "doc/source/deployment-guide.rst",
"patchSetId": 2
},
"lineNbr": 377,
"author": {
"id": 22165
},
"writtenOn": "2017-12-07T17:47:03Z",
"side": 1,
"message": "agree",
"parentUuid": "df87a7cf_be662751",
"revId": "ece69208e1a50bbd4ef157253f68dc8289baf544",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "df87a7cf_1627bc66",
"filename": "doc/source/deployment-guide.rst",
"patchSetId": 2
},
"lineNbr": 377,
"author": {
"id": 13702
},
"writtenOn": "2017-12-15T15:09:41Z",
"side": 1,
"message": "For Ubuntu16.04, it was correct /usr/local/share/kolla-ansible/etc_examples/kolla.",
"parentUuid": "df87a7cf_be662751",
"revId": "ece69208e1a50bbd4ef157253f68dc8289baf544",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "df87a7cf_54d6bb51",
"filename": "doc/source/deployment-guide.rst",
"patchSetId": 2
},
"lineNbr": 478,
"author": {
"id": 13702
},
"writtenOn": "2017-12-14T15:15:41Z",
"side": 1,
"message": "It worked correctly! When I ran \u0027sudo kolla-ansible genconfig\u0027, some definition were copied into /etc/kolla/ but directory permission was wrong. As a result, it occurred an error for \u0027kollakube res create configmap ...\u0027 command. Therefore, +1 for me.",
"revId": "ece69208e1a50bbd4ef157253f68dc8289baf544",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "df87a7cf_16349c49",
"filename": "doc/source/deployment-guide.rst",
"patchSetId": 2
},
"lineNbr": 500,
"author": {
"id": 13702
},
"writtenOn": "2017-12-15T15:09:41Z",
"side": 1,
"message": "Should it be 175?. Because above command tries to download (1/175).",
"range": {
"startLine": 500,
"startChar": 72,
"endLine": 500,
"endChar": 75
},
"revId": "ece69208e1a50bbd4ef157253f68dc8289baf544",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "df87a7cf_fe726f11",
"filename": "doc/source/deployment-guide.rst",
"patchSetId": 2
},
"lineNbr": 521,
"author": {
"id": 2834
},
"writtenOn": "2017-12-02T16:11:11Z",
"side": 1,
"message": "this is actually a bug in the helm charts - and this is a workaround here. I submitted this workaround months ago but was unable to fix the actual problem.",
"revId": "ece69208e1a50bbd4ef157253f68dc8289baf544",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "df87a7cf_60c21aec",
"filename": "doc/source/deployment-guide.rst",
"patchSetId": 2
},
"lineNbr": 521,
"author": {
"id": 13702
},
"writtenOn": "2017-12-14T15:15:41Z",
"side": 1,
"message": "Hi Steven, I\u0027ve just tested on Ubuntu16.04 with this cloud.yaml and worked correctly.\n\n$ kubectl get pods --all-namespaces\n..(snip)..\nkolla keystone-55d7f5c7c-rkp7x 1/1 Running 0 53m",
"parentUuid": "df87a7cf_fe726f11",
"revId": "ece69208e1a50bbd4ef157253f68dc8289baf544",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "df87a7cf_3c31aced",
"filename": "doc/source/deployment-guide.rst",
"patchSetId": 2
},
"lineNbr": 567,
"author": {
"id": 13702
},
"writtenOn": "2017-12-14T03:46:53Z",
"side": 1,
"message": "It\u0027s better to align with \"CentOS\" or \"Centos\".",
"range": {
"startLine": 567,
"startChar": 39,
"endLine": 567,
"endChar": 46
},
"revId": "ece69208e1a50bbd4ef157253f68dc8289baf544",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "df87a7cf_9c5558fd",
"filename": "doc/source/deployment-guide.rst",
"patchSetId": 2
},
"lineNbr": 567,
"author": {
"id": 13702
},
"writtenOn": "2017-12-14T03:46:53Z",
"side": 1,
"message": "Wow... I didn\u0027t know that. But I\u0027m trying to test this document in Ubuntu16.04. I\u0027ll share my feedback ASAP :)",
"range": {
"startLine": 567,
"startChar": 3,
"endLine": 567,
"endChar": 33
},
"revId": "ece69208e1a50bbd4ef157253f68dc8289baf544",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "df87a7cf_7abe4b00",
"filename": "doc/source/deployment-guide.rst",
"patchSetId": 2
},
"lineNbr": 568,
"author": {
"id": 24043
},
"writtenOn": "2017-12-14T13:26:26Z",
"side": 1,
"message": "I already pointed out in a previous review that it works fine on Ubuntu.",
"revId": "ece69208e1a50bbd4ef157253f68dc8289baf544",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "df87a7cf_80aabe16",
"filename": "doc/source/deployment-guide.rst",
"patchSetId": 2
},
"lineNbr": 568,
"author": {
"id": 13702
},
"writtenOn": "2017-12-14T15:15:41Z",
"side": 1,
"message": "+1 :)",
"parentUuid": "df87a7cf_7abe4b00",
"revId": "ece69208e1a50bbd4ef157253f68dc8289baf544",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
}
]
}