57 lines
2.4 KiB
Plaintext
57 lines
2.4 KiB
Plaintext
{
|
|
"comments": [
|
|
{
|
|
"key": {
|
|
"uuid": "ffe62b97_9b07b51d",
|
|
"filename": "tests/bin/ironic_deploy_tests.sh",
|
|
"patchSetId": 1
|
|
},
|
|
"lineNbr": 123,
|
|
"author": {
|
|
"id": 24043
|
|
},
|
|
"writtenOn": "2017-03-24T20:33:52Z",
|
|
"side": 1,
|
|
"message": "Alias\u0027s in shell scripts are a real pain to support - even for a temp. fix.\n\nBetter to do something like:\n\nfunction virsh_m () { command1; command2 }\nexport -f virsh_m #I can be called 1x at the end of the logic\n\nI\u0027d call virsh_m something like virsh_distro or virsh_modified as \u0027m\u0027 makes me think too much.",
|
|
"revId": "e169e8d94d32f897cb97d621f6fc30da774395e7",
|
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
|
|
"unresolved": false
|
|
},
|
|
{
|
|
"key": {
|
|
"uuid": "ffe62b97_e91274b1",
|
|
"filename": "tests/bin/ironic_deploy_tests.sh",
|
|
"patchSetId": 1
|
|
},
|
|
"lineNbr": 123,
|
|
"author": {
|
|
"id": 19384
|
|
},
|
|
"writtenOn": "2017-03-24T23:24:09Z",
|
|
"side": 1,
|
|
"message": "Cannot say I agree with this, because if I go with function then each call would need to check whether it is called from centos env or from Ubuntu, also I will need to pass two parameters. Probably for the gate it is not that important, but still why not to save a few cpu cycles.",
|
|
"parentUuid": "ffe62b97_9b07b51d",
|
|
"revId": "e169e8d94d32f897cb97d621f6fc30da774395e7",
|
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
|
|
"unresolved": false
|
|
},
|
|
{
|
|
"key": {
|
|
"uuid": "ffe62b97_16a585b5",
|
|
"filename": "tests/bin/ironic_deploy_tests.sh",
|
|
"patchSetId": 1
|
|
},
|
|
"lineNbr": 123,
|
|
"author": {
|
|
"id": 24043
|
|
},
|
|
"writtenOn": "2017-03-27T13:12:06Z",
|
|
"side": 1,
|
|
"message": "Yup I see your point, the alias is convenient. But you\u0027re setting a precedence that alias\u0027s in scripts are allowed; maybe they are used in OS, being new I don\u0027t know. But I do know bad coding practices tend to propagate. From the bash manual page: \"For almost every purpose, aliases are superseded by shell functions.\" I won\u0027t hold the review up if you don\u0027t agree.",
|
|
"parentUuid": "ffe62b97_e91274b1",
|
|
"revId": "e169e8d94d32f897cb97d621f6fc30da774395e7",
|
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
|
|
"unresolved": false
|
|
}
|
|
]
|
|
} |