kolla-kubernetes/c437f8a88a29636ff20ab14bdc7...

250 lines
7.5 KiB
Plaintext

{
"comments": [
{
"key": {
"uuid": "7f231b9d_de451d45",
"filename": "ansible/roles/deploy/tasks/cinder-control.yml",
"patchSetId": 1
},
"lineNbr": 21,
"author": {
"id": 2834
},
"writtenOn": "2017-06-12T21:20:41Z",
"side": 1,
"message": "a different (imo better) way to structure the jobs is not by service, by by operation. ordering should be : init PVC (the init jobs), create keystone cruft (wait for keystone cruft to be registered). This allows playbook to run in maximum parallel operation.",
"revId": "c437f8a88a29636ff20ab14bdc783f78e99f0000",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "7f231b9d_6a3f5425",
"filename": "ansible/roles/deploy/tasks/cinder-control.yml",
"patchSetId": 1
},
"lineNbr": 21,
"author": {
"id": 6638
},
"writtenOn": "2017-06-13T09:09:34Z",
"side": 1,
"message": "ok sounds like a good idea",
"revId": "c437f8a88a29636ff20ab14bdc783f78e99f0000",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "7f231b9d_742e2ba6",
"filename": "ansible/roles/deploy/tasks/cleanup.yml",
"patchSetId": 1
},
"lineNbr": 1,
"author": {
"id": 2834
},
"writtenOn": "2017-06-12T21:20:41Z",
"side": 1,
"message": "we already have a destroy playbook - this can go",
"revId": "c437f8a88a29636ff20ab14bdc783f78e99f0000",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "7f231b9d_ea1484a2",
"filename": "ansible/roles/deploy/tasks/cleanup.yml",
"patchSetId": 1
},
"lineNbr": 1,
"author": {
"id": 6638
},
"writtenOn": "2017-06-13T09:09:34Z",
"side": 1,
"message": "this isn\u0027t a clean up like the destroy playbook but this is to remove the short lived charts from helm once they have finished, otherwise \u0027helm ls\u0027 will just like every microservice that has been started. Do we not want to do that?",
"revId": "c437f8a88a29636ff20ab14bdc783f78e99f0000",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "7f231b9d_ec3b81c5",
"filename": "ansible/roles/deploy/tasks/cleanup.yml",
"patchSetId": 1
},
"lineNbr": 1,
"author": {
"id": 19384
},
"writtenOn": "2017-06-13T09:22:13Z",
"side": 1,
"message": "@Bradley, if you delete pv/pvc you will loose your volumes, if you delete svc then obviously you will lose your service. In case of mariadb you need to remove only init-element, for other services you can delete only bootstrapping charts.",
"parentUuid": "7f231b9d_ea1484a2",
"revId": "c437f8a88a29636ff20ab14bdc783f78e99f0000",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "7f231b9d_cf77973a",
"filename": "ansible/roles/deploy/tasks/cleanup.yml",
"patchSetId": 1
},
"lineNbr": 1,
"author": {
"id": 6638
},
"writtenOn": "2017-06-13T10:00:13Z",
"side": 1,
"message": "ah of course, thanks serguei. So it will only be charts with the \u0027-job\u0027 suffix that need to be deleted?",
"parentUuid": "7f231b9d_ec3b81c5",
"revId": "c437f8a88a29636ff20ab14bdc783f78e99f0000",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "7f231b9d_b40de33f",
"filename": "ansible/roles/deploy/tasks/main.yml",
"patchSetId": 1
},
"lineNbr": 5,
"author": {
"id": 2834
},
"writtenOn": "2017-06-12T21:20:41Z",
"side": 1,
"message": "rather then using waitforpods, actively verify the database is responsive",
"revId": "c437f8a88a29636ff20ab14bdc783f78e99f0000",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "7f231b9d_2a495ccf",
"filename": "ansible/roles/deploy/tasks/main.yml",
"patchSetId": 1
},
"lineNbr": 5,
"author": {
"id": 6638
},
"writtenOn": "2017-06-13T09:09:34Z",
"side": 1,
"message": "ok",
"revId": "c437f8a88a29636ff20ab14bdc783f78e99f0000",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "7f231b9d_f4135b65",
"filename": "ansible/roles/deploy/tasks/main.yml",
"patchSetId": 1
},
"lineNbr": 9,
"author": {
"id": 2834
},
"writtenOn": "2017-06-12T21:20:41Z",
"side": 1,
"message": "keystone needs syncronization as well",
"revId": "c437f8a88a29636ff20ab14bdc783f78e99f0000",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "7f231b9d_0a4460b6",
"filename": "ansible/roles/deploy/tasks/main.yml",
"patchSetId": 1
},
"lineNbr": 9,
"author": {
"id": 6638
},
"writtenOn": "2017-06-13T09:09:34Z",
"side": 1,
"message": "+1",
"revId": "c437f8a88a29636ff20ab14bdc783f78e99f0000",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "7f231b9d_54044f17",
"filename": "ansible/roles/deploy/tasks/mariadb.yml",
"patchSetId": 1
},
"lineNbr": 12,
"author": {
"id": 2834
},
"writtenOn": "2017-06-12T21:20:41Z",
"side": 1,
"message": "need to wait for mariadb init job to finish before proceeding to line 14",
"revId": "c437f8a88a29636ff20ab14bdc783f78e99f0000",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "7f231b9d_4a3a5834",
"filename": "ansible/roles/deploy/tasks/mariadb.yml",
"patchSetId": 1
},
"lineNbr": 12,
"author": {
"id": 6638
},
"writtenOn": "2017-06-13T09:09:34Z",
"side": 1,
"message": "ok",
"revId": "c437f8a88a29636ff20ab14bdc783f78e99f0000",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "7f231b9d_7e2289a6",
"filename": "ansible/roles/deploy/tasks/rabbitmq.yml",
"patchSetId": 1
},
"lineNbr": 12,
"author": {
"id": 2834
},
"writtenOn": "2017-06-12T21:20:41Z",
"side": 1,
"message": "need to wait for init job to finish",
"range": {
"startLine": 12,
"startChar": 28,
"endLine": 12,
"endChar": 29
},
"revId": "c437f8a88a29636ff20ab14bdc783f78e99f0000",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "7f231b9d_ca1788a3",
"filename": "ansible/roles/deploy/tasks/rabbitmq.yml",
"patchSetId": 1
},
"lineNbr": 12,
"author": {
"id": 6638
},
"writtenOn": "2017-06-13T09:09:34Z",
"side": 1,
"message": "ok",
"revId": "c437f8a88a29636ff20ab14bdc783f78e99f0000",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
}
]
}