openstack
/
kolla-kubernetes
Code Issues Proposed changes
kolla-kubernetes/1f65ed28fd10e736ccbc9b134cd...

345 lines
12 KiB
Plaintext
Raw Blame History

{
"comments": [
{
"key": {
"uuid": "5a74a57a_52ff87a9",
"filename": "helm/kolla-kubernetes/charts/openvswitch/charts/openvswitch-ovsdb/templates/openvswitch-ovsdb-configmap.yaml",
"patchSetId": 3
},
"lineNbr": 9,
"author": {
"id": 2834
},
"writtenOn": "2016-11-26T16:06:10Z",
"side": 1,
"message": "still struggling with this. If you need a special config.json for ovsdb on top of kubernetes, thats cool lets make one of those. Where I struggle is how we get the actual ovsdb configuration bits into the system, not just config.json if this workaround configmap is present.",
"revId": "1f65ed28fd10e736ccbc9b134cd171d2ff469712",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "5a74a57a_72df230d",
"filename": "helm/kolla-kubernetes/charts/openvswitch/charts/openvswitch-ovsdb/templates/openvswitch-ovsdb-configmap.yaml",
"patchSetId": 3
},
"lineNbr": 9,
"author": {
"id": 19384
},
"writtenOn": "2016-11-26T16:52:54Z",
"side": 1,
"message": "You are correct, this config map is not used and will not be needed.",
"parentUuid": "5a74a57a_52ff87a9",
"revId": "1f65ed28fd10e736ccbc9b134cd171d2ff469712",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "5a74a57a_722e4344",
"filename": "helm/kolla-kubernetes/charts/openvswitch/charts/openvswitch-ovsdb/templates/openvswitch-ovsdb-daemonset.yaml",
"patchSetId": 3
},
"lineNbr": 71,
"author": {
"id": 2834
},
"writtenOn": "2016-11-26T16:06:10Z",
"side": 1,
"message": "confused by this. The configmap has a workaround config.json, why not just use that?",
"revId": "1f65ed28fd10e736ccbc9b134cd171d2ff469712",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "5a74a57a_d2eab7ab",
"filename": "helm/kolla-kubernetes/charts/openvswitch/charts/openvswitch-ovsdb/templates/openvswitch-ovsdb-daemonset.yaml",
"patchSetId": 3
},
"lineNbr": 71,
"author": {
"id": 19384
},
"writtenOn": "2016-11-26T16:52:54Z",
"side": 1,
"message": "No configmap was not a workaround for openvswitch case. The reason for calling ovsdb-server directly from the container and without using config.json was multiple racing conditions encountered when using config.json which led to really bad instability of ovsdb-server process.",
"parentUuid": "5a74a57a_722e4344",
"revId": "1f65ed28fd10e736ccbc9b134cd171d2ff469712",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "5a74a57a_5254e71f",
"filename": "helm/kolla-kubernetes/charts/openvswitch/charts/openvswitch-ovsdb/templates/openvswitch-ovsdb-daemonset.yaml",
"patchSetId": 3
},
"lineNbr": 71,
"author": {
"id": 2834
},
"writtenOn": "2016-11-26T18:24:10Z",
"side": 1,
"message": "can you make your own config.json that doesn\u0027t suffer these race conditions and then deliver that via configmap?",
"parentUuid": "5a74a57a_d2eab7ab",
"revId": "1f65ed28fd10e736ccbc9b134cd171d2ff469712",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "5a74a57a_f2225351",
"filename": "helm/kolla-kubernetes/charts/openvswitch/charts/openvswitch-vswitchd/templates/openvswitch-vswitchd-configmap.yaml",
"patchSetId": 3
},
"lineNbr": 3,
"author": {
"id": 2834
},
"writtenOn": "2016-11-26T16:06:10Z",
"side": 1,
"message": "can you sort out how to get to that final version in this review? \n\novsdb has some config stuff that comes with it, correct? Why not just make your own config.json _outside_ the helm chart as a configmap? Then we actually have something to use as a reference for other people to implement the rest of the helm templates for compute kit.\n\nThen it should be a matter of turn the crank C\u0026P from the rest of our codebase for other contributors to tackle.",
"revId": "1f65ed28fd10e736ccbc9b134cd171d2ff469712",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "5a74a57a_32da0b18",
"filename": "helm/kolla-kubernetes/charts/openvswitch/charts/openvswitch-vswitchd/templates/openvswitch-vswitchd-configmap.yaml",
"patchSetId": 3
},
"lineNbr": 3,
"author": {
"id": 19384
},
"writtenOn": "2016-11-26T16:52:54Z",
"side": 1,
"message": "The final version will be available only after the community decides how helm charts will be structured.",
"parentUuid": "5a74a57a_f2225351",
"revId": "1f65ed28fd10e736ccbc9b134cd171d2ff469712",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "5a74a57a_32576b27",
"filename": "helm/kolla-kubernetes/charts/openvswitch/charts/openvswitch-vswitchd/templates/openvswitch-vswitchd-configmap.yaml",
"patchSetId": 3
},
"lineNbr": 3,
"author": {
"id": 2834
},
"writtenOn": "2016-11-26T18:24:10Z",
"side": 1,
"message": "community has already decided config maps should be external as per spec. Is it possible to make that a reality with this patchset or do you need further patchsets on top?",
"parentUuid": "5a74a57a_32da0b18",
"revId": "1f65ed28fd10e736ccbc9b134cd171d2ff469712",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "5a74a57a_72d5631a",
"filename": "helm/kolla-kubernetes/templates/_helpers.tpl",
"patchSetId": 3
},
"lineNbr": 39,
"author": {
"id": 2834
},
"writtenOn": "2016-11-26T16:06:10Z",
"side": 1,
"message": "why must the configmap name be configurable for the logging system?",
"range": {
"startLine": 39,
"startChar": 21,
"endLine": 39,
"endChar": 42
},
"revId": "1f65ed28fd10e736ccbc9b134cd171d2ff469712",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "5a74a57a_52d787ec",
"filename": "helm/kolla-kubernetes/templates/_helpers.tpl",
"patchSetId": 3
},
"lineNbr": 39,
"author": {
"id": 19384
},
"writtenOn": "2016-11-26T16:52:54Z",
"side": 1,
"message": "It allows flexibility, changing value in configmap from one logger to another will not require any code change and can be done on the fly.",
"parentUuid": "5a74a57a_72d5631a",
"range": {
"startLine": 39,
"startChar": 21,
"endLine": 39,
"endChar": 42
},
"revId": "1f65ed28fd10e736ccbc9b134cd171d2ff469712",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "5a74a57a_7233a314",
"filename": "helm/kolla-kubernetes/templates/_helpers.tpl",
"patchSetId": 3
},
"lineNbr": 39,
"author": {
"id": 2834
},
"writtenOn": "2016-11-26T18:24:10Z",
"side": 1,
"message": "sounds fantastic!",
"parentUuid": "5a74a57a_52d787ec",
"range": {
"startLine": 39,
"startChar": 21,
"endLine": 39,
"endChar": 42
},
"revId": "1f65ed28fd10e736ccbc9b134cd171d2ff469712",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "5a74a57a_32f04bc9",
"filename": "helm/kolla-kubernetes/values.yaml",
"patchSetId": 3
},
"lineNbr": 9,
"author": {
"id": 2834
},
"writtenOn": "2016-11-26T16:06:10Z",
"side": 1,
"message": "need a kolla_tag: 3.0.1 in here",
"revId": "1f65ed28fd10e736ccbc9b134cd171d2ff469712",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "5a74a57a_920bdf8d",
"filename": "helm/kolla-kubernetes/values.yaml",
"patchSetId": 3
},
"lineNbr": 9,
"author": {
"id": 19384
},
"writtenOn": "2016-11-26T16:52:54Z",
"side": 1,
"message": "will add in the next revision.",
"parentUuid": "5a74a57a_32f04bc9",
"revId": "1f65ed28fd10e736ccbc9b134cd171d2ff469712",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "5a74a57a_52edc7ed",
"filename": "helm/kolla-kubernetes/values.yaml",
"patchSetId": 3
},
"lineNbr": 13,
"author": {
"id": 2834
},
"writtenOn": "2016-11-26T16:06:10Z",
"side": 1,
"message": "I really don\u0027t think we need this config variable - it can be added later if we decide CONFIG_ALWAYS has a use case.",
"range": {
"startLine": 13,
"startChar": 0,
"endLine": 13,
"endChar": 25
},
"revId": "1f65ed28fd10e736ccbc9b134cd171d2ff469712",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "5a74a57a_f2fa5374",
"filename": "helm/kolla-kubernetes/values.yaml",
"patchSetId": 3
},
"lineNbr": 13,
"author": {
"id": 19384
},
"writtenOn": "2016-11-26T16:52:54Z",
"side": 1,
"message": "will remove it in the next revision",
"parentUuid": "5a74a57a_52edc7ed",
"range": {
"startLine": 13,
"startChar": 0,
"endLine": 13,
"endChar": 25
},
"revId": "1f65ed28fd10e736ccbc9b134cd171d2ff469712",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "5a74a57a_d2e0f7fc",
"filename": "helm/kolla-kubernetes/values.yaml",
"patchSetId": 3
},
"lineNbr": 14,
"author": {
"id": 2834
},
"writtenOn": "2016-11-26T16:06:10Z",
"side": 1,
"message": "Is it possible to make the k/v value part be something like {{ docker_registry }}/{{docker-namespace}}/{{kolla_base_distro}}/{{kolla_install_type}}/kubernetes-entrypoint:{{tag}}",
"range": {
"startLine": 14,
"startChar": 36,
"endLine": 14,
"endChar": 61
},
"revId": "1f65ed28fd10e736ccbc9b134cd171d2ff469712",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "5a74a57a_32484bcc",
"filename": "helm/kolla-kubernetes/values.yaml",
"patchSetId": 3
},
"lineNbr": 14,
"author": {
"id": 19384
},
"writtenOn": "2016-11-26T16:52:54Z",
"side": 1,
"message": "Not in this file, it is just yaml file and rendering engine do not process it. Will move it to template in the next revision.",
"parentUuid": "5a74a57a_d2e0f7fc",
"range": {
"startLine": 14,
"startChar": 36,
"endLine": 14,
"endChar": 61
},
"revId": "1f65ed28fd10e736ccbc9b134cd171d2ff469712",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
}
]
}
View Git Blame Copy Permalink