713 lines
23 KiB
Plaintext
713 lines
23 KiB
Plaintext
{
|
|
"comments": [
|
|
{
|
|
"key": {
|
|
"uuid": "5a74a57a_80d73722",
|
|
"filename": "helm/kolla-kubernetes/charts/openvswitch/Chart.yaml",
|
|
"patchSetId": 2
|
|
},
|
|
"lineNbr": 4,
|
|
"author": {
|
|
"id": 2834
|
|
},
|
|
"writtenOn": "2016-11-25T01:15:32Z",
|
|
"side": 1,
|
|
"message": "whitespace",
|
|
"range": {
|
|
"startLine": 4,
|
|
"startChar": 17,
|
|
"endLine": 4,
|
|
"endChar": 18
|
|
},
|
|
"revId": "817c027451df8b967955ad808a11f07baf63a742",
|
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
|
|
"unresolved": false
|
|
},
|
|
{
|
|
"key": {
|
|
"uuid": "5a74a57a_d4c63a67",
|
|
"filename": "helm/kolla-kubernetes/charts/openvswitch/Chart.yaml",
|
|
"patchSetId": 2
|
|
},
|
|
"lineNbr": 4,
|
|
"author": {
|
|
"id": 19384
|
|
},
|
|
"writtenOn": "2016-11-25T15:31:38Z",
|
|
"side": 1,
|
|
"message": "Done",
|
|
"parentUuid": "5a74a57a_80d73722",
|
|
"range": {
|
|
"startLine": 4,
|
|
"startChar": 17,
|
|
"endLine": 4,
|
|
"endChar": 18
|
|
},
|
|
"revId": "817c027451df8b967955ad808a11f07baf63a742",
|
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
|
|
"unresolved": false
|
|
},
|
|
{
|
|
"key": {
|
|
"uuid": "5a74a57a_a0b513ef",
|
|
"filename": "helm/kolla-kubernetes/charts/openvswitch/charts/openvswitch-ovsdb/templates/openvswitch-ovsdb-configmap.yaml",
|
|
"patchSetId": 2
|
|
},
|
|
"lineNbr": 8,
|
|
"author": {
|
|
"id": 2834
|
|
},
|
|
"writtenOn": "2016-11-25T01:15:32Z",
|
|
"side": 1,
|
|
"message": "not reading config.json from the standard json files is dangerous. The main issues are security and the init 1 problem.",
|
|
"revId": "817c027451df8b967955ad808a11f07baf63a742",
|
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
|
|
"unresolved": false
|
|
},
|
|
{
|
|
"key": {
|
|
"uuid": "5a74a57a_54aeaa81",
|
|
"filename": "helm/kolla-kubernetes/charts/openvswitch/charts/openvswitch-ovsdb/templates/openvswitch-ovsdb-configmap.yaml",
|
|
"patchSetId": 2
|
|
},
|
|
"lineNbr": 8,
|
|
"author": {
|
|
"id": 19384
|
|
},
|
|
"writtenOn": "2016-11-25T15:31:38Z",
|
|
"side": 1,
|
|
"message": "Please read the comment at the top of this file.",
|
|
"parentUuid": "5a74a57a_a0b513ef",
|
|
"revId": "817c027451df8b967955ad808a11f07baf63a742",
|
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
|
|
"unresolved": false
|
|
},
|
|
{
|
|
"key": {
|
|
"uuid": "5a74a57a_20cae36d",
|
|
"filename": "helm/kolla-kubernetes/charts/openvswitch/charts/openvswitch-ovsdb/templates/openvswitch-ovsdb-configmap.yaml",
|
|
"patchSetId": 2
|
|
},
|
|
"lineNbr": 14,
|
|
"author": {
|
|
"id": 2834
|
|
},
|
|
"writtenOn": "2016-11-25T01:15:32Z",
|
|
"side": 1,
|
|
"message": "ConfigMap objects should be separately loaded tings, not baked into helm as per spec.",
|
|
"revId": "817c027451df8b967955ad808a11f07baf63a742",
|
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
|
|
"unresolved": false
|
|
},
|
|
{
|
|
"key": {
|
|
"uuid": "5a74a57a_14dfd20d",
|
|
"filename": "helm/kolla-kubernetes/charts/openvswitch/charts/openvswitch-ovsdb/templates/openvswitch-ovsdb-configmap.yaml",
|
|
"patchSetId": 2
|
|
},
|
|
"lineNbr": 14,
|
|
"author": {
|
|
"id": 19384
|
|
},
|
|
"writtenOn": "2016-11-25T15:31:38Z",
|
|
"side": 1,
|
|
"message": "Ditto",
|
|
"parentUuid": "5a74a57a_20cae36d",
|
|
"revId": "817c027451df8b967955ad808a11f07baf63a742",
|
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
|
|
"unresolved": false
|
|
},
|
|
{
|
|
"key": {
|
|
"uuid": "5a74a57a_60a21bb0",
|
|
"filename": "helm/kolla-kubernetes/charts/openvswitch/charts/openvswitch-ovsdb/templates/openvswitch-ovsdb-daemonset.yaml",
|
|
"patchSetId": 2
|
|
},
|
|
"lineNbr": 29,
|
|
"author": {
|
|
"id": 2834
|
|
},
|
|
"writtenOn": "2016-11-25T01:15:32Z",
|
|
"side": 1,
|
|
"message": "this is handled by the standard config.json container API.",
|
|
"revId": "817c027451df8b967955ad808a11f07baf63a742",
|
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
|
|
"unresolved": false
|
|
},
|
|
{
|
|
"key": {
|
|
"uuid": "5a74a57a_1414329e",
|
|
"filename": "helm/kolla-kubernetes/charts/openvswitch/charts/openvswitch-ovsdb/templates/openvswitch-ovsdb-daemonset.yaml",
|
|
"patchSetId": 2
|
|
},
|
|
"lineNbr": 29,
|
|
"author": {
|
|
"id": 19384
|
|
},
|
|
"writtenOn": "2016-11-25T15:31:38Z",
|
|
"side": 1,
|
|
"message": "As an exception, config.json is not used for openvswitch components, hence something else \"init container\" is taking care of it.",
|
|
"parentUuid": "5a74a57a_60a21bb0",
|
|
"revId": "817c027451df8b967955ad808a11f07baf63a742",
|
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
|
|
"unresolved": false
|
|
},
|
|
{
|
|
"key": {
|
|
"uuid": "5a74a57a_00924757",
|
|
"filename": "helm/kolla-kubernetes/charts/openvswitch/charts/openvswitch-ovsdb/templates/openvswitch-ovsdb-daemonset.yaml",
|
|
"patchSetId": 2
|
|
},
|
|
"lineNbr": 57,
|
|
"author": {
|
|
"id": 2834
|
|
},
|
|
"writtenOn": "2016-11-25T01:15:32Z",
|
|
"side": 1,
|
|
"message": "In the neutron review, I asked if COPY_ALWAYS was really needed here. I\u0027d ask same in this review. The delta between the neutron review in this review is that this review makes this variable configurable. Lets make a decision on whether COPY_ONCE always works, and then just not make it configurable if that is the case.",
|
|
"revId": "817c027451df8b967955ad808a11f07baf63a742",
|
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
|
|
"unresolved": false
|
|
},
|
|
{
|
|
"key": {
|
|
"uuid": "5a74a57a_409c3f69",
|
|
"filename": "helm/kolla-kubernetes/charts/openvswitch/charts/openvswitch-ovsdb/templates/openvswitch-ovsdb-daemonset.yaml",
|
|
"patchSetId": 2
|
|
},
|
|
"lineNbr": 59,
|
|
"author": {
|
|
"id": 2834
|
|
},
|
|
"writtenOn": "2016-11-25T01:15:32Z",
|
|
"side": 1,
|
|
"message": "like common code in common places :)",
|
|
"revId": "817c027451df8b967955ad808a11f07baf63a742",
|
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
|
|
"unresolved": false
|
|
},
|
|
{
|
|
"key": {
|
|
"uuid": "5a74a57a_40aa7f71",
|
|
"filename": "helm/kolla-kubernetes/charts/openvswitch/charts/openvswitch-ovsdb/templates/openvswitch-ovsdb-daemonset.yaml",
|
|
"patchSetId": 2
|
|
},
|
|
"lineNbr": 71,
|
|
"author": {
|
|
"id": 2834
|
|
},
|
|
"writtenOn": "2016-11-25T01:15:32Z",
|
|
"side": 1,
|
|
"message": "could you explain why so that if people copy this code, they will understand the context?",
|
|
"revId": "817c027451df8b967955ad808a11f07baf63a742",
|
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
|
|
"unresolved": false
|
|
},
|
|
{
|
|
"key": {
|
|
"uuid": "5a74a57a_c0b4cfd2",
|
|
"filename": "helm/kolla-kubernetes/charts/openvswitch/charts/openvswitch-vswitchd/templates/openvswitch-vswitchd-configmap.yaml",
|
|
"patchSetId": 2
|
|
},
|
|
"lineNbr": 3,
|
|
"author": {
|
|
"id": 2834
|
|
},
|
|
"writtenOn": "2016-11-25T01:15:32Z",
|
|
"side": 1,
|
|
"message": "ignore previous comment on this point - now I understand why its baked into the chart. Can you un-bake it?",
|
|
"revId": "817c027451df8b967955ad808a11f07baf63a742",
|
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
|
|
"unresolved": false
|
|
},
|
|
{
|
|
"key": {
|
|
"uuid": "5a74a57a_34804ec0",
|
|
"filename": "helm/kolla-kubernetes/charts/openvswitch/charts/openvswitch-vswitchd/templates/openvswitch-vswitchd-configmap.yaml",
|
|
"patchSetId": 2
|
|
},
|
|
"lineNbr": 3,
|
|
"author": {
|
|
"id": 19384
|
|
},
|
|
"writtenOn": "2016-11-25T15:31:38Z",
|
|
"side": 1,
|
|
"message": "ok",
|
|
"parentUuid": "5a74a57a_c0b4cfd2",
|
|
"revId": "817c027451df8b967955ad808a11f07baf63a742",
|
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
|
|
"unresolved": false
|
|
},
|
|
{
|
|
"key": {
|
|
"uuid": "5a74a57a_c0ebefae",
|
|
"filename": "helm/kolla-kubernetes/charts/openvswitch/charts/openvswitch-vswitchd/templates/openvswitch-vswitchd-daemonset.yaml",
|
|
"patchSetId": 2
|
|
},
|
|
"lineNbr": 47,
|
|
"author": {
|
|
"id": 2834
|
|
},
|
|
"writtenOn": "2016-11-25T01:15:32Z",
|
|
"side": 1,
|
|
"message": "as per spec entrypoint needs to be optional.",
|
|
"revId": "817c027451df8b967955ad808a11f07baf63a742",
|
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
|
|
"unresolved": false
|
|
},
|
|
{
|
|
"key": {
|
|
"uuid": "5a74a57a_74eba678",
|
|
"filename": "helm/kolla-kubernetes/charts/openvswitch/charts/openvswitch-vswitchd/templates/openvswitch-vswitchd-daemonset.yaml",
|
|
"patchSetId": 2
|
|
},
|
|
"lineNbr": 47,
|
|
"author": {
|
|
"id": 19384
|
|
},
|
|
"writtenOn": "2016-11-25T15:31:38Z",
|
|
"side": 1,
|
|
"message": "It cannot be optional in this specific case as vswitchd needs openvswitch db socket to be created. It is important dependency which in my opinion is not conditional.",
|
|
"parentUuid": "5a74a57a_c0ebefae",
|
|
"revId": "817c027451df8b967955ad808a11f07baf63a742",
|
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
|
|
"unresolved": false
|
|
},
|
|
{
|
|
"key": {
|
|
"uuid": "5a74a57a_92659fb6",
|
|
"filename": "helm/kolla-kubernetes/charts/openvswitch/charts/openvswitch-vswitchd/templates/openvswitch-vswitchd-daemonset.yaml",
|
|
"patchSetId": 2
|
|
},
|
|
"lineNbr": 47,
|
|
"author": {
|
|
"id": 2834
|
|
},
|
|
"writtenOn": "2016-11-26T15:46:04Z",
|
|
"side": 1,
|
|
"message": "A comment here would be helpful to explain why this is special cased.",
|
|
"parentUuid": "5a74a57a_74eba678",
|
|
"revId": "817c027451df8b967955ad808a11f07baf63a742",
|
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
|
|
"unresolved": false
|
|
},
|
|
{
|
|
"key": {
|
|
"uuid": "5a74a57a_80e1f7d2",
|
|
"filename": "helm/kolla-kubernetes/charts/openvswitch/charts/openvswitch-vswitchd/templates/openvswitch-vswitchd-daemonset.yaml",
|
|
"patchSetId": 2
|
|
},
|
|
"lineNbr": 58,
|
|
"author": {
|
|
"id": 2834
|
|
},
|
|
"writtenOn": "2016-11-25T01:15:32Z",
|
|
"side": 1,
|
|
"message": "why 600? why not just sleep infinity or exit 0? (I don\u0027t know which one would be better).",
|
|
"range": {
|
|
"startLine": 58,
|
|
"startChar": 35,
|
|
"endLine": 58,
|
|
"endChar": 38
|
|
},
|
|
"revId": "817c027451df8b967955ad808a11f07baf63a742",
|
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
|
|
"unresolved": false
|
|
},
|
|
{
|
|
"key": {
|
|
"uuid": "5a74a57a_549dca08",
|
|
"filename": "helm/kolla-kubernetes/charts/openvswitch/charts/openvswitch-vswitchd/templates/openvswitch-vswitchd-daemonset.yaml",
|
|
"patchSetId": 2
|
|
},
|
|
"lineNbr": 58,
|
|
"author": {
|
|
"id": 19384
|
|
},
|
|
"writtenOn": "2016-11-25T15:31:38Z",
|
|
"side": 1,
|
|
"message": "Agree, it is debugging version, the final release will have \"exit 0\" as a command.",
|
|
"parentUuid": "5a74a57a_80e1f7d2",
|
|
"range": {
|
|
"startLine": 58,
|
|
"startChar": 35,
|
|
"endLine": 58,
|
|
"endChar": 38
|
|
},
|
|
"revId": "817c027451df8b967955ad808a11f07baf63a742",
|
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
|
|
"unresolved": false
|
|
},
|
|
{
|
|
"key": {
|
|
"uuid": "5a74a57a_40d8bf1d",
|
|
"filename": "helm/kolla-kubernetes/charts/openvswitch/charts/openvswitch-vswitchd/templates/openvswitch-vswitchd-daemonset.yaml",
|
|
"patchSetId": 2
|
|
},
|
|
"lineNbr": 81,
|
|
"author": {
|
|
"id": 2834
|
|
},
|
|
"writtenOn": "2016-11-25T01:15:32Z",
|
|
"side": 1,
|
|
"message": "same Q on config_strategy - isn\u0027t COPY_ONCE good enough? If not, why not?",
|
|
"revId": "817c027451df8b967955ad808a11f07baf63a742",
|
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
|
|
"unresolved": false
|
|
},
|
|
{
|
|
"key": {
|
|
"uuid": "5a74a57a_947922cb",
|
|
"filename": "helm/kolla-kubernetes/charts/openvswitch/charts/openvswitch-vswitchd/templates/openvswitch-vswitchd-daemonset.yaml",
|
|
"patchSetId": 2
|
|
},
|
|
"lineNbr": 81,
|
|
"author": {
|
|
"id": 19384
|
|
},
|
|
"writtenOn": "2016-11-25T15:31:38Z",
|
|
"side": 1,
|
|
"message": "I just wanted to preserve parity with kolla and kolla-ansible. If team decides to not use config strategy, I do not have any problem removing it.",
|
|
"parentUuid": "5a74a57a_40d8bf1d",
|
|
"revId": "817c027451df8b967955ad808a11f07baf63a742",
|
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
|
|
"unresolved": false
|
|
},
|
|
{
|
|
"key": {
|
|
"uuid": "5a74a57a_d25b97f4",
|
|
"filename": "helm/kolla-kubernetes/charts/openvswitch/charts/openvswitch-vswitchd/templates/openvswitch-vswitchd-daemonset.yaml",
|
|
"patchSetId": 2
|
|
},
|
|
"lineNbr": 81,
|
|
"author": {
|
|
"id": 2834
|
|
},
|
|
"writtenOn": "2016-11-26T15:46:04Z",
|
|
"side": 1,
|
|
"message": "The containers need to be fed a config strategy. From my limited understanding, if COPY_ONCE works, lets just stick to that. The less variables the better. The rationale for variable minimization is provided here:\n\nhttp://docs.openstack.org/developer/kolla/deployment-philosophy.html",
|
|
"parentUuid": "5a74a57a_947922cb",
|
|
"revId": "817c027451df8b967955ad808a11f07baf63a742",
|
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
|
|
"unresolved": false
|
|
},
|
|
{
|
|
"key": {
|
|
"uuid": "5a74a57a_a036f34f",
|
|
"filename": "helm/kolla-kubernetes/charts/openvswitch/charts/openvswitch-vswitchd/values.yaml",
|
|
"patchSetId": 2
|
|
},
|
|
"lineNbr": 13,
|
|
"author": {
|
|
"id": 2834
|
|
},
|
|
"writtenOn": "2016-11-25T01:15:32Z",
|
|
"side": 1,
|
|
"message": "when would these two variables be no?",
|
|
"revId": "817c027451df8b967955ad808a11f07baf63a742",
|
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
|
|
"unresolved": false
|
|
},
|
|
{
|
|
"key": {
|
|
"uuid": "5a74a57a_940e8239",
|
|
"filename": "helm/kolla-kubernetes/charts/openvswitch/charts/openvswitch-vswitchd/values.yaml",
|
|
"patchSetId": 2
|
|
},
|
|
"lineNbr": 13,
|
|
"author": {
|
|
"id": 19384
|
|
},
|
|
"writtenOn": "2016-11-25T15:31:38Z",
|
|
"side": 1,
|
|
"message": "Some operators do not use br-ex and use already existing bridge to plug openstack external interface. This two variables allow controlling this scenario.",
|
|
"parentUuid": "5a74a57a_a036f34f",
|
|
"revId": "817c027451df8b967955ad808a11f07baf63a742",
|
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
|
|
"unresolved": false
|
|
},
|
|
{
|
|
"key": {
|
|
"uuid": "5a74a57a_3254cbc8",
|
|
"filename": "helm/kolla-kubernetes/charts/openvswitch/charts/openvswitch-vswitchd/values.yaml",
|
|
"patchSetId": 2
|
|
},
|
|
"lineNbr": 13,
|
|
"author": {
|
|
"id": 2834
|
|
},
|
|
"writtenOn": "2016-11-26T15:46:04Z",
|
|
"side": 1,
|
|
"message": "A comment in the code would be helpful between line 11 and 12..",
|
|
"parentUuid": "5a74a57a_940e8239",
|
|
"revId": "817c027451df8b967955ad808a11f07baf63a742",
|
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
|
|
"unresolved": false
|
|
},
|
|
{
|
|
"key": {
|
|
"uuid": "5a74a57a_204bc3ca",
|
|
"filename": "helm/kolla-kubernetes/charts/openvswitch/values.yaml",
|
|
"patchSetId": 2
|
|
},
|
|
"lineNbr": 7,
|
|
"author": {
|
|
"id": 2834
|
|
},
|
|
"writtenOn": "2016-11-25T01:15:32Z",
|
|
"side": 1,
|
|
"message": "does kubernetes always guarantee ext_interface_name to be eth1?",
|
|
"revId": "817c027451df8b967955ad808a11f07baf63a742",
|
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
|
|
"unresolved": false
|
|
},
|
|
{
|
|
"key": {
|
|
"uuid": "5a74a57a_1f28cb85",
|
|
"filename": "helm/kolla-kubernetes/charts/openvswitch/values.yaml",
|
|
"patchSetId": 2
|
|
},
|
|
"lineNbr": 7,
|
|
"author": {
|
|
"id": 19384
|
|
},
|
|
"writtenOn": "2016-11-25T15:31:38Z",
|
|
"side": 1,
|
|
"message": "It is user configurable value, same as you have in kolla\u0027s globals.yml.",
|
|
"parentUuid": "5a74a57a_204bc3ca",
|
|
"revId": "817c027451df8b967955ad808a11f07baf63a742",
|
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
|
|
"unresolved": false
|
|
},
|
|
{
|
|
"key": {
|
|
"uuid": "5a74a57a_f24df33e",
|
|
"filename": "helm/kolla-kubernetes/charts/openvswitch/values.yaml",
|
|
"patchSetId": 2
|
|
},
|
|
"lineNbr": 7,
|
|
"author": {
|
|
"id": 2834
|
|
},
|
|
"writtenOn": "2016-11-26T15:46:04Z",
|
|
"side": 1,
|
|
"message": "is this the hosts ethernet interface or the interface within kubernetes?",
|
|
"parentUuid": "5a74a57a_1f28cb85",
|
|
"revId": "817c027451df8b967955ad808a11f07baf63a742",
|
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
|
|
"unresolved": false
|
|
},
|
|
{
|
|
"key": {
|
|
"uuid": "5a74a57a_00232706",
|
|
"filename": "helm/kolla-kubernetes/templates/_helpers.tpl",
|
|
"patchSetId": 2
|
|
},
|
|
"lineNbr": 24,
|
|
"author": {
|
|
"id": 2834
|
|
},
|
|
"writtenOn": "2016-11-25T01:15:32Z",
|
|
"side": 1,
|
|
"message": "ok confused - in one place CONFIG_STRATEGY is configurable here its not?",
|
|
"range": {
|
|
"startLine": 24,
|
|
"startChar": 0,
|
|
"endLine": 24,
|
|
"endChar": 22
|
|
},
|
|
"revId": "817c027451df8b967955ad808a11f07baf63a742",
|
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
|
|
"unresolved": false
|
|
},
|
|
{
|
|
"key": {
|
|
"uuid": "5a74a57a_5fa32300",
|
|
"filename": "helm/kolla-kubernetes/templates/_helpers.tpl",
|
|
"patchSetId": 2
|
|
},
|
|
"lineNbr": 24,
|
|
"author": {
|
|
"id": 19384
|
|
},
|
|
"writtenOn": "2016-11-25T15:31:38Z",
|
|
"side": 1,
|
|
"message": "Missed this spot to convert it into variable, will hold until we decide whether to use it or not in kolla-kubernetes.",
|
|
"parentUuid": "5a74a57a_00232706",
|
|
"range": {
|
|
"startLine": 24,
|
|
"startChar": 0,
|
|
"endLine": 24,
|
|
"endChar": 22
|
|
},
|
|
"revId": "817c027451df8b967955ad808a11f07baf63a742",
|
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
|
|
"unresolved": false
|
|
},
|
|
{
|
|
"key": {
|
|
"uuid": "5a74a57a_d212b708",
|
|
"filename": "helm/kolla-kubernetes/templates/_helpers.tpl",
|
|
"patchSetId": 2
|
|
},
|
|
"lineNbr": 24,
|
|
"author": {
|
|
"id": 2834
|
|
},
|
|
"writtenOn": "2016-11-26T15:46:04Z",
|
|
"side": 1,
|
|
"message": "if it works with COPY_ONCE lets just stick to that unless someone can come up with a good rationale for COPY_ALWAYS. I struggle to understand how COPY_ALWAYS would be usable since EmptyDir creates some kind of magic local to the pod storage. How would operators interact with EmptyDir?",
|
|
"parentUuid": "5a74a57a_5fa32300",
|
|
"range": {
|
|
"startLine": 24,
|
|
"startChar": 0,
|
|
"endLine": 24,
|
|
"endChar": 22
|
|
},
|
|
"revId": "817c027451df8b967955ad808a11f07baf63a742",
|
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
|
|
"unresolved": false
|
|
},
|
|
{
|
|
"key": {
|
|
"uuid": "5a74a57a_60613b39",
|
|
"filename": "helm/kolla-kubernetes/values.yaml",
|
|
"patchSetId": 2
|
|
},
|
|
"lineNbr": 6,
|
|
"author": {
|
|
"id": 2834
|
|
},
|
|
"writtenOn": "2016-11-25T01:15:32Z",
|
|
"side": 1,
|
|
"message": "whitespace",
|
|
"range": {
|
|
"startLine": 6,
|
|
"startChar": 38,
|
|
"endLine": 6,
|
|
"endChar": 39
|
|
},
|
|
"revId": "817c027451df8b967955ad808a11f07baf63a742",
|
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
|
|
"unresolved": false
|
|
},
|
|
{
|
|
"key": {
|
|
"uuid": "5a74a57a_7ff61ffa",
|
|
"filename": "helm/kolla-kubernetes/values.yaml",
|
|
"patchSetId": 2
|
|
},
|
|
"lineNbr": 6,
|
|
"author": {
|
|
"id": 19384
|
|
},
|
|
"writtenOn": "2016-11-25T15:31:38Z",
|
|
"side": 1,
|
|
"message": "Done",
|
|
"parentUuid": "5a74a57a_60613b39",
|
|
"range": {
|
|
"startLine": 6,
|
|
"startChar": 38,
|
|
"endLine": 6,
|
|
"endChar": 39
|
|
},
|
|
"revId": "817c027451df8b967955ad808a11f07baf63a742",
|
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
|
|
"unresolved": false
|
|
},
|
|
{
|
|
"key": {
|
|
"uuid": "5a74a57a_00d887ee",
|
|
"filename": "helm/kolla-kubernetes/values.yaml",
|
|
"patchSetId": 2
|
|
},
|
|
"lineNbr": 14,
|
|
"author": {
|
|
"id": 2834
|
|
},
|
|
"writtenOn": "2016-11-25T01:15:32Z",
|
|
"side": 1,
|
|
"message": "is there not some way to build this values.yaml default from a separate registry variable?",
|
|
"range": {
|
|
"startLine": 14,
|
|
"startChar": 36,
|
|
"endLine": 14,
|
|
"endChar": 55
|
|
},
|
|
"revId": "817c027451df8b967955ad808a11f07baf63a742",
|
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
|
|
"unresolved": false
|
|
},
|
|
{
|
|
"key": {
|
|
"uuid": "5a74a57a_df53b3e0",
|
|
"filename": "helm/kolla-kubernetes/values.yaml",
|
|
"patchSetId": 2
|
|
},
|
|
"lineNbr": 14,
|
|
"author": {
|
|
"id": 19384
|
|
},
|
|
"writtenOn": "2016-11-25T15:31:38Z",
|
|
"side": 1,
|
|
"message": "Absolutely, in the final version there will not be any hardcoded image names.",
|
|
"parentUuid": "5a74a57a_00d887ee",
|
|
"range": {
|
|
"startLine": 14,
|
|
"startChar": 36,
|
|
"endLine": 14,
|
|
"endChar": 55
|
|
},
|
|
"revId": "817c027451df8b967955ad808a11f07baf63a742",
|
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
|
|
"unresolved": false
|
|
},
|
|
{
|
|
"key": {
|
|
"uuid": "5a74a57a_2050235d",
|
|
"filename": "helm/kolla-kubernetes/values.yaml",
|
|
"patchSetId": 2
|
|
},
|
|
"lineNbr": 15,
|
|
"author": {
|
|
"id": 2834
|
|
},
|
|
"writtenOn": "2016-11-25T01:15:32Z",
|
|
"side": 1,
|
|
"message": "whitespace",
|
|
"range": {
|
|
"startLine": 15,
|
|
"startChar": 35,
|
|
"endLine": 15,
|
|
"endChar": 36
|
|
},
|
|
"revId": "817c027451df8b967955ad808a11f07baf63a742",
|
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
|
|
"unresolved": false
|
|
},
|
|
{
|
|
"key": {
|
|
"uuid": "5a74a57a_9fdf7b68",
|
|
"filename": "helm/kolla-kubernetes/values.yaml",
|
|
"patchSetId": 2
|
|
},
|
|
"lineNbr": 15,
|
|
"author": {
|
|
"id": 19384
|
|
},
|
|
"writtenOn": "2016-11-25T15:31:38Z",
|
|
"side": 1,
|
|
"message": "Done",
|
|
"parentUuid": "5a74a57a_2050235d",
|
|
"range": {
|
|
"startLine": 15,
|
|
"startChar": 35,
|
|
"endLine": 15,
|
|
"endChar": 36
|
|
},
|
|
"revId": "817c027451df8b967955ad808a11f07baf63a742",
|
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
|
|
"unresolved": false
|
|
}
|
|
]
|
|
} |