74 lines
2.6 KiB
Plaintext
74 lines
2.6 KiB
Plaintext
{
|
|
"comments": [
|
|
{
|
|
"key": {
|
|
"uuid": "5a74a57a_7062bb3f",
|
|
"filename": "helm/kolla-kubernetes/values.yaml",
|
|
"patchSetId": 6
|
|
},
|
|
"lineNbr": 10,
|
|
"author": {
|
|
"id": 2834
|
|
},
|
|
"writtenOn": "2016-11-27T06:16:30Z",
|
|
"side": 1,
|
|
"message": "Is the problem here this file is not templatable? Thinking this through to logical conclusion, it seems that if it were, it would be possible to override (e.g. kubernetes_entrypoint_image_tag) with kolla_tag so the entire release would use one set of tags, however a specific tag could be used for a specific image if someone wanted to get dangerous :)",
|
|
"revId": "9239970d69458f1e395d3bbe54537775bb906383",
|
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
|
|
"unresolved": false
|
|
},
|
|
{
|
|
"key": {
|
|
"uuid": "5a74a57a_c1a2df4a",
|
|
"filename": "helm/kolla-kubernetes/values.yaml",
|
|
"patchSetId": 6
|
|
},
|
|
"lineNbr": 10,
|
|
"author": {
|
|
"id": 19384
|
|
},
|
|
"writtenOn": "2016-11-27T14:23:44Z",
|
|
"side": 1,
|
|
"message": "That is correct, values.yaml is a mandatory and helm does not rendering it, so you cannot put helm variables, only yaml declarations go in it.\n\nWith tagging, I think it is easy solvable. We can check if more specific for image tag define then use it, otherwise use global tag kolla_tag.",
|
|
"parentUuid": "5a74a57a_7062bb3f",
|
|
"revId": "9239970d69458f1e395d3bbe54537775bb906383",
|
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
|
|
"unresolved": false
|
|
},
|
|
{
|
|
"key": {
|
|
"uuid": "5a74a57a_9067574c",
|
|
"filename": "helm/kolla-kubernetes/values.yaml",
|
|
"patchSetId": 6
|
|
},
|
|
"lineNbr": 11,
|
|
"author": {
|
|
"id": 2834
|
|
},
|
|
"writtenOn": "2016-11-27T06:16:30Z",
|
|
"side": 1,
|
|
"message": "I think what is needed here is a kolla_toolbox_image_tag",
|
|
"revId": "9239970d69458f1e395d3bbe54537775bb906383",
|
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
|
|
"unresolved": false
|
|
},
|
|
{
|
|
"key": {
|
|
"uuid": "5a74a57a_017777d3",
|
|
"filename": "helm/kolla-kubernetes/values.yaml",
|
|
"patchSetId": 6
|
|
},
|
|
"lineNbr": 11,
|
|
"author": {
|
|
"id": 19384
|
|
},
|
|
"writtenOn": "2016-11-27T14:23:44Z",
|
|
"side": 1,
|
|
"message": "will do the same as for entrypoint image.",
|
|
"parentUuid": "5a74a57a_9067574c",
|
|
"revId": "9239970d69458f1e395d3bbe54537775bb906383",
|
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
|
|
"unresolved": false
|
|
}
|
|
]
|
|
} |