kolla/tools/validate-all-dockerfiles.sh

#!/bin/bash

# Move to top level directory
REAL_PATH=$(realpath $0)
cd "$(dirname "$REAL_PATH")/.."

RES=0

find docker -name Dockerfile.j2 -print0 |
    xargs -0 tools/validate-maintainer.sh || RES=1

find docker -name Dockerfile.j2 -print0 |
    xargs -0 tools/validate-install-command.sh || RES=1

find docker -name Dockerfile.j2 -print0 |
    xargs -0 tools/validate-indentation.sh || RES=1

tools/validate-binary-build.sh || RES=1

exit $RES
Change the default shell to bash Unify the shell to bash in all Kolla scripts. Change-Id: Ib9591b2f8f344eb88455c5e9b7ecf2164fb5960a Implements: blueprint use-bash-shell 2015-04-27 11:59:55 +08:00			`#!/bin/bash`
add maintainer check to tests Change-Id: I6ee985e694142aa7dadeb085b77910667ac6359f 2014-10-22 11:12:50 -04:00
Make tools bash compatible Change-Id: Iccccc91b0a44f92bcbb2442638a93e7624da112b 2020-01-20 16:55:16 +03:00			`# Move to top level directory`
			`REAL_PATH=$(realpath $0)`
Make scripts work on latest Atomic images Remove git and jq dependency in most scripts, allowing to run them on latest atomic images, or even distribute Kolla in the form of tarball. The only remainings of git dependency are in the git pre-commit hook, and in the image build scripts. We can remove the latter one and have the scripts running in degraded mode if we really want to. I opted for a python based approach to finding the top-level directory for portability, ensuring consistent result on Linux and BSD, including OSX. Change-Id: I987174032d11b2e9d6a993c563b5dc877c15dd2d 2015-01-15 10:09:30 +09:00			`cd "$(dirname "$REAL_PATH")/.."`
add maintainer check to tests Change-Id: I6ee985e694142aa7dadeb085b77910667ac6359f 2014-10-22 11:12:50 -04:00
Validate Dockerfile indentation in pep8 Delegate code style validation to computers, they're better than human at it :) This commit adds a new `tools/validate-indentation.sh` script that errors when it finds an indented Dockerfile instruction, and enables the validation in the pep8 check. Also adjust the logic of `tools/validate-all-dockerfiles.sh` so that it doesn't stop on first errors but instead shows all of them. Fixes the remaining indentations in Dockerfiles. Change-Id: I53c0d38304cb4f6d64a5dfab67f70d69b3eae587 2017-12-05 10:48:08 +01:00			`RES=0`

			`find docker -name Dockerfile.j2 -print0 \|`
			`xargs -0 tools/validate-maintainer.sh \|\| RES=1`

Fix validate-all-maintainer.sh to look for Dockerfile.j2 And fix the fallout. Change-Id: Iccad3f4fdb0a6a7c14246df3408cae0425b833a5 2015-11-09 15:20:13 +10:00			`find docker -name Dockerfile.j2 -print0 \|`
Validate Dockerfile indentation in pep8 Delegate code style validation to computers, they're better than human at it :) This commit adds a new `tools/validate-indentation.sh` script that errors when it finds an indented Dockerfile instruction, and enables the validation in the pep8 check. Also adjust the logic of `tools/validate-all-dockerfiles.sh` so that it doesn't stop on first errors but instead shows all of them. Fixes the remaining indentations in Dockerfiles. Change-Id: I53c0d38304cb4f6d64a5dfab67f70d69b3eae587 2017-12-05 10:48:08 +01:00			`xargs -0 tools/validate-install-command.sh \|\| RES=1`
Add support to lint the install commands in Dockerfiles Change-Id: Icb47ba8b13b13889e28bb285321f11344400edc2 Closes-Bug:#1582618 2016-05-17 15:39:25 +05:30
			`find docker -name Dockerfile.j2 -print0 \|`
Validate Dockerfile indentation in pep8 Delegate code style validation to computers, they're better than human at it :) This commit adds a new `tools/validate-indentation.sh` script that errors when it finds an indented Dockerfile instruction, and enables the validation in the pep8 check. Also adjust the logic of `tools/validate-all-dockerfiles.sh` so that it doesn't stop on first errors but instead shows all of them. Fixes the remaining indentations in Dockerfiles. Change-Id: I53c0d38304cb4f6d64a5dfab67f70d69b3eae587 2017-12-05 10:48:08 +01:00			`xargs -0 tools/validate-indentation.sh \|\| RES=1`
Add support to lint the install commands in Dockerfiles Change-Id: Icb47ba8b13b13889e28bb285321f11344400edc2 Closes-Bug:#1582618 2016-05-17 15:39:25 +05:30
Add script to check for forbidden instructions When building images for binary type, it is expected to not install executables from untrusted sources, and gem, sensu-install, npm or pip packages for instance should come from the distro itself. This commit adds a `validate-binary-build.sh` script that checks for forbidden commands in the rendered Dockerfile templates for the binary type builds and hooks this script with the pep8 CI job. The output is just informative for now until we've fixed the culprit Dockerfiles, then we'll make the script return an error code and with the ability to fail the pep8 CI check. This should prevent unwanted commands from entering binary type Dockerfiles. Change-Id: I66e54bd18f4256cdca6c0c50626de4f975c246b8 2019-01-30 14:28:12 +01:00			`tools/validate-binary-build.sh \|\| RES=1`

Validate Dockerfile indentation in pep8 Delegate code style validation to computers, they're better than human at it :) This commit adds a new `tools/validate-indentation.sh` script that errors when it finds an indented Dockerfile instruction, and enables the validation in the pep8 check. Also adjust the logic of `tools/validate-all-dockerfiles.sh` so that it doesn't stop on first errors but instead shows all of them. Fixes the remaining indentations in Dockerfiles. Change-Id: I53c0d38304cb4f6d64a5dfab67f70d69b3eae587 2017-12-05 10:48:08 +01:00			`exit $RES`