Upgrade cinder playbook

Cinder requires a specific order for an upgrade.
c-api -> c-scheduler -> c-volume -> c-backup as
referenced by this patch: https://review.openstack.org/#/c/269412/6

We may be dependant on that Cinder patch linked above.  Behavior without
this patch is unknown.

Change-Id: I3fd1fe62abb398935932dab6ce905a65f8aabbd0
Co-authored-by: Paul Bourke <paul.bourke@oracle.com>
Partially-implements: blueprint upgrade-kolla
implements: blueprint upgrade-cinder

ansible/roles/cinder/tasks/bootstrap.yml

@@ -35,20 +35,5 @@
   run_once: True
   delegate_to: "{{ groups['cinder-api'][0] }}"
 
-- name: Running Cinder bootstrap container
-  kolla_docker:
-    action: "start_container"
-    common_options: "{{ docker_common_options }}"
-    detach: False
-    environment:
-      KOLLA_BOOTSTRAP:
-      KOLLA_CONFIG_STRATEGY: "{{ config_strategy }}"
-    image: "{{ cinder_api_image_full }}"
-    labels:
-      BOOTSTRAP:
-    name: "bootstrap_cinder"
-    restart_policy: "never"
-    volumes: "{{ node_config_directory }}/cinder-api/:{{ container_config_directory }}/:ro"
-  run_once: True
-  delegate_to: "{{ groups['cinder-api'][0] }}"
+- include: bootstrap_service.yml
   when: database_created

ansible/roles/cinder/tasks/bootstrap_service.yml

@@ -0,0 +1,17 @@
+---
+- name: Running Cinder bootstrap container
+  kolla_docker:
+    action: "start_container"
+    common_options: "{{ docker_common_options }}"
+    detach: False
+    environment:
+      KOLLA_BOOTSTRAP:
+      KOLLA_CONFIG_STRATEGY: "{{ config_strategy }}"
+    image: "{{ cinder_api_image_full }}"
+    labels:
+      BOOTSTRAP:
+    name: "bootstrap_cinder"
+    restart_policy: "never"
+    volumes: "{{ node_config_directory }}/cinder-api/:{{ container_config_directory }}/:ro"
+  run_once: True
+  delegate_to: "{{ groups['cinder-api'][0] }}"

ansible/roles/cinder/tasks/start.yml

@@ -10,19 +10,6 @@
       - "rsyslog_socket:/var/lib/kolla/rsyslog/"
   when: inventory_hostname in groups['cinder-api']
 
-- name: Starting cinder-backup container
-  kolla_docker:
-    action: "start_container"
-    common_options: "{{ docker_common_options }}"
-    name: "cinder_backup"
-    image: "{{ cinder_backup_image_full }}"
-    privileged: True
-    volumes:
-      - "{{ node_config_directory }}/cinder-backup/:{{ container_config_directory }}/:ro"
-      - "/dev/mapper/:/dev/mapper/"
-      - "rsyslog_socket:/var/lib/kolla/rsyslog/"
-  when: inventory_hostname in groups['cinder-backup']
-
 - name: Starting cinder-scheduler container
   kolla_docker:
     action: "start_container"
@@ -47,3 +34,16 @@
       - "/run/:/run/"
       - "rsyslog_socket:/var/lib/kolla/rsyslog/"
   when: inventory_hostname in groups['cinder-volume']
+
+- name: Starting cinder-backup container
+  kolla_docker:
+    action: "start_container"
+    common_options: "{{ docker_common_options }}"
+    name: "cinder_backup"
+    image: "{{ cinder_backup_image_full }}"
+    privileged: True
+    volumes:
+      - "{{ node_config_directory }}/cinder-backup/:{{ container_config_directory }}/:ro"
+      - "/run/kolla/log:/dev/log"
+      - "/dev/mapper/:/dev/mapper/"
+  when: inventory_hostname in groups['cinder-backup']

ansible/roles/cinder/tasks/upgrade.yml

@@ -1 +1,7 @@
 ---
+- include: config.yml
+
+- include: bootstrap_service.yml
+
+- include: start.yml
+  serial: "30%"