From e88e9bd29c81001784f99314bd007af80b931b55 Mon Sep 17 00:00:00 2001 From: Hui Kang Date: Wed, 4 Nov 2015 13:03:43 -0500 Subject: [PATCH] Add error handler for unknown build type Change-Id: Ia5d9ad1ffa119c2dd3e74272df3fb6d78501ec09 closes-Bug: #1513175 --- kolla/cmd/build.py | 11 ++++++++++- 1 file changed, 10 insertions(+), 1 deletion(-) diff --git a/kolla/cmd/build.py b/kolla/cmd/build.py index 7fb0f81455..9ad7104c0b 100755 --- a/kolla/cmd/build.py +++ b/kolla/cmd/build.py @@ -47,6 +47,10 @@ class KollaDirNotFoundException(Exception): pass +class KollaUnknownBuildTypeException(Exception): + pass + + class WorkerThread(Thread): def __init__(self, queue, config): @@ -260,7 +264,8 @@ def merge_args_and_config(settings_from_config_file): help='The base distro image tag', type=str) parser.add_argument('-t', '--type', - help='The method of the Openstack install', + help='The method of the Openstack install: binary,' + ' source, rdo, or rhos', type=str, dest='install_type') parser.add_argument('--no-cache', @@ -339,6 +344,10 @@ class KollaWorker(object): elif self.install_type == 'rhos': self.install_type = 'binary' self.install_metatype = 'rhos' + else: + raise KollaUnknownBuildTypeException( + 'Unknown install type' + ) self.image_prefix = self.base + '-' + self.install_type + '-'