flatten images a bit

As we have one type of images now some RUN calls could be merged so we
will have less layers in resulting images.

Change-Id: I5178c58fbd8c65efe825dc249c0f1368ef0fe8e0

docker/aodh/aodh-base/Dockerfile.j2

@@ -21,16 +21,15 @@ ADD aodh-base-archive /aodh-base-source
     '/aodh',
 ] %}
 
+COPY extend_start.sh /usr/local/bin/kolla_extend_start
+COPY aodh_sudoers /etc/sudoers.d/kolla_aodh_sudoers
+
 RUN ln -s aodh-base-source/* aodh \
     && {{ macros.install_pip(aodh_base_pip_packages | customizable("pip_packages")) }} \
     && mkdir -p /etc/aodh /var/www/cgi-bin/aodh \
     && cp /aodh/aodh/api/app.wsgi /var/www/cgi-bin/aodh \
-    && chown -R aodh: /etc/aodh /var/www/cgi-bin/aodh
+    && chown -R aodh: /etc/aodh /var/www/cgi-bin/aodh \
-
+    && chmod 750 /etc/sudoers.d \
-COPY extend_start.sh /usr/local/bin/kolla_extend_start
-COPY aodh_sudoers /etc/sudoers.d/kolla_aodh_sudoers
-
-RUN chmod 750 /etc/sudoers.d \
     && chmod 640 /etc/sudoers.d/kolla_aodh_sudoers \
     && chmod 755 /var/www/cgi-bin/aodh \
     && touch /usr/local/bin/kolla_aodh_extend_start \

docker/barbican/barbican-base/Dockerfile.j2

@@ -25,16 +25,16 @@ LABEL maintainer="{{ maintainer }}" name="{{ image_name }}" build-date="{{ build
 ] %}
 
 ADD barbican-base-archive /barbican-base-source
-RUN ln -s barbican-base-source/* barbican \
-    && {{ macros.install_pip(barbican_base_pip_packages | customizable("pip_packages")) }} \
-    && mkdir -p /etc/barbican \
-    && cp -r /barbican/etc/barbican/* /etc/barbican/ \
-    && chown -R barbican: /etc/barbican
 
 COPY barbican_sudoers /etc/sudoers.d/kolla_barbican_sudoers
 COPY extend_start.sh /usr/local/bin/kolla_extend_start
 
-RUN chmod 750 /etc/sudoers.d \
+RUN ln -s barbican-base-source/* barbican \
+    && {{ macros.install_pip(barbican_base_pip_packages | customizable("pip_packages")) }} \
+    && mkdir -p /etc/barbican \
+    && cp -r /barbican/etc/barbican/* /etc/barbican/ \
+    && chown -R barbican: /etc/barbican \
+    && chmod 750 /etc/sudoers.d \
     && chmod 640 /etc/sudoers.d/kolla_barbican_sudoers \
     && touch /usr/local/bin/kolla_barbican_extend_start \
     && chmod 644 /usr/local/bin/kolla_extend_start /usr/local/bin/kolla_barbican_extend_start

docker/blazar/blazar-base/Dockerfile.j2

@@ -15,15 +15,14 @@ ADD blazar-base-archive /blazar-base-source
     '/blazar'
 ] %}
 
+COPY extend_start.sh /usr/local/bin/kolla_extend_start
+
 RUN ln -s blazar-base-source/* blazar \
     && {{ macros.install_pip(blazar_base_pip_packages | customizable("pip_packages")) }} \
     && mkdir -p /etc/blazar \
     && cp -r /blazar/etc/blazar/* /etc/blazar \
-    && chown -R blazar: /etc/blazar
+    && chown -R blazar: /etc/blazar \
-
+    && touch /usr/local/bin/kolla_blazar_extend_start \
-COPY extend_start.sh /usr/local/bin/kolla_extend_start
-
-RUN touch /usr/local/bin/kolla_blazar_extend_start \
     && chmod 644 /usr/local/bin/kolla_extend_start /usr/local/bin/kolla_blazar_extend_start
 
 {% block blazar_base_footer %}{% endblock %}

docker/ceilometer/ceilometer-base/Dockerfile.j2

@@ -19,6 +19,10 @@ LABEL maintainer="{{ maintainer }}" name="{{ image_name }}" build-date="{{ build
 
 ADD ceilometer-base-archive /ceilometer-base-source
 ADD plugins-archive /
+
+COPY ceilometer_sudoers /etc/sudoers.d/kolla_ceilometer_sudoers
+COPY extend_start.sh /usr/local/bin/kolla_extend_start
+
 # NOTE(egonzalez): Remove ceilometer from constraint or will fail.
 RUN ln -s ceilometer-base-source/* ceilometer \
     && sed -i 's|^ceilometer===.*$||g' requirements/upper-constraints.txt \
@@ -29,12 +33,8 @@ RUN ln -s ceilometer-base-source/* ceilometer \
     && sed -i 's|^exec_dirs.*|exec_dirs=/var/lib/kolla/venv/bin,/sbin,/usr/sbin,/bin,/usr/bin,/usr/local/bin,/usr/local/sbin|g' /etc/ceilometer/rootwrap.conf \
     && if [ "$(ls /plugins)" ]; then \
         {{ macros.install_pip(ceilometer_base_plugins_pip_packages) }}; \
-    fi
+    fi \
-
+    && chmod 750 /etc/sudoers.d \
-COPY ceilometer_sudoers /etc/sudoers.d/kolla_ceilometer_sudoers
-COPY extend_start.sh /usr/local/bin/kolla_extend_start
-
-RUN chmod 750 /etc/sudoers.d \
     && chmod 440 /etc/sudoers.d/kolla_ceilometer_sudoers \
     && touch /usr/local/bin/kolla_ceilometer_extend_start \
     && chmod 644 /usr/local/bin/kolla_extend_start /usr/local/bin/kolla_ceilometer_extend_start

docker/cinder/cinder-api/Dockerfile.j2

@@ -12,11 +12,11 @@ LABEL maintainer="{{ maintainer }}" name="{{ image_name }}" build-date="{{ build
 
 {{ macros.install_packages(cinder_api_packages | customizable("packages")) }}
 
-RUN mkdir -p /var/www/cgi-bin/cinder \
-    && cp -a /var/lib/kolla/venv/bin/cinder-wsgi /var/www/cgi-bin/cinder/cinder-wsgi
-
 COPY extend_start.sh /usr/local/bin/kolla_cinder_extend_start
-RUN chmod 755 /usr/local/bin/kolla_cinder_extend_start \
+
+RUN mkdir -p /var/www/cgi-bin/cinder \
+    && cp -a /var/lib/kolla/venv/bin/cinder-wsgi /var/www/cgi-bin/cinder/cinder-wsgi \
+    && chmod 755 /usr/local/bin/kolla_cinder_extend_start \
     && chown -R cinder: /var/www/cgi-bin/cinder \
     && chmod 755 /var/www/cgi-bin/cinder/cinder-wsgi
 

docker/cinder/cinder-base/Dockerfile.j2

@@ -36,17 +36,17 @@ LABEL maintainer="{{ maintainer }}" name="{{ image_name }}" build-date="{{ build
 ] %}
 
 ADD cinder-base-archive /cinder-base-source
+
+COPY cinder_sudoers /etc/sudoers.d/kolla_cinder_sudoers
+COPY extend_start.sh /usr/local/bin/kolla_extend_start
+
 RUN ln -s cinder-base-source/* cinder \
     && {{ macros.install_pip(cinder_base_pip_packages | customizable("pip_packages")) }} \
     && mkdir -p /etc/cinder \
     && cp -r /cinder/etc/cinder/* /etc/cinder/ \
     && chown -R cinder: /etc/cinder \
-    && sed -i 's|^exec_dirs.*|exec_dirs=/var/lib/kolla/venv/bin,/sbin,/usr/sbin,/bin,/usr/bin,/usr/local/bin,/usr/local/sbin|g' /etc/cinder/rootwrap.conf
+    && sed -i 's|^exec_dirs.*|exec_dirs=/var/lib/kolla/venv/bin,/sbin,/usr/sbin,/bin,/usr/bin,/usr/local/bin,/usr/local/sbin|g' /etc/cinder/rootwrap.conf \
-
+    && chmod 750 /etc/sudoers.d \
-COPY cinder_sudoers /etc/sudoers.d/kolla_cinder_sudoers
-COPY extend_start.sh /usr/local/bin/kolla_extend_start
-
-RUN chmod 750 /etc/sudoers.d \
     && chmod 440 /etc/sudoers.d/kolla_cinder_sudoers \
     && touch /usr/local/bin/kolla_cinder_extend_start \
     && chmod 644 /usr/local/bin/kolla_extend_start /usr/local/bin/kolla_cinder_extend_start

docker/cloudkitty/cloudkitty-base/Dockerfile.j2

@@ -14,15 +14,15 @@ LABEL maintainer="{{ maintainer }}" name="{{ image_name }}" build-date="{{ build
 ] %}
 
 ADD cloudkitty-base-archive /cloudkitty-base-source
+
+COPY extend_start.sh /usr/local/bin/kolla_extend_start
+
 RUN ln -s cloudkitty-base-source/* cloudkitty \
     && {{ macros.install_pip(cloudkitty_base_pip_packages | customizable("pip_packages")) }} \
     && mkdir -p /etc/cloudkitty  \
     && cp -r /cloudkitty/etc/cloudkitty/* /etc/cloudkitty/ \
-    && chown -R cloudkitty: /etc/cloudkitty
+    && chown -R cloudkitty: /etc/cloudkitty \
-
+    && touch /usr/local/bin/kolla_cloudkitty_extend_start \
-COPY extend_start.sh /usr/local/bin/kolla_extend_start
-
-RUN touch /usr/local/bin/kolla_cloudkitty_extend_start \
     && chmod 644 /usr/local/bin/kolla_extend_start /usr/local/bin/kolla_cloudkitty_extend_start
 
 {% block cloudkitty_base_footer %}{% endblock %}

docker/cyborg/cyborg-base/Dockerfile.j2

@@ -15,15 +15,14 @@ ADD cyborg-base-archive /cyborg-base-source
     '/cyborg'
 ] %}
 
-RUN ln -s cyborg-base-source/* cyborg \
-    && {{ macros.install_pip(cyborg_base_pip_packages | customizable("pip_packages")) }} \
-    && mkdir -p /etc/cyborg/ \
-    && cp -r /cyborg/etc/cyborg/* /etc/cyborg/
-
 COPY extend_start.sh /usr/local/bin/kolla_extend_start
 COPY cyborg_sudoers /etc/sudoers.d/kolla_cyborg_sudoers
 
-RUN chmod 750 /etc/sudoers.d \
+RUN ln -s cyborg-base-source/* cyborg \
+    && {{ macros.install_pip(cyborg_base_pip_packages | customizable("pip_packages")) }} \
+    && mkdir -p /etc/cyborg/ \
+    && cp -r /cyborg/etc/cyborg/* /etc/cyborg/ \
+    && chmod 750 /etc/sudoers.d \
     && touch /usr/local/bin/kolla_cyborg_extend_start \
     && chmod 644 /usr/local/bin/kolla_extend_start /usr/local/bin/kolla_cyborg_extend_start
 

docker/designate/designate-base/Dockerfile.j2

@@ -14,18 +14,18 @@ LABEL maintainer="{{ maintainer }}" name="{{ image_name }}" build-date="{{ build
 ] %}
 
 ADD designate-base-archive /designate-base-source
+
+COPY designate_sudoers /etc/sudoers.d/kolla_designate_sudoers
+COPY extend_start.sh /usr/local/bin/kolla_extend_start
+
 RUN ln -s designate-base-source/* designate \
     && {{ macros.install_pip(designate_base_pip_packages | customizable("pip_packages")) }} \
     && mkdir -p /etc/designate \
     && cp -r /designate/etc/designate/* /etc/designate/ \
     && mv /etc/designate/rootwrap.conf.sample /etc/designate/rootwrap.conf \
     && chown -R designate: /etc/designate \
-    && sed -i 's|^exec_dirs.*|exec_dirs=/var/lib/kolla/venv/bin,/sbin,/usr/sbin,/bin,/usr/bin,/usr/local/bin,/usr/local/sbin|g' /etc/designate/rootwrap.conf
+    && sed -i 's|^exec_dirs.*|exec_dirs=/var/lib/kolla/venv/bin,/sbin,/usr/sbin,/bin,/usr/bin,/usr/local/bin,/usr/local/sbin|g' /etc/designate/rootwrap.conf \
-
+    && chmod 750 /etc/sudoers.d \
-COPY designate_sudoers /etc/sudoers.d/kolla_designate_sudoers
-COPY extend_start.sh /usr/local/bin/kolla_extend_start
-
-RUN chmod 750 /etc/sudoers.d \
     && chmod 640 /etc/sudoers.d/kolla_designate_sudoers \
     && touch /usr/local/bin/kolla_designate_extend_start \
     && chmod 644 /usr/local/bin/kolla_extend_start /usr/local/bin/kolla_designate_extend_start

docker/elasticsearch/elasticsearch-curator/Dockerfile.j2

@@ -30,13 +30,13 @@ LABEL maintainer="{{ maintainer }}" name="{{ image_name }}" build-date="{{ build
     'elasticsearch-curator'
 ] %}
 
+COPY extend_start.sh /usr/local/bin/kolla_extend_start
+
 RUN {{ macros.install_pip(['pip', 'wheel', 'setuptools'], constraints=false) }} \
     && {{ macros.install_pip(elasticsearch_curator_pip_packages | customizable("pip_packages"), constraints=false) }} \
     && mkdir -p /etc/elasticsearch-curator \
-    && chown -R elasticsearch: /etc/elasticsearch-curator
+    && chown -R elasticsearch: /etc/elasticsearch-curator \
-
+    && chmod 644 /usr/local/bin/kolla_extend_start
-COPY extend_start.sh /usr/local/bin/kolla_extend_start
-RUN chmod 644 /usr/local/bin/kolla_extend_start
 
 {% block elasticsearch_curator_base_footer %}{% endblock %}
 {% block footer %}{% endblock %}

docker/fluentd/Dockerfile.j2

@@ -31,22 +31,20 @@ LABEL maintainer="{{ maintainer }}" name="{{ image_name }}" build-date="{{ build
 
 {{ macros.configure_user(name=fluentd_user, groups='mysql') }}
 
+COPY fluentd_sudoers /etc/sudoers.d/kolla_fluentd_sudoers
+COPY extend_start.sh /usr/local/bin/kolla_extend_start
+
 # NOTE(frickler): Downgrading elasticsearch gems for compatibility with OSS versions of ES
 {{ macros.install_packages(fluentd_packages | customizable("packages")) }} \
     && td-agent-gem install elasticsearch:7.13.0 \
     && td-agent-gem uninstall "elasticsearch:>7.13.0" \
     && td-agent-gem uninstall "elasticsearch-api:>7.13.0" \
-    && td-agent-gem uninstall "elasticsearch-transport:>7.13.0"
+    && td-agent-gem uninstall "elasticsearch-transport:>7.13.0" \
-
+    && chmod 440 /etc/sudoers.d/kolla_fluentd_sudoers \
-COPY fluentd_sudoers /etc/sudoers.d/kolla_fluentd_sudoers
-
-RUN chmod 440 /etc/sudoers.d/kolla_fluentd_sudoers \
     && mkdir -p /etc/{{ fluentd_user }} \
     && mkdir -p /var/run/{{ fluentd_user }} \
-    && chown -R {{ fluentd_user }}: /etc/{{ fluentd_user }} /var/run/{{ fluentd_user }}
+    && chown -R {{ fluentd_user }}: /etc/{{ fluentd_user }} /var/run/{{ fluentd_user }} \
-
+    && chmod 644 /usr/local/bin/kolla_extend_start
-COPY extend_start.sh /usr/local/bin/kolla_extend_start
-RUN chmod 644 /usr/local/bin/kolla_extend_start
 
 {% block fluentd_plugins_install %}
 

docker/freezer/freezer-api/Dockerfile.j2

@@ -18,12 +18,12 @@ ADD freezer-api-archive /freezer-api-source
     '/freezer-api'
 ] %}
 
+COPY extend_start.sh /usr/local/bin/kolla_freezer_extend_start
+
 RUN ln -s freezer-api-source/* freezer-api \
     && {{ macros.install_pip(freezer_api_pip_packages | customizable("pip_packages")) }} \
-    && cp -r /freezer-api/etc/freezer/* /etc/freezer/
+    && cp -r /freezer-api/etc/freezer/* /etc/freezer/ \
-
+    && chmod 755 /usr/local/bin/kolla_freezer_extend_start
-COPY extend_start.sh /usr/local/bin/kolla_freezer_extend_start
-RUN chmod 755 /usr/local/bin/kolla_freezer_extend_start
 
 {% block freezer_api_footer %}{% endblock %}
 {% block footer %}{% endblock %}

docker/freezer/freezer-base/Dockerfile.j2

@@ -22,16 +22,15 @@ ADD freezer-base-archive /freezer-base-source
     '/freezer'
 ] %}
 
+COPY freezer_sudoers /etc/sudoers.d/kolla_freezer_sudoers
+COPY extend_start.sh /usr/local/bin/kolla_extend_start
+
 RUN ln -s freezer-base-source/* freezer \
     && mkdir -p /etc/freezer \
     && chown -R freezer: /etc/freezer \
     && {{ macros.install_pip(freezer_base_pip_packages | customizable("pip_packages")) }} \
-    && cp -r /freezer/etc/* /etc/freezer
+    && cp -r /freezer/etc/* /etc/freezer \
-
+    && chmod 750 /etc/sudoers.d \
-COPY freezer_sudoers /etc/sudoers.d/kolla_freezer_sudoers
-COPY extend_start.sh /usr/local/bin/kolla_extend_start
-
-RUN chmod 750 /etc/sudoers.d \
     && chmod 640 /etc/sudoers.d/kolla_freezer_sudoers \
     && touch /usr/local/bin/kolla_freezer_extend_start \
     && chmod 644 /usr/local/bin/kolla_extend_start /usr/local/bin/kolla_freezer_extend_start

docker/glance/glance-base/Dockerfile.j2

@@ -34,18 +34,16 @@ ADD glance-base-archive /glance-base-source
 
 # add missing rootwrap config present in glance_store repo
 COPY etc/glance /etc/glance
+COPY glance_sudoers /etc/sudoers.d/kolla_glance_sudoers
+COPY extend_start.sh /usr/local/bin/kolla_extend_start
 
 RUN ln -s glance-base-source/* glance \
     && {{ macros.install_pip(glance_base_pip_packages | customizable("pip_packages")) }} \
     && mkdir -p /etc/glance \
     && cp -r /glance/etc/* /etc/glance/ \
     && chown -R glance: /etc/glance \
-    && sed -i 's|^exec_dirs.*|exec_dirs=/var/lib/kolla/venv/bin,/sbin,/usr/sbin,/bin,/usr/bin,/usr/local/bin,/usr/local/sbin|g' /etc/glance/rootwrap.conf
+    && sed -i 's|^exec_dirs.*|exec_dirs=/var/lib/kolla/venv/bin,/sbin,/usr/sbin,/bin,/usr/bin,/usr/local/bin,/usr/local/sbin|g' /etc/glance/rootwrap.conf \
-
+    && chmod 750 /etc/sudoers.d \
-COPY glance_sudoers /etc/sudoers.d/kolla_glance_sudoers
-COPY extend_start.sh /usr/local/bin/kolla_extend_start
-
-RUN chmod 750 /etc/sudoers.d \
     && chmod 440 /etc/sudoers.d/kolla_glance_sudoers \
     && touch /usr/local/bin/kolla_glance_extend_start \
     && chmod 644 /usr/local/bin/kolla_extend_start /usr/local/bin/kolla_glance_extend_start

docker/gnocchi/gnocchi-base/Dockerfile.j2

@@ -38,15 +38,14 @@ ADD gnocchi-base-archive /gnocchi-base-source
     '/gnocchi[keystone,mysql,file,ceph,s3]'
 ] %}
 
-RUN ln -s gnocchi-base-source/* gnocchi \
-    && {{ macros.install_pip(gnocchi_base_pip_packages | customizable("pip_packages")) }} \
-    && mkdir -p /etc/gnocchi \
-    && chown -R gnocchi: /etc/gnocchi
-
 COPY extend_start.sh /usr/local/bin/kolla_extend_start
 COPY gnocchi_sudoers /etc/sudoers.d/kolla_gnocchi_sudoers
 
-RUN chmod 750 /etc/sudoers.d \
+RUN ln -s gnocchi-base-source/* gnocchi \
+    && {{ macros.install_pip(gnocchi_base_pip_packages | customizable("pip_packages")) }} \
+    && mkdir -p /etc/gnocchi \
+    && chown -R gnocchi: /etc/gnocchi \
+    && chmod 750 /etc/sudoers.d \
     && chmod 640 /etc/sudoers.d/kolla_gnocchi_sudoers \
     && touch /usr/local/bin/kolla_gnocchi_extend_start \
     && chmod 644 /usr/local/bin/kolla_extend_start /usr/local/bin/kolla_gnocchi_extend_start

docker/haproxy/Dockerfile.j2

@@ -16,11 +16,11 @@ LABEL maintainer="{{ maintainer }}" name="{{ image_name }}" build-date="{{ build
 ] %}
 {{ macros.install_packages(haproxy_packages | customizable("packages")) }}
 
-RUN mkdir -p /var/lib/kolla/haproxy \
-    && chown -R haproxy: /var/lib /run
-
 COPY ensure_latest_config.sh /usr/local/bin/kolla_ensure_haproxy_latest_config
-RUN chmod 755 /usr/local/bin/kolla_ensure_haproxy_latest_config
+
+RUN mkdir -p /var/lib/kolla/haproxy \
+    && chown -R haproxy: /var/lib /run \
+    && chmod 755 /usr/local/bin/kolla_ensure_haproxy_latest_config
 
 {% block haproxy_footer %}{% endblock %}
 {% block footer %}{% endblock %}

docker/heat/heat-base/Dockerfile.j2

@@ -21,15 +21,14 @@ ADD heat-base-archive /heat-base-source
     '/heat'
 ] %}
 
+COPY extend_start.sh /usr/local/bin/kolla_extend_start
+
 RUN ln -s heat-base-source/* heat \
     && {{ macros.install_pip(heat_base_pip_packages | customizable("pip_packages")) }} \
     && mkdir -p /etc/heat \
     && cp -r /heat/etc/heat/* /etc/heat/ \
-    && chown -R heat: /etc/heat
+    && chown -R heat: /etc/heat \
-
+    && touch /usr/local/bin/kolla_heat_extend_start \
-COPY extend_start.sh /usr/local/bin/kolla_extend_start
-
-RUN touch /usr/local/bin/kolla_heat_extend_start \
     && chmod 644 /usr/local/bin/kolla_extend_start /usr/local/bin/kolla_heat_extend_start
 
 {% block heat_base_footer %}{% endblock %}

docker/horizon/Dockerfile.j2

@@ -44,6 +44,8 @@ ADD plugins-archive /
     '/plugins/*'
 ] %}
 
+COPY extend_start.sh /usr/local/bin/kolla_extend_start
+
 # NOTE(hrw): to install horizon from unpacked sources we cannot have it in upper-constraints.txt
 RUN ln -s horizon-source/* horizon \
     && sed -i /^horizon=/d /requirements/upper-constraints.txt \
@@ -58,10 +60,8 @@ RUN ln -s horizon-source/* horizon \
     && for locale in  /var/lib/kolla/venv/lib/python{{distro_python_version}}/site-packages/*/locale; do \
            (cd ${locale%/*} && /var/lib/kolla/venv/bin/django-admin compilemessages) \
        done \
-    && chown -R horizon: /etc/openstack-dashboard
+    && chown -R horizon: /etc/openstack-dashboard \
-
+    && chmod 644 /usr/local/bin/kolla_extend_start
-COPY extend_start.sh /usr/local/bin/kolla_extend_start
-RUN chmod 644 /usr/local/bin/kolla_extend_start
 
 {% block horizon_footer %}{% endblock %}
 {% block footer %}{% endblock %}

docker/ironic-inspector/Dockerfile.j2

@@ -18,25 +18,23 @@ LABEL maintainer="{{ maintainer }}" name="{{ image_name }}" build-date="{{ build
 {{ macros.install_packages(ironic_inspector_packages | customizable("packages")) }}
 
 ADD ironic-inspector-archive /ironic-inspector-source
+ADD ironic_inspector_sudoers /etc/sudoers.d/kolla_ironic_inspector_sudoers
 
 {% set ironic_inspector_pip_packages = [
     '/ironic-inspector'
 ] %}
 
+COPY extend_start.sh /usr/local/bin/kolla_extend_start
+
 RUN ln -s ironic-inspector-source/* ironic-inspector \
     && {{ macros.install_pip(ironic_inspector_pip_packages | customizable("pip_packages")) }} \
     && mkdir -p /etc/ironic-inspector \
     && cp /ironic-inspector/rootwrap.conf /etc/ironic-inspector/ \
     && cp -r /ironic-inspector/rootwrap.d/ /etc/ironic-inspector/ \
-    && sed -i 's|^exec_dirs.*|exec_dirs=/var/lib/kolla/venv/bin,/sbin,/usr/sbin,/bin,/usr/bin,/usr/local/bin,/usr/local/sbin|g' /etc/ironic-inspector/rootwrap.conf
+    && sed -i 's|^exec_dirs.*|exec_dirs=/var/lib/kolla/venv/bin,/sbin,/usr/sbin,/bin,/usr/bin,/usr/local/bin,/usr/local/sbin|g' /etc/ironic-inspector/rootwrap.conf \
-
+    && chmod 750 /etc/sudoers.d \
-ADD ironic_inspector_sudoers /etc/sudoers.d/kolla_ironic_inspector_sudoers
+    && chmod 440 /etc/sudoers.d/kolla_ironic_inspector_sudoers \
-RUN chmod 750 /etc/sudoers.d \
+    && chmod 644 /usr/local/bin/kolla_extend_start \
-    && chmod 440 /etc/sudoers.d/kolla_ironic_inspector_sudoers
-
-COPY extend_start.sh /usr/local/bin/kolla_extend_start
-
-RUN chmod 644 /usr/local/bin/kolla_extend_start \
     && mkdir -p /var/lib/ironic-inspector/dhcp-hostsdir \
     && chown -R ironic-inspector: /etc/ironic-inspector /var/lib/ironic-inspector
 

docker/ironic/ironic-base/Dockerfile.j2

@@ -10,25 +10,23 @@ LABEL maintainer="{{ maintainer }}" name="{{ image_name }}" build-date="{{ build
 {{ macros.configure_user(name='ironic') }}
 
 ADD ironic-base-archive /ironic-base-source
+ADD ironic_sudoers /etc/sudoers.d/kolla_ironic_sudoers
 
 {% set ironic_base_pip_packages = [
     '/ironic'
 ] %}
 
+COPY extend_start.sh /usr/local/bin/kolla_extend_start
+
 RUN ln -s ironic-base-source/* ironic \
     && {{ macros.install_pip(ironic_base_pip_packages | customizable("pip_packages")) }} \
     && mkdir -p /etc/ironic \
     && cp -r /var/lib/kolla/venv/etc/ironic/* /etc/ironic/ \
     && chown -R ironic: /etc/ironic \
-    && sed -i 's|^exec_dirs.*|exec_dirs=/var/lib/kolla/venv/bin,/sbin,/usr/sbin,/bin,/usr/bin,/usr/local/bin,/usr/local/sbin|g' /etc/ironic/rootwrap.conf
+    && sed -i 's|^exec_dirs.*|exec_dirs=/var/lib/kolla/venv/bin,/sbin,/usr/sbin,/bin,/usr/bin,/usr/local/bin,/usr/local/sbin|g' /etc/ironic/rootwrap.conf \
-
+    && chmod 750 /etc/sudoers.d \
-ADD ironic_sudoers /etc/sudoers.d/kolla_ironic_sudoers
+    && chmod 440 /etc/sudoers.d/kolla_ironic_sudoers \
-RUN chmod 750 /etc/sudoers.d \
+    && touch /usr/local/bin/kolla_ironic_extend_start \
-    && chmod 440 /etc/sudoers.d/kolla_ironic_sudoers
-
-COPY extend_start.sh /usr/local/bin/kolla_extend_start
-
-RUN touch /usr/local/bin/kolla_ironic_extend_start \
     && chmod 644 /usr/local/bin/kolla_extend_start /usr/local/bin/kolla_ironic_extend_start \
     && chown -R ironic: /etc/ironic
 

docker/keystone/keystone-ssh/Dockerfile.j2

@@ -31,10 +31,10 @@ RUN mkdir -p /var/run/sshd \
 {% endif %}
 {{ macros.install_packages(keystone_ssh_packages | customizable("packages")) }}
 
-RUN sed -ri 's/session(\s+)required(\s+)pam_loginuid.so/session\1optional\2pam_loginuid.so/' /etc/pam.d/sshd
-
 COPY extend_start.sh /usr/local/bin/kolla_extend_start
-RUN chmod 644 /usr/local/bin/kolla_extend_start
+
+RUN sed -ri 's/session(\s+)required(\s+)pam_loginuid.so/session\1optional\2pam_loginuid.so/' /etc/pam.d/sshd \
+    && chmod 644 /usr/local/bin/kolla_extend_start
 
 {% block keystone_ssh_footer %}{% endblock %}
 {% block footer %}{% endblock %}

docker/keystone/keystone/Dockerfile.j2

@@ -7,11 +7,6 @@ LABEL maintainer="{{ maintainer }}" name="{{ image_name }}" build-date="{{ build
 
 {% import "macros.j2" as macros with context %}
 
-COPY keystone_bootstrap.sh /usr/local/bin/kolla_keystone_bootstrap
-COPY extend_start.sh /usr/local/bin/kolla_extend_start
-RUN chmod 644 /usr/local/bin/kolla_extend_start \
-    && chmod 755 /usr/local/bin/kolla_keystone_bootstrap
-
 {% if base_package_type == 'rpm' %}
     {% set keystone_packages = [
         'mod_auth_gssapi',
@@ -29,7 +24,12 @@ ADD plugins-archive /
     'requests-kerberos',
 ] %}
 
-RUN if [ "$(ls /plugins)" ]; then \
+COPY keystone_bootstrap.sh /usr/local/bin/kolla_keystone_bootstrap
+COPY extend_start.sh /usr/local/bin/kolla_extend_start
+
+RUN chmod 644 /usr/local/bin/kolla_extend_start \
+    && chmod 755 /usr/local/bin/kolla_keystone_bootstrap \
+    && if [ "$(ls /plugins)" ]; then \
         {{ macros.install_pip(keystone_plugins_pip_packages) }}; \
     fi
 

docker/kolla-toolbox/Dockerfile.j2

@@ -95,14 +95,13 @@ ENV ANSIBLE_LIBRARY /usr/share/ansible:$ANSIBLE_LIBRARY
 
 COPY find_disks.py /usr/share/ansible/
 COPY ansible.cfg /etc/ansible/ansible.cfg
-RUN chmod 644 /usr/share/ansible/find_disks.py \
-              /etc/ansible/ansible.cfg
-
 COPY ansible_sudoers /etc/sudoers.d/kolla_ansible_sudoers
-RUN chmod 440 /etc/sudoers.d/kolla_ansible_sudoers
-
 COPY extend_start.sh /usr/local/bin/kolla_extend_start
-RUN chmod 644 /usr/local/bin/kolla_extend_start
+
+RUN chmod 644 /usr/share/ansible/find_disks.py \
+              /etc/ansible/ansible.cfg \
+              /usr/local/bin/kolla_extend_start \
+    && chmod 440 /etc/sudoers.d/kolla_ansible_sudoers
 
 {% block kolla_toolbox_footer %}{% endblock %}
 {% block footer %}{% endblock %}

docker/kuryr/kuryr-base/Dockerfile.j2

@@ -15,15 +15,15 @@ ADD kuryr-base-archive /kuryr-base-source
     '/kuryr-base'
 ] %}
 
+COPY extend_start.sh /usr/local/bin/kolla_extend_start
+
 # NOTE(Jeffrey4l): remove kuryr-lib constraint in upper-constraints.txt file.
 # Otherwise, it will be failed.
 RUN ln -s kuryr-base-source/* kuryr-base \
     && sed -i 's|^kuryr-lib===.*$||g' requirements/upper-constraints.txt \
     && {{ macros.install_pip(kuryr_base_pip_packages | customizable("pip_packages")) }} \
     && mkdir -p /etc/kuryr \
-    && chown -R kuryr: /etc/kuryr
+    && chown -R kuryr: /etc/kuryr \
-
+    && chmod 644 /usr/local/bin/kolla_extend_start
-COPY extend_start.sh /usr/local/bin/kolla_extend_start
-RUN chmod 644 /usr/local/bin/kolla_extend_start
 
 {% block kuryr_base_footer %}{% endblock %}

docker/magnum/magnum-base/Dockerfile.j2

@@ -15,16 +15,15 @@ ADD magnum-base-archive /magnum-base-source
     '/magnum[osprofiler]'
 ] %}
 
+COPY extend_start.sh /usr/local/bin/kolla_extend_start
+
 RUN ln -s magnum-base-source/* magnum \
     && {{ macros.install_pip(magnum_base_pip_packages | customizable("pip_packages")) }} \
     && mkdir -p /etc/magnum \
     && cp -r /magnum/etc/magnum/* /etc/magnum \
     && mv /etc/magnum/keystone_auth_default_policy.sample /etc/magnum/keystone_auth_default_policy.json \
-    && chown -R magnum: /etc/magnum
+    && chown -R magnum: /etc/magnum \
-
+    && touch /usr/local/bin/kolla_magnum_extend_start \
-COPY extend_start.sh /usr/local/bin/kolla_extend_start
-
-RUN touch /usr/local/bin/kolla_magnum_extend_start \
     && chmod 644 /usr/local/bin/kolla_extend_start /usr/local/bin/kolla_magnum_extend_start
 
 {% block magnum_base_footer %}{% endblock %}

docker/manila/manila-api/Dockerfile.j2

@@ -11,11 +11,11 @@ LABEL maintainer="{{ maintainer }}" name="{{ image_name }}" build-date="{{ build
 ] %}
 {{ macros.install_packages(manila_api_packages | customizable("packages")) }}
 
-RUN mkdir -p /var/www/cgi-bin/manila \
-    && cp -a /var/lib/kolla/venv/bin/manila-wsgi /var/www/cgi-bin/manila/manila-wsgi
-
 COPY extend_start.sh /usr/local/bin/kolla_manila_extend_start
-RUN chmod 755 /usr/local/bin/kolla_manila_extend_start \
+
+RUN mkdir -p /var/www/cgi-bin/manila \
+    && cp -a /var/lib/kolla/venv/bin/manila-wsgi /var/www/cgi-bin/manila/manila-wsgi \
+    && chmod 755 /usr/local/bin/kolla_manila_extend_start \
     && chown -R manila: /var/www/cgi-bin/manila \
     && chmod 755 /var/www/cgi-bin/manila/manila-wsgi
 

docker/manila/manila-base/Dockerfile.j2

@@ -28,17 +28,16 @@ ADD manila-base-archive /manila-base-source
     '/manila'
 ] %}
 
+COPY extend_start.sh /usr/local/bin/kolla_extend_start
+COPY manila_sudoers /etc/sudoers.d/kolla_manila_sudoers
+
 RUN ln -s manila-base-source/* manila \
     && {{ macros.install_pip(manila_base_pip_packages | customizable("pip_packages")) }} \
     && mkdir -p /etc/manila /var/cache/manila \
     && cp -r /manila/etc/manila/* /etc/manila/ \
     && chown -R manila: /etc/manila /var/cache/manila \
-    && sed -i 's|^exec_dirs.*|exec_dirs=/var/lib/kolla/venv/bin,/sbin,/usr/sbin,/bin,/usr/bin,/usr/local/bin,/usr/local/sbin|g' /etc/manila/rootwrap.conf
+    && sed -i 's|^exec_dirs.*|exec_dirs=/var/lib/kolla/venv/bin,/sbin,/usr/sbin,/bin,/usr/bin,/usr/local/bin,/usr/local/sbin|g' /etc/manila/rootwrap.conf \
-
+    && chmod 750 /etc/sudoers.d \
-COPY extend_start.sh /usr/local/bin/kolla_extend_start
-COPY manila_sudoers /etc/sudoers.d/kolla_manila_sudoers
-
-RUN chmod 750 /etc/sudoers.d \
     && chmod 440 /etc/sudoers.d/kolla_manila_sudoers \
     && touch /usr/local/bin/kolla_manila_extend_start \
     && chmod 644 /usr/local/bin/kolla_extend_start /usr/local/bin/kolla_manila_extend_start

docker/mariadb/mariadb-server/Dockerfile.j2

@@ -39,8 +39,10 @@ RUN ln -s /usr/lib64/galera-4 /usr/lib64/galera
 COPY mariadb_sudoers /etc/sudoers.d/kolla_mariadb_sudoers
 COPY extend_start.sh /usr/local/bin/kolla_extend_start
 COPY security_reset.expect /usr/local/bin/kolla_security_reset
+COPY backup.sh /usr/local/bin/kolla_mariadb_backup.sh
+
 RUN chmod 644 /usr/local/bin/kolla_extend_start \
-    && chmod 755 /usr/local/bin/kolla_security_reset \
+    && chmod 755 /usr/local/bin/kolla_security_reset /usr/local/bin/kolla_mariadb_backup.sh \
     && chmod 750 /etc/sudoers.d \
     && chmod 440 /etc/sudoers.d/kolla_mariadb_sudoers \
     && rm -rf /var/lib/mysql/*
@@ -49,9 +51,6 @@ RUN chmod 644 /usr/local/bin/kolla_extend_start \
 RUN mkdir -p /var/run/mysqld && chown mysql /var/run/mysqld && chmod 755 /var/run/mysqld
 {% endif %}
 
-COPY backup.sh /usr/local/bin/kolla_mariadb_backup.sh
-RUN chmod 755 /usr/local/bin/kolla_mariadb_backup.sh
-
 {% if docker_healthchecks %}
 {% block healthcheck_installation %}
 

docker/masakari/masakari-base/Dockerfile.j2

@@ -23,24 +23,21 @@ LABEL maintainer="{{ maintainer }}" name="{{ image_name }}" build-date="{{ build
 
 {{ macros.install_packages(masakari_base_packages | customizable("packages")) }}
 
-RUN mkdir -p /var/www/cgi-bin/masakari
-
 ADD masakari-base-archive /masakari-base-source
 
 {% set masakari_base_pip_packages = [
     '/masakari'
 ] %}
 
+COPY extend_start.sh /usr/local/bin/kolla_extend_start
+
 RUN ln -s masakari-base-source/* masakari \
     && {{ macros.install_pip(masakari_base_pip_packages | customizable("pip_packages")) }} \
     && mkdir -p /etc/masakari /var/www/cgi-bin/masakari \
     && cp -r /masakari/etc/masakari/* /etc/masakari/ \
     && chown -R masakari: /etc/masakari /var/www/cgi-bin/masakari \
-    && chmod 755 /var/www/cgi-bin/masakari
+    && chmod 755 /var/www/cgi-bin/masakari \
-
+    && touch /usr/local/bin/kolla_masakari_extend_start \
-COPY extend_start.sh /usr/local/bin/kolla_extend_start
-
-RUN touch /usr/local/bin/kolla_masakari_extend_start \
     && chmod 644 /usr/local/bin/kolla_extend_start /usr/local/bin/kolla_masakari_extend_start
 
 {% block masakari_base_footer %}{% endblock %}

docker/masakari/masakari-monitors/Dockerfile.j2

@@ -39,14 +39,13 @@ ADD masakari-monitors-archive /masakari-monitors-source
     '/masakari-monitors'
 ] %}
 
+COPY masakari_monitors_sudoers /etc/sudoers.d/kolla_masakari_monitors_sudoers
+
 RUN ln -s masakari-monitors-source/* masakari-monitors \
     && {{ macros.install_pip(masakari_monitors_pip_packages | customizable("pip_packages")) }} \
     && mkdir -p /etc/masakari-monitors \
-    && chown -R masakari: /etc/masakari-monitors
+    && chown -R masakari: /etc/masakari-monitors \
-
+    && chmod 750 /etc/sudoers.d \
-COPY masakari_monitors_sudoers /etc/sudoers.d/kolla_masakari_monitors_sudoers
-
-RUN chmod 750 /etc/sudoers.d \
     && chmod 640 /etc/sudoers.d/kolla_masakari_monitors_sudoers
 
 {% block masakari_monitors_footer %}{% endblock %}

docker/mistral/mistral-base/Dockerfile.j2

@@ -21,6 +21,8 @@ ADD plugins-archive /
     '/plugins/*'
 ] %}
 
+COPY extend_start.sh /usr/local/bin/kolla_extend_start
+
 RUN ln -s mistral-base-source/* mistral \
     && {{ macros.install_pip(mistral_base_pip_packages | customizable("pip_packages")) }} \
     && mkdir -p /etc/mistral \
@@ -28,11 +30,8 @@ RUN ln -s mistral-base-source/* mistral \
     && chown -R mistral: /etc/mistral \
     && if [ "$(ls /plugins)" ]; then \
         {{ macros.install_pip(mistral_base_plugins_pip_packages) }}; \
-    fi
+       fi \
-
+    && touch /usr/local/bin/kolla_mistral_extend_start \
-COPY extend_start.sh /usr/local/bin/kolla_extend_start
-
-RUN touch /usr/local/bin/kolla_mistral_extend_start \
     && chmod 644 /usr/local/bin/kolla_extend_start /usr/local/bin/kolla_mistral_extend_start
 
 {% block mistral_base_footer %}{% endblock %}

docker/monasca/monasca-api/Dockerfile.j2

@@ -23,11 +23,11 @@ ADD monasca-api-archive /monasca-api-source
     '/monasca-api'
 ] %}
 
-RUN ln -s monasca-api-source/* monasca-api \
-    && {{ macros.install_pip(monasca_api_pip_packages | customizable("pip_packages")) }}
-
 COPY extend_start.sh /usr/local/bin/kolla_monasca_extend_start
-RUN chmod 755 /usr/local/bin/kolla_monasca_extend_start
+
+RUN ln -s monasca-api-source/* monasca-api \
+    && {{ macros.install_pip(monasca_api_pip_packages | customizable("pip_packages")) }} \
+    && chmod 755 /usr/local/bin/kolla_monasca_extend_start
 
 {% block monasca_api_footer %}{% endblock %}
 

docker/murano/murano-base/Dockerfile.j2

@@ -15,6 +15,8 @@ ADD murano-base-archive /murano-base-source
     '/murano'
 ] %}
 
+COPY extend_start.sh /usr/local/bin/kolla_extend_start
+
 RUN ln -s murano-base-source/* murano \
     && {{ macros.install_pip(murano_base_pip_packages | customizable("pip_packages")) }} \
     && mkdir -p /etc/murano \
@@ -23,11 +25,8 @@ RUN ln -s murano-base-source/* murano \
     && cd murano/meta/io.murano \
     && zip -r /io.murano.zip * \
     && cd /murano/meta/io.murano.applications \
-    && zip -r /io.murano.applications.zip *
+    && zip -r /io.murano.applications.zip * \
-
+    && touch /usr/local/bin/kolla_murano_extend_start \
-COPY extend_start.sh /usr/local/bin/kolla_extend_start
-
-RUN touch /usr/local/bin/kolla_murano_extend_start \
     && chmod 644 /usr/local/bin/kolla_extend_start /usr/local/bin/kolla_murano_extend_start
 
 {% block murano_base_footer %}{% endblock %}

docker/neutron/neutron-base/Dockerfile.j2

@@ -64,6 +64,9 @@ ADD plugins-archive /
     '/plugins/*'
 ] %}
 
+COPY neutron_sudoers /etc/sudoers.d/kolla_neutron_sudoers
+COPY extend_start.sh /usr/local/bin/kolla_extend_start
+
 RUN ln -s neutron-base-source/* neutron \
     && {{ macros.install_pip(neutron_base_pip_packages | customizable("pip_packages")) }} \
     && mkdir -p /etc/neutron \
@@ -79,12 +82,8 @@ RUN ln -s neutron-base-source/* neutron \
                 cp /plugins/$neutron_plugins/etc/neutron/rootwrap.d/* /etc/neutron/rootwrap.d; \
             fi; \
         done; \
-    fi
+       fi \
-
+    && chmod 750 /etc/sudoers.d \
-COPY neutron_sudoers /etc/sudoers.d/kolla_neutron_sudoers
-COPY extend_start.sh /usr/local/bin/kolla_extend_start
-
-RUN chmod 750 /etc/sudoers.d \
     && chmod 440 /etc/sudoers.d/kolla_neutron_sudoers \
     && touch /usr/local/bin/kolla_neutron_extend_start \
     && chmod 644 /usr/local/bin/kolla_extend_start /usr/local/bin/kolla_neutron_extend_start

docker/neutron/neutron-server/Dockerfile.j2

@@ -16,13 +16,14 @@ LABEL maintainer="{{ maintainer }}" name="{{ image_name }}" build-date="{{ build
 ] %}
 
 ADD plugins-archive /
+
+COPY extend_start.sh /usr/local/bin/kolla_neutron_extend_start
+
 RUN {{ macros.install_pip(neutron_server_pip_packages | customizable("pip_packages")) }} \
     && if [ "$(ls /plugins)" ]; then \
            {{ macros.install_pip(neutron_server_plugins_pip_packages) }}; \
-       fi
+       fi \
-
+    && chmod 755 /usr/local/bin/kolla_neutron_extend_start
-COPY extend_start.sh /usr/local/bin/kolla_neutron_extend_start
-RUN chmod 755 /usr/local/bin/kolla_neutron_extend_start
 
 {% block neutron_server_footer %}{% endblock %}
 {% block footer %}{% endblock %}

docker/nova/nova-base/Dockerfile.j2

@@ -63,6 +63,9 @@ ADD plugins-archive /
     '/plugins/*'
 ] %}
 
+COPY nova_sudoers /etc/sudoers.d/kolla_nova_sudoers
+COPY extend_start.sh /usr/local/bin/kolla_extend_start
+
 RUN ln -s nova-base-source/* nova \
     && {{ macros.install_pip(nova_base_pip_packages | customizable("pip_packages")) }} \
     && mkdir -p /etc/nova/ \
@@ -71,15 +74,10 @@ RUN ln -s nova-base-source/* nova \
     && sed -i 's|^exec_dirs.*|exec_dirs=/var/lib/kolla/venv/bin,/sbin,/usr/sbin,/bin,/usr/bin,/usr/local/bin,/usr/local/sbin|g' /etc/nova/rootwrap.conf \
     && if [ "$(ls /plugins)" ]; then \
         {{ macros.install_pip(nova_base_plugins_pip_packages) }}; \
-    fi
+       fi \
-
+    && chmod 750 /etc/sudoers.d \
-COPY nova_sudoers /etc/sudoers.d/kolla_nova_sudoers
+    && chmod 440 /etc/sudoers.d/kolla_nova_sudoers \
-RUN chmod 750 /etc/sudoers.d \
+    && touch /usr/local/bin/kolla_nova_extend_start \
-    && chmod 440 /etc/sudoers.d/kolla_nova_sudoers
-
-COPY extend_start.sh /usr/local/bin/kolla_extend_start
-
-RUN touch /usr/local/bin/kolla_nova_extend_start \
     && chmod 644 /usr/local/bin/kolla_extend_start /usr/local/bin/kolla_nova_extend_start
 
 {% block nova_base_footer %}{% endblock %}

docker/nova/nova-compute/Dockerfile.j2

@@ -96,13 +96,14 @@ RUN mkdir -p /etc/ceph \
 ] %}
 
 ADD plugins-archive /
+
+COPY extend_start.sh /usr/local/bin/kolla_nova_extend_start
+
 RUN {{ macros.install_pip(nova_compute_pip_packages | customizable("pip_packages")) }} \
     && if [ "$(ls /plugins)" ]; then \
            {{ macros.install_pip(nova_compute_plugins_pip_packages) }}; \
-       fi
+       fi \
-
+    && chmod 755 /usr/local/bin/kolla_nova_extend_start \
-COPY extend_start.sh /usr/local/bin/kolla_nova_extend_start
-RUN chmod 755 /usr/local/bin/kolla_nova_extend_start \
     && rm -f /etc/machine-id
 
 {% block nova_compute_footer %}{% endblock %}

docker/nova/nova-ssh/Dockerfile.j2

@@ -28,10 +28,10 @@ RUN mkdir -p /var/run/sshd \
 
 {{ macros.install_packages(nova_ssh_packages | customizable("packages")) }}
 
-RUN sed -ri 's/session(\s+)required(\s+)pam_loginuid.so/session\1optional\2pam_loginuid.so/' /etc/pam.d/sshd
-
 COPY extend_start.sh /usr/local/bin/kolla_extend_start
-RUN chmod 644 /usr/local/bin/kolla_extend_start
+
+RUN sed -ri 's/session(\s+)required(\s+)pam_loginuid.so/session\1optional\2pam_loginuid.so/' /etc/pam.d/sshd \
+    && chmod 644 /usr/local/bin/kolla_extend_start
 
 {% block nova_ssh_footer %}{% endblock %}
 {% block footer %}{% endblock %}

docker/octavia/octavia-api/Dockerfile.j2

@@ -15,14 +15,15 @@ LABEL maintainer="{{ maintainer }}" name="{{ image_name }}" build-date="{{ build
 ] %}
 
 ADD plugins-archive /
+
+COPY extend_start.sh /usr/local/bin/kolla_octavia_extend_start
+
 RUN if [ "$(ls /plugins)" ]; then \
         {{ macros.install_pip(octavia_api_plugins_pip_packages) }} ; \
-    fi
+    fi \
+    && chmod 755 /usr/local/bin/kolla_octavia_extend_start
 
 {{ macros.install_packages(octavia_api_packages | customizable("packages")) }}
 
-COPY extend_start.sh /usr/local/bin/kolla_octavia_extend_start
-RUN chmod 755 /usr/local/bin/kolla_octavia_extend_start
-
 {% block octavia_api_footer %}{% endblock %}
 {% block footer %}{% endblock %}

docker/octavia/octavia-base/Dockerfile.j2

@@ -22,15 +22,14 @@ ADD octavia-base-archive /octavia-base-source
     '/octavia'
 ] %}
 
+COPY extend_start.sh /usr/local/bin/kolla_extend_start
+
 RUN ln -s /octavia-base-source/* octavia \
     && {{ macros.install_pip(octavia_base_pip_packages | customizable("pip_packages")) }} \
     && mkdir -p /etc/octavia \
     && cp -r /octavia/etc/* /etc/octavia/ \
-    && chown -R octavia: /etc/octavia
+    && chown -R octavia: /etc/octavia \
-
+    && touch /usr/local/bin/kolla_octavia_extend_start \
-COPY extend_start.sh /usr/local/bin/kolla_extend_start
-
-RUN touch /usr/local/bin/kolla_octavia_extend_start \
     && chmod 644 /usr/local/bin/kolla_extend_start /usr/local/bin/kolla_octavia_extend_start
 
 {% block octavia_base_footer %}{% endblock %}

docker/placement/placement-base/Dockerfile.j2

@@ -30,15 +30,14 @@ ADD plugins-archive /
     '/placement'
 ] %}
 
+COPY extend_start.sh /usr/local/bin/kolla_extend_start
+
 RUN ln -s placement-base-source/* placement \
     && {{ macros.install_pip(placement_base_pip_packages | customizable("pip_packages")) }} \
     && mkdir -p /etc/placement/ \
     && cp -r /placement/etc/placement/* /etc/placement/ \
-    && chown -R placement: /etc/placement/
+    && chown -R placement: /etc/placement/ \
-
+    && touch /usr/local/bin/kolla_placement_extend_start \
-COPY extend_start.sh /usr/local/bin/kolla_extend_start
-
-RUN touch /usr/local/bin/kolla_placement_extend_start \
     && chmod 644 /usr/local/bin/kolla_extend_start /usr/local/bin/kolla_placement_extend_start
 
 {% block placement_base_footer %}{% endblock %}

docker/prometheus/prometheus-blackbox-exporter/Dockerfile.j2

@@ -28,8 +28,8 @@ ARG blackbox_exporter_url=https://github.com/prometheus/blackbox_exporter/releas
 RUN curl -o /tmp/blackbox_exporter.tar.gz ${blackbox_exporter_url} \
     && tar xvf /tmp/blackbox_exporter.tar.gz -C /opt/ \
     && rm -f /tmp/blackbox_exporter.tar.gz \
-    && ln -s /opt/blackbox_exporter* /opt/blackbox_exporter
+    && ln -s /opt/blackbox_exporter* /opt/blackbox_exporter \
-RUN setcap cap_net_raw+ep /opt/blackbox_exporter/blackbox_exporter
+    && setcap cap_net_raw+ep /opt/blackbox_exporter/blackbox_exporter
 {% endblock %}
 
 {% block prometheus_blackbox_exporter_footer %}{% endblock %}

docker/sahara/sahara-base/Dockerfile.j2

@@ -26,6 +26,9 @@ ADD plugins-archive /
     '/plugins/*',
 ] %}
 
+COPY sahara_sudoers /etc/sudoers.d/kolla_sahara_sudoers
+COPY extend_start.sh /usr/local/bin/kolla_extend_start
+
 RUN ln -s sahara-base-source/* sahara \
     && {{ macros.install_pip(sahara_base_pip_packages | customizable("pip_packages")) }} \
     && if [ "$(ls /plugins)" ]; then \
@@ -34,12 +37,8 @@ RUN ln -s sahara-base-source/* sahara \
     && mkdir -p /etc/sahara \
     && cp -r /sahara/etc/sahara/* /etc/sahara/ \
     && chown -R sahara: /etc/sahara \
-    && sed -i 's|^exec_dirs.*|exec_dirs=/var/lib/kolla/venv/bin,/sbin,/usr/sbin,/bin,/usr/bin,/usr/local/bin,/usr/local/sbin|g' /etc/sahara/rootwrap.conf
+    && sed -i 's|^exec_dirs.*|exec_dirs=/var/lib/kolla/venv/bin,/sbin,/usr/sbin,/bin,/usr/bin,/usr/local/bin,/usr/local/sbin|g' /etc/sahara/rootwrap.conf \
-
+    && chmod 750 /etc/sudoers.d \
-COPY sahara_sudoers /etc/sudoers.d/kolla_sahara_sudoers
-COPY extend_start.sh /usr/local/bin/kolla_extend_start
-
-RUN chmod 750 /etc/sudoers.d \
     && chmod 640 /etc/sudoers.d/kolla_sahara_sudoers \
     && touch /usr/local/bin/kolla_sahara_extend_start \
     && chmod 644 /usr/local/bin/kolla_extend_start /usr/local/bin/kolla_sahara_extend_start

docker/senlin/senlin-base/Dockerfile.j2

@@ -15,15 +15,14 @@ ADD senlin-base-archive /senlin-base-source
     '/senlin'
 ] %}
 
+COPY extend_start.sh /usr/local/bin/kolla_extend_start
+
 RUN ln -s senlin-base-source/* senlin \
     && {{ macros.install_pip(senlin_base_pip_packages | customizable("pip_packages")) }} \
     && mkdir -p /etc/senlin \
     && cp -r /senlin/etc/senlin/* /etc/senlin \
-    && chown -R senlin: /etc/senlin
+    && chown -R senlin: /etc/senlin \
-
+    && touch /usr/local/bin/kolla_senlin_extend_start \
-COPY extend_start.sh /usr/local/bin/kolla_extend_start
-
-RUN touch /usr/local/bin/kolla_senlin_extend_start \
     && chmod 644 /usr/local/bin/kolla_extend_start /usr/local/bin/kolla_senlin_extend_start
 
 {% block senlin_base_footer %}{% endblock %}

docker/solum/solum-base/Dockerfile.j2

@@ -15,15 +15,14 @@ ADD solum-base-archive /solum-base-source
     '/solum'
 ] %}
 
+COPY extend_start.sh /usr/local/bin/kolla_extend_start
+
 RUN ln -s solum-base-source/* solum \
     && {{ macros.install_pip(solum_base_pip_packages | customizable("pip_packages")) }} \
     && mkdir -p /etc/solum \
     && cp -r /solum/etc/solum/* /etc/solum/ \
-    && chown -R solum: /etc/solum
+    && chown -R solum: /etc/solum \
-
+    && touch /usr/local/bin/kolla_solum_extend_start \
-COPY extend_start.sh /usr/local/bin/kolla_extend_start
-
-RUN touch /usr/local/bin/kolla_solum_extend_start \
     && chmod 644 /usr/local/bin/kolla_extend_start /usr/local/bin/kolla_solum_extend_start
 
 {% block solum_base_footer %}{% endblock %}

docker/swift/swift-base/Dockerfile.j2

@@ -30,17 +30,16 @@ ADD swift-base-archive /swift-base-source
     '/swift'
 ] %}
 
-RUN ln -s swift-base-source/* swift \
-    && {{ macros.install_pip(swift_base_pip_packages | customizable("pip_packages")) }} \
-    && mkdir -p /etc/swift /var/cache/swift /var/lock/swift \
-    && cp -r /swift/etc/* /etc/swift/ \
-    && chown -R swift: /etc/swift /var/cache/swift /var/lock/swift
-
 COPY swift-rootwrap /var/lib/kolla/venv/bin/swift-rootwrap
 COPY rootwrap.conf /etc/swift/rootwrap.conf
 COPY swift_sudoers /etc/sudoers.d/kolla_swift_sudoers
 
-RUN chmod 755 /var/lib/kolla/venv/bin/swift-rootwrap \
+RUN ln -s swift-base-source/* swift \
+    && {{ macros.install_pip(swift_base_pip_packages | customizable("pip_packages")) }} \
+    && mkdir -p /etc/swift /var/cache/swift /var/lock/swift \
+    && cp -r /swift/etc/* /etc/swift/ \
+    && chown -R swift: /etc/swift /var/cache/swift /var/lock/swift \
+    && chmod 755 /var/lib/kolla/venv/bin/swift-rootwrap \
     && chmod 644 /etc/swift/rootwrap.conf \
     && sed -i 's|^exec_dirs.*|exec_dirs=/var/lib/kolla/venv/bin,/sbin,/usr/sbin,/bin,/usr/bin,/usr/local/bin,/usr/local/sbin|g' /etc/swift/rootwrap.conf \
     && chmod 750 /etc/sudoers.d \

docker/tacker/tacker-base/Dockerfile.j2

@@ -21,6 +21,8 @@ ADD plugins-archive /
     '/plugins/*'
 ] %}
 
+COPY extend_start.sh /usr/local/bin/kolla_extend_start
+
 RUN ln -s tacker-base-source/* tacker \
     && {{ macros.install_pip(tacker_base_pip_packages | customizable("pip_packages")) }} \
     && mkdir -p /etc/tacker \
@@ -28,11 +30,8 @@ RUN ln -s tacker-base-source/* tacker \
     && chown -R tacker: /etc/tacker \
     && if [ "$(ls /plugins)" ]; then \
         {{ macros.install_pip(tacker_base_plugins_pip_packages) }}; \
-    fi
+       fi \
-
+    && touch /usr/local/bin/kolla_tacker_extend_start \
-COPY extend_start.sh /usr/local/bin/kolla_extend_start
-
-RUN touch /usr/local/bin/kolla_tacker_extend_start \
     && chmod 644 /usr/local/bin/kolla_extend_start /usr/local/bin/kolla_tacker_extend_start
 
 {% block tacker_base_footer %}{% endblock %}

docker/trove/trove-base/Dockerfile.j2

@@ -15,15 +15,14 @@ ADD trove-base-archive /trove-base-source
     '/trove'
 ] %}
 
+COPY extend_start.sh /usr/local/bin/kolla_extend_start
+
 RUN ln -s trove-base-source/* trove \
     && {{ macros.install_pip(trove_base_pip_packages | customizable("pip_packages")) }} \
     && mkdir -p /etc/trove \
     && cp -r /trove/etc/trove/* /etc/trove/ \
-    && chown -R trove: /etc/trove
+    && chown -R trove: /etc/trove \
-
+    && touch /usr/local/bin/kolla_trove_extend_start \
-COPY extend_start.sh /usr/local/bin/kolla_extend_start
-
-RUN touch /usr/local/bin/kolla_trove_extend_start \
     && chmod 644 /usr/local/bin/kolla_extend_start /usr/local/bin/kolla_trove_extend_start
 
 {% block trove_base_footer %}{% endblock %}

docker/venus/venus-base/Dockerfile.j2

@@ -15,15 +15,14 @@ ADD venus-base-archive /venus-base-source
     '/venus'
 ] %}
 
+COPY extend_start.sh /usr/local/bin/kolla_extend_start
+
 RUN ln -s venus-base-source/* venus \
     && {{ macros.install_pip(venus_base_pip_packages | customizable("pip_packages")) }} \
     && mkdir -p /etc/venus \
     && cp -r /venus/etc/venus/* /etc/venus/ \
-    && chown -R venus: /etc/venus
+    && chown -R venus: /etc/venus \
-
+    && touch /usr/local/bin/kolla_venus_extend_start \
-COPY extend_start.sh /usr/local/bin/kolla_extend_start
-
-RUN touch /usr/local/bin/kolla_venus_extend_start \
     && chmod 644 /usr/local/bin/kolla_extend_start /usr/local/bin/kolla_venus_extend_start
 
 {% block venus_base_footer %}{% endblock %}

docker/vitrage/vitrage-base/Dockerfile.j2

@@ -28,15 +28,16 @@ LABEL maintainer="{{ maintainer }}" name="{{ image_name }}" build-date="{{ build
 ] %}
 
 ADD vitrage-base-archive /vitrage-base-source
+
+COPY extend_start.sh /usr/local/bin/kolla_extend_start
+
 RUN ln -s vitrage-base-source/* vitrage \
     && {{ macros.install_pip(vitrage_base_pip_packages | customizable("pip_packages")) }} \
     && mkdir -p /etc/vitrage /var/www/cgi-bin/vitrage \
     && cp -r /vitrage/etc/vitrage/* /etc/vitrage/ \
     && cp /vitrage/vitrage/api/app.wsgi /var/www/cgi-bin/vitrage \
-    && chown -R vitrage: /etc/vitrage /var/www/cgi-bin/vitrage
+    && chown -R vitrage: /etc/vitrage /var/www/cgi-bin/vitrage \
-
+    && touch /usr/local/bin/kolla_vitrage_extend_start \
-COPY extend_start.sh /usr/local/bin/kolla_extend_start
-RUN touch /usr/local/bin/kolla_vitrage_extend_start \
     && chmod 644 /usr/local/bin/kolla_extend_start /usr/local/bin/kolla_vitrage_extend_start
 
 {% block vitrage_base_footer %}{% endblock %}

docker/watcher/watcher-base/Dockerfile.j2

@@ -16,15 +16,14 @@ ADD watcher-base-archive /watcher-base-source
     '/watcher'
 ] %}
 
+COPY extend_start.sh /usr/local/bin/kolla_extend_start
+
 RUN ln -s watcher-base-source/* watcher \
     && {{ macros.install_pip(watcher_base_pip_packages | customizable("pip_packages")) }} \
     && mkdir -p /etc/watcher \
     && cp -r /watcher/etc/watcher/* /etc/watcher/ \
-    && chown -R watcher: /etc/watcher
+    && chown -R watcher: /etc/watcher \
-
+    && touch /usr/local/bin/kolla_watcher_extend_start \
-COPY extend_start.sh /usr/local/bin/kolla_extend_start
-
-RUN touch /usr/local/bin/kolla_watcher_extend_start \
     && chmod 644 /usr/local/bin/kolla_extend_start /usr/local/bin/kolla_watcher_extend_start
 
 {% block watcher_base_footer %}{% endblock %}

docker/zun/zun-base/Dockerfile.j2

@@ -35,18 +35,17 @@ ADD zun-base-archive /zun-base-source
     '/zun'
 ] %}
 
+COPY zun_sudoers /etc/sudoers.d/kolla_zun_sudoers
+COPY extend_start.sh /usr/local/bin/kolla_extend_start
+
 RUN ln -s zun-base-source/* zun \
     && {{ macros.install_pip(zun_base_pip_packages | customizable("pip_packages")) }} \
     && mkdir -p /etc/zun /var/www/cgi-bin/zun \
     && cp -r /zun/etc/zun/* /etc/zun/ \
     && cp /zun/zun/api/app.wsgi /var/www/cgi-bin/zun \
     && chown -R zun: /etc/zun /var/www/cgi-bin/zun \
-    && sed -i 's|^exec_dirs.*|exec_dirs=/var/lib/kolla/venv/bin,/sbin,/usr/sbin,/bin,/usr/bin,/usr/local/bin,/usr/local/sbin|g' /etc/zun/rootwrap.conf
+    && sed -i 's|^exec_dirs.*|exec_dirs=/var/lib/kolla/venv/bin,/sbin,/usr/sbin,/bin,/usr/bin,/usr/local/bin,/usr/local/sbin|g' /etc/zun/rootwrap.conf \
-
+    && chmod 750 /etc/sudoers.d \
-COPY zun_sudoers /etc/sudoers.d/kolla_zun_sudoers
-COPY extend_start.sh /usr/local/bin/kolla_extend_start
-
-RUN chmod 750 /etc/sudoers.d \
     && chmod 640 /etc/sudoers.d/kolla_zun_sudoers \
     && touch /usr/local/bin/kolla_zun_extend_start \
     && chmod 755 /var/www/cgi-bin/zun \

docker/zun/zun-cni-daemon/Dockerfile.j2

@@ -23,17 +23,16 @@ LABEL maintainer="{{ maintainer }}" name="{{ image_name }}" build-date="{{ build
 {% endif %}
 {{ macros.install_packages(zun_cni_daemon_packages | customizable("packages")) }}
 
-COPY zun_sudoers /etc/sudoers.d/kolla_zun_sudoers
-
-RUN chmod 750 /etc/sudoers.d \
-    && chmod 640 /etc/sudoers.d/kolla_zun_sudoers
-
 {% block zun_cni_daemon_version %}
 ARG zun_cni_daemon_version=0.7.1
 ARG zun_cni_daemon_url=https://github.com/containernetworking/plugins/releases/download/v${zun_cni_daemon_version}/cni-plugins-amd64-v${zun_cni_daemon_version}.tgz
 {% endblock %}
 
-RUN curl -o /tmp/cni-plugins.tgz ${zun_cni_daemon_url} \
+COPY zun_sudoers /etc/sudoers.d/kolla_zun_sudoers
+
+RUN chmod 750 /etc/sudoers.d \
+    && chmod 640 /etc/sudoers.d/kolla_zun_sudoers \
+    && curl -o /tmp/cni-plugins.tgz ${zun_cni_daemon_url} \
     && tar -C /opt -xzvf /tmp/cni-plugins.tgz ./loopback \
     && rm -f /tmp/cni-plugins.tgz